[PRE REVIEW]: giotto-deep: A Python Package for Topological Deep Learning

[editorialbot]

Submitting author: !--author-handle-->@matteocao<!--end-author-handle-- (Matteo Caorsi) Repository: https://github.com/giotto-ai/giotto-deep Branch with paper.md (empty if default branch): paper Version: v0.0.3 Editor: !--editor-->@osorensen<!--end-editor-- Reviewers: @EduPH, @leotrs, @ismailguzel Managing EiC: Kevin M. Moerman

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f1f94829081bb7f0f16c48cafe1524d7"><img src="https://joss.theoj.org/papers/f1f94829081bb7f0f16c48cafe1524d7/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f1f94829081bb7f0f16c48cafe1524d7/status.svg)](https://joss.theoj.org/papers/f1f94829081bb7f0f16c48cafe1524d7)

Author instructions

Thanks for submitting your paper to JOSS @matteocao. Currently, there isn't a JOSS editor assigned to your paper.

@matteocao if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[editorialbot]

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.88  T=0.02 s (181.4 files/s, 11971.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Markdown                         1             15              0             77
TeX                              1              9              0             74
YAML                             1              1              4             18
-------------------------------------------------------------------------------
SUM:                             3             25              4            169
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository

[editorialbot]

Wordcount for paper.md is 663

[editorialbot]

Failed to discover a valid open source license

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1017/9781316671665.004 may be a valid DOI for title: Topological data analysis
- 10.1145/1873951.1874254 may be a valid DOI for title: Torchvision the machine-vision package of torch
- 10.3389/frai.2021.681108 may be a valid DOI for title: A survey of topological machine learning methods

INVALID DOIs

- None

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[Kevin-Mattheus-Moerman]

@matteocao the above lines of code counts seem very low :point_up: can you clarify what the submission to be reviewed entails? Is it just the content over at https://github.com/giotto-ai/giotto-deep or is there other content/repos too?

[Kevin-Mattheus-Moerman]

@editorialbot check repository

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.88  T=0.01 s (385.0 files/s, 25407.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Markdown                         1             15              0             77
TeX                              1              9              0             74
YAML                             1              1              4             18
-------------------------------------------------------------------------------
SUM:                             3             25              4            169
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository

[editorialbot]

Wordcount for paper.md is 663

[editorialbot]

Failed to discover a valid open source license

[matteocao]

Dear @Kevin-Mattheus-Moerman ,

Thank you for your comments.

If I understand your question correctly, I would say that the editorialbot is not counting properly: it is excluding all the files with .py extension as well as .ipynb which form the core of the library (thousands of lines). Furthermore, there are k8 yaml files not considered either. The license is the standard AGPLv3, which is also not discovered by the editorialbot apparently.

Finally, the library code is in the main branch of https://github.com/giotto-ai/giotto-deep , while the paper is in the paper branch. Please let me know if this clarifies the submission content.

[arfon]

Here's the output of cloc on the main branch:

 cloc giotto-deep/
     198 text files.
     196 unique files.                                          
      21 files ignored.

github.com/AlDanial/cloc v 1.86  T=0.19 s (1007.1 files/s, 119234.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                         119           1991           3403           7959
Jupyter Notebook                18              0           5264           1894
YAML                            15             18             13            491
Markdown                         5             84              0            313
reStructuredText                19            161            101            250
JSON                             3              0              0             61
Dockerfile                       3             17             10             36
DOS Batch                        1              8              1             26
SVG                              2              0              0             17
make                             1              4              7              9
HTML                             1              0              0              1
-------------------------------------------------------------------------------
SUM:                           187           2283           8799          11057
-------------------------------------------------------------------------------

[arfon]

@matteocao - thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

[kthyng]

Hi @osorensen! Could you edit this submission?

[kthyng]

@editorialbot invite @osorensen as editor

[editorialbot]

Invitation to edit this submission sent!

[osorensen]

@editorialbot assign @osorensen as editor

[editorialbot]

Assigned! @osorensen is now the editor

[osorensen]

@editorialbot generate pdf

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[osorensen]

👋 @ismailguzel @leotrs @EduPH @Annielytix, would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

[EduPH]

Hello, I'm available.

[osorensen]

@editorialbot add @EduPH as reviewer

[editorialbot]

@EduPH added to the reviewers list!

[leotrs]

Yes.

[osorensen]

@editorialbot add @leotrs as reviewer

[editorialbot]

@leotrs added to the reviewers list!

[ismailguzel]

Yes. It will be my pleasure. Thank you.

[osorensen]

@editorialbot add @ismailguzel as reviewer

[editorialbot]

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

[osorensen]

@editorialbot add @ismailguzel as reviewer

[editorialbot]

@ismailguzel added to the reviewers list!

[osorensen]

@editorialbot start review

[editorialbot]

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/4846.