search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
707 stars 37 forks source link

[REVIEW]: POSEIDON: A Multidimensional Atmospheric Retrieval Code for Exoplanet Spectra #4873

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@MartianColonist<!--end-author-handle-- (Ryan J. MacDonald) Repository: https://github.com/MartianColonist/POSEIDON Branch with paper.md (empty if default branch): main Version: 1.0.0 Editor: !--editor-->@dfm<!--end-editor-- Reviewers: @ideasrule, @LorenzoMugnai Archive: 10.5281/zenodo.7530543

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/69710c0498d02fd1c6a0cfa4b01af7c5"><img src="https://joss.theoj.org/papers/69710c0498d02fd1c6a0cfa4b01af7c5/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/69710c0498d02fd1c6a0cfa4b01af7c5/status.svg)](https://joss.theoj.org/papers/69710c0498d02fd1c6a0cfa4b01af7c5)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@ideasrule & @LorenzoMugnai, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @dfm know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @LorenzoMugnai

📝 Checklist for @ideasrule

editorialbot commented 1 year ago

Done! Archive is now 10.5281/zenodo.7530543

dfm commented 1 year ago

@editorialbot set 1.0.0 as version

editorialbot commented 1 year ago

Done! version is now 1.0.0

dfm commented 1 year ago

@editorialbot check references

dfm commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/mnras/stx804 is OK
- 10.3847/1538-4357/ac47fe is OK
- 10.1088/1538-3873/aaf5ad is OK
- 10.3847/1538-4357/aba1e6 is OK
- 10.1051/0004-6361/201935470 is OK
- 10.1088/0004-637X/775/2/137 is OK
- 10.1093/mnras/stab1405 is OK
- 10.1088/0004-637X/802/2/107 is OK
- 10.3847/1538-4357/ac0252 is OK
- 10.3847/PSJ/ac3513 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1051/0004-6361/201322971 is OK
- 10.1038/nature23651 is OK
- 10.3847/2041-8213/aba9d3 is OK
- 10.3847/2041-8213/abd18e is OK
- 10.3847/0004-637X/820/1/78 is OK
- 10.1051/0004-6361/201834384 is OK
- 10.3847/2041-8213/ab8238 is OK
- 10.1051/0004-6361/202141943 is OK
- 10.1016/j.jqsrt.2007.11.006 is OK
- 10.3847/2041-8213/abb77f is OK
- 10.3847/1538-3881/ac0e99 is OK
- 10.1007/s10686-021-09821-w is OK
- 10.48550/arXiv.2104.04824 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

dfm commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago 
Attempting dry run of processing paper acceptance...
editorialbot commented 1 year ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/mnras/stx804 is OK
- 10.3847/1538-4357/ac47fe is OK
- 10.1088/1538-3873/aaf5ad is OK
- 10.3847/1538-4357/aba1e6 is OK
- 10.1051/0004-6361/201935470 is OK
- 10.1088/0004-637X/775/2/137 is OK
- 10.1093/mnras/stab1405 is OK
- 10.1088/0004-637X/802/2/107 is OK
- 10.3847/1538-4357/ac0252 is OK
- 10.3847/PSJ/ac3513 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1051/0004-6361/201322971 is OK
- 10.1038/nature23651 is OK
- 10.3847/2041-8213/aba9d3 is OK
- 10.3847/2041-8213/abd18e is OK
- 10.3847/0004-637X/820/1/78 is OK
- 10.1051/0004-6361/201834384 is OK
- 10.3847/2041-8213/ab8238 is OK
- 10.1051/0004-6361/202141943 is OK
- 10.1016/j.jqsrt.2007.11.006 is OK
- 10.3847/2041-8213/abb77f is OK
- 10.3847/1538-3881/ac0e99 is OK
- 10.1007/s10686-021-09821-w is OK
- 10.48550/arXiv.2104.04824 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 1 year ago

:wave: @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3874, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

dfm commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago 
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 1 year ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

editorialbot commented 1 year ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 1 year ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/3875
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.04873
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

dfm commented 1 year ago

@ideasrule, @LorenzoMugnai — Many thanks for your reviews here! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!!

@MartianColonist — Your paper is now accepted and published in JOSS! :zap::rocket::boom:

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04873/status.svg)](https://doi.org/10.21105/joss.04873)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04873">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04873/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04873/status.svg
   :target: https://doi.org/10.21105/joss.04873

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: