openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
704 stars 37 forks source link

[REVIEW]: PyArabic: A Python package for Arabic text #4886

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@linuxscout<!--end-author-handle-- (Taha Zerrouki) Repository: https://github.com/linuxscout/pyarabic Branch with paper.md (empty if default branch): paper Version: 0.6.16 Editor: !--editor-->@ajstewartlang<!--end-editor-- Reviewers: @amitkumarj441, @kikarimullah Archive: 10.5281/zenodo.7833909

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/88253a3d82cca64ee32e88fc8925991b"><img src="https://joss.theoj.org/papers/88253a3d82cca64ee32e88fc8925991b/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/88253a3d82cca64ee32e88fc8925991b/status.svg)](https://joss.theoj.org/papers/88253a3d82cca64ee32e88fc8925991b)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@amitkumarj441 & @kikarimullah, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @ajstewartlang know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @amitkumarj441

📝 Checklist for @kikarimullah

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

amitkumarj441 commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5121/ijdkp.2016.6602 is OK
- 10.1177/0165551519849516 is OK
- 10.1109/wits.2019.8723864 is OK
- 10.1016/j.procs.2017.10.111 is OK
- 10.1117/12.2242187 is OK
- 10.1109/icics52457.2021.9464602 is OK
- 10.1007/978-3-030-33582-3_1 is OK
- 10.1109/ICICS52457.2021.9464614 is OK
- 10.1057/s41599-021-00798-7 is OK
- 10.14569/IJACSA.2022.0130751 is OK
- 10.14569/ijacsa.2020.0111045 is OK
- 10.1007/978-981-15-0947-6_76 is OK
- 10.1109/fmec.2019.8795331 is OK
- 10.1109/icics52457.2021.9464566 is OK
- 10.1007/978-3-030-36778-7_22 is OK
- 10.1109/ICICS52457.2021.9464531 is OK
- 10.48550/ARXIV.1910.00421 is OK
- 10.18653/v1/2021.eacl-main.204 is OK
- 10.18280/ria.340111 is OK
- 10.3390/app12094188 is OK
- 10.11591/ijeecs.v19.i2.pp1010-1020 is OK
- 10.1109/iciev.2019.8858561 is OK
- 10.11591/ijece.v12i4.pp4195-4205 is OK
- 10.1109/icics55353.2022.9811149 is OK
- 10.1016/j.knosys.2022.108180 is OK
- 10.1007/s13369-021-05383-3 is OK
- 10.3390/bdcc6020048 is OK
- 10.1177/14604582211070998 is OK
- 10.18653/v1/N16-3003 is OK

MISSING DOIs

- None

INVALID DOIs

- 10.1109/icics52457.2021.9464605 is INVALID (failed connection)
amitkumarj441 commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5121/ijdkp.2016.6602 is OK
- 10.1177/0165551519849516 is OK
- 10.1109/wits.2019.8723864 is OK
- 10.1016/j.procs.2017.10.111 is OK
- 10.1117/12.2242187 is OK
- 10.1109/icics52457.2021.9464602 is OK
- 10.1007/978-3-030-33582-3_1 is OK
- 10.1109/ICICS52457.2021.9464614 is OK
- 10.1057/s41599-021-00798-7 is OK
- 10.14569/IJACSA.2022.0130751 is OK
- 10.14569/ijacsa.2020.0111045 is OK
- 10.1007/978-981-15-0947-6_76 is OK
- 10.1109/fmec.2019.8795331 is OK
- 10.1109/icics52457.2021.9464566 is OK
- 10.1007/978-3-030-36778-7_22 is OK
- 10.1109/ICICS52457.2021.9464531 is OK
- 10.48550/ARXIV.1910.00421 is OK
- 10.18653/v1/2021.eacl-main.204 is OK
- 10.1109/icics52457.2021.9464605 is OK
- 10.18280/ria.340111 is OK
- 10.3390/app12094188 is OK
- 10.11591/ijeecs.v19.i2.pp1010-1020 is OK
- 10.1109/iciev.2019.8858561 is OK
- 10.11591/ijece.v12i4.pp4195-4205 is OK
- 10.1109/icics55353.2022.9811149 is OK
- 10.1016/j.knosys.2022.108180 is OK
- 10.1007/s13369-021-05383-3 is OK
- 10.3390/bdcc6020048 is OK
- 10.1177/14604582211070998 is OK
- 10.18653/v1/N16-3003 is OK

MISSING DOIs

- None

INVALID DOIs

- None
amitkumarj441 commented 1 year ago

I think it's much improved, and I'm happy to sign-off the full review.

@ajstewartlang It needs an update to the reviewer list and regenerate the article proof, then, I think we're good to go here for the next steps of publication.

ajstewartlang commented 1 year ago

@editorialbot remove @VenkteshV from reviewers

editorialbot commented 1 year ago

@VenkteshV removed from the reviewers list!

ajstewartlang commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

ajstewartlang commented 1 year ago

Many thanks for your very helpful reviews @amitkumarj441 and @kikarimullah - and for your great submission @linuxscout. We're almost there...

ajstewartlang commented 1 year ago

:wave: @linuxscout

If you could now do the following please, that would be great:

linuxscout commented 1 year ago

Hi @ajstewartlang, Thank you for your recommendations, I would to know if upload the package into Zenodo as publication or as a software. Thanks

ajstewartlang commented 1 year ago

Hi @ajstewartlang, Thank you for your recommendations, I would to know if upload the package into Zenodo as publication or as a software. Thanks

Hi @linuxscout - it's the tagged release of the reviewed version of the software that you want to archive on Zenodo.

linuxscout commented 1 year ago

The DOI is 10.5281/zenodo.7833909

ajstewartlang commented 1 year ago

@editorialbot set 0.6.16 as version

editorialbot commented 1 year ago

Done! version is now 0.6.16

ajstewartlang commented 1 year ago

@editorialbot set 10.5281/zenodo.7833909 as archive

editorialbot commented 1 year ago

Done! Archive is now 10.5281/zenodo.7833909

ajstewartlang commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago
Attempting dry run of processing paper acceptance...
editorialbot commented 1 year ago

:wave: @openjournals/dsais-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4127, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5121/ijdkp.2016.6602 is OK
- 10.1177/0165551519849516 is OK
- 10.1109/wits.2019.8723864 is OK
- 10.1016/j.procs.2017.10.111 is OK
- 10.1117/12.2242187 is OK
- 10.1109/icics52457.2021.9464602 is OK
- 10.1007/978-3-030-33582-3_1 is OK
- 10.1109/ICICS52457.2021.9464614 is OK
- 10.1057/s41599-021-00798-7 is OK
- 10.14569/IJACSA.2022.0130751 is OK
- 10.14569/ijacsa.2020.0111045 is OK
- 10.1007/978-981-15-0947-6_76 is OK
- 10.1109/fmec.2019.8795331 is OK
- 10.1109/icics52457.2021.9464566 is OK
- 10.1007/978-3-030-36778-7_22 is OK
- 10.1109/ICICS52457.2021.9464531 is OK
- 10.48550/ARXIV.1910.00421 is OK
- 10.18653/v1/2021.eacl-main.204 is OK
- 10.1109/icics52457.2021.9464605 is OK
- 10.18280/ria.340111 is OK
- 10.3390/app12094188 is OK
- 10.11591/ijeecs.v19.i2.pp1010-1020 is OK
- 10.1109/iciev.2019.8858561 is OK
- 10.11591/ijece.v12i4.pp4195-4205 is OK
- 10.1109/icics55353.2022.9811149 is OK
- 10.1016/j.knosys.2022.108180 is OK
- 10.1007/s13369-021-05383-3 is OK
- 10.3390/bdcc6020048 is OK
- 10.1177/14604582211070998 is OK
- 10.18653/v1/N16-3003 is OK

MISSING DOIs

- None

INVALID DOIs

- None
arfon commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 1 year ago

:warning: Couldn't acccept/publish paper. An error happened. Could not deposit with Open Journals.

arfon commented 1 year ago

Looks like there's an issue here. We're debugging the issue.

arfon commented 1 year ago

@linuxscout – could you please merge this PR? https://github.com/linuxscout/pyarabic/pull/71

linuxscout commented 1 year ago

ok

linuxscout commented 1 year ago

done

arfon commented 1 year ago

@editorialbot reaccept

editorialbot commented 1 year ago
Rebuilding paper!
editorialbot commented 1 year ago

🌈 Paper updated!

New PDF and metadata files :point_right: https://github.com/openjournals/joss-papers/pull/4157

arfon commented 1 year ago

@amitkumarj441, @kikarimullah – many thanks for your reviews here and to @ajstewartlang for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@linuxscout – your paper is now accepted and published in JOSS :zap::rocket::boom:

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04886/status.svg)](https://doi.org/10.21105/joss.04886)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04886">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04886/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04886/status.svg
   :target: https://doi.org/10.21105/joss.04886

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

linuxscout commented 1 year ago

Dear Journal of Open Source Software Editorial Team,

I am writing to express my sincere gratitude for accepting my paper, "PyArabic: A Python package for Arabic text," for publication in your esteemed journal. It is an honor to have my work featured in the Journal of Open Source Software, and I am thrilled at the opportunity to share my research with a wider audience.

I would also like to extend my heartfelt thanks to the reviewers who provided invaluable feedback and constructive criticism during the peer-review process. Their insightful comments have helped to strengthen the quality of my work, and I am grateful for their time and effort.

I believe that this publication will contribute to the advancement of the field of computational linguistics, particularly in the area of Arabic text analysis. With the availability of PyArabic, researchers and developers will have access to a powerful and user-friendly Python package that facilitates Arabic text processing and analysis.

Once again, I want to express my appreciation for the acceptance of my paper in the Journal of Open Source Software, and I look forward to continued collaboration with the journal in the future.

Sincerely,