openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[REVIEW]: PyKronecker: A Python Library for the Efficient Manipulation of Kronecker Products and Related Structures #4900

Closed editorialbot closed 1 year ago

editorialbot commented 2 years ago

Submitting author: !--author-handle-->@nickelnine37<!--end-author-handle-- (Edward Antonian) Repository: https://github.com/nickelnine37/pykronecker Branch with paper.md (empty if default branch): Version: 0.1.2 Editor: !--editor-->@Kevin-Mattheus-Moerman<!--end-editor-- Reviewers: @JulianKarlBauer, @nicoguaro Archive: 10.5281/zenodo.7566803

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/0946dc0f465819544e228a6acb96bf24"><img src="https://joss.theoj.org/papers/0946dc0f465819544e228a6acb96bf24/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/0946dc0f465819544e228a6acb96bf24/status.svg)](https://joss.theoj.org/papers/0946dc0f465819544e228a6acb96bf24)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@JulianKarlBauer & @nicoguaro, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @Kevin-Mattheus-Moerman know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

πŸ“ Checklist for @JulianKarlBauer

πŸ“ Checklist for @nicoguaro

editorialbot commented 1 year ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/3922
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.04900
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! πŸŽ‰πŸŒˆπŸ¦„πŸ’ƒπŸ‘»πŸ€˜

Any issues? Notify your editorial technical team...

arfon commented 1 year ago

@JulianKarlBauer, @nicoguaro – many thanks for your reviews here and to @Kevin-Mattheus-Moerman for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@nickelnine37 – your paper is now accepted and published in JOSS :zap::rocket::boom:

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04900/status.svg)](https://doi.org/10.21105/joss.04900)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04900">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04900/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04900/status.svg
   :target: https://doi.org/10.21105/joss.04900

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

nickelnine37 commented 1 year ago

@Kevin-Mattheus-Moerman @danielskatz @nicoguaro @JulianKarlBauer

Thank you so much for giving up your time to review and process this paper. This has been a great experience.