[REVIEW]: Metagenomic classification with KrakenUniq on low-memory computers

editorialbot commented 2 years ago

Submitting author: !--author-handle-->@salzberg@lpantano<!--end-editor-- Reviewers: @Jessime, @MaximLippeveld Archive: 10.5281/zenodo.7459217

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/0558bc421e6167f70639f053a4562d85"><img src="https://joss.theoj.org/papers/0558bc421e6167f70639f053a4562d85/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/0558bc421e6167f70639f053a4562d85/status.svg)](https://joss.theoj.org/papers/0558bc421e6167f70639f053a4562d85)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@Jessime & @MaximLippeveld, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @lpantano know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @MaximLippeveld

📝 Checklist for @Jessime

Kevin-Mattheus-Moerman commented 1 year ago

@alekseyzimin I am the AEiC on this track, and here to help process this work for acceptance in JOSS. I have reviewed the paper and archive and most seems in order, so we can proceed with acceptance. I do have one point below which you should fix at your earliest convenience:

[ ] Please modify the license listed on your ZENODO archive. It currently refers to a creative commons license, but this should be your software license: GPL-3.0 license.

I will now proceed with to acceptance in JOSS.

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 1 year ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

editorialbot commented 1 year ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 1 year ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/3852
Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.04908
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

Kevin-Mattheus-Moerman commented 1 year ago

@salzberg congratulations on this publication!

Thank you for editing this one @lpantano!

And a special thanks to the reviewers: @Jessime, @MaximLippeveld !!!!

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04908/status.svg)](https://doi.org/10.21105/joss.04908)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04908">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04908/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04908/status.svg
   :target: https://doi.org/10.21105/joss.04908

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://joss.theoj.org/reviewer-signup.html
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

salzberg commented 1 year ago

@salzberg congratulations on this publication!

Thank you for editing this one @lpantano!

And a special thanks to the reviewers: @Jessime, @MaximLippeveld !!!!

thanks to everyone who helped with the process and especially the reviewers!

alekseyzimin commented 1 year ago

@alekseyzimin I am the AEiC on this track, and here to help process this work for acceptance in JOSS. I have reviewed the paper and archive and most seems in order, so we can proceed with acceptance. I do have one point below which you should fix at your earliest convenience:

[x] Please modify the license listed on your ZENODO archive. It currently refers to a creative commons license, but this should be your software license: GPL-3.0 license.

I will now proceed with to acceptance in JOSS.

Hello @Kevin-Mattheus-Moerman, I updated the license listed on Zenodo Archive.

openjournals / joss-reviews