[REVIEW]: py-sc-fermi: self-consistent Fermi energies and defect concentrations from electronic structure calculations

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@alexsquires@rkurchin<!--end-editor-- Reviewers: @hongzhouye, @ajgoyal Archive: 10.5281/zenodo.7567782

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/2fa8b3d80281c36371472485adbc83e7"><img src="https://joss.theoj.org/papers/2fa8b3d80281c36371472485adbc83e7/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/2fa8b3d80281c36371472485adbc83e7/status.svg)](https://joss.theoj.org/papers/2fa8b3d80281c36371472485adbc83e7)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@hongzhouye & @agoyal06, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @rkurchin know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @hongzhouye

📝 Checklist for @ajgoyal

rkurchin commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

rkurchin commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago

Attempting dry run of processing paper acceptance...

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1039/d0ee00291g is OK
- 10.1039/b300139n is OK
- 10.1039/D1TA05112A is OK
- 10.1021/acs.chemmater.2c00944 is OK
- 10.1021/acsenergylett.7b01313.s001 is OK
- 10.1149/2.0011514jes is OK
- 10.1021/acs.inorgchem.1c00278 is OK
- 10.1039/d1tc02547c is OK
- 10.1016/j.commatsci.2022.111434 is OK
- 10.1016/j.cpc.2019.06.017 is OK
- 10.1038/s41524-022-00756-0 is OK
- 10.1016/j.cpc.2021.107946 is OK
- 10.1103/PhysRevMaterials.6.085401 is OK
- 10.1021/acsenergylett.2c01961 is OK
- 10.26434/chemrxiv-2021-hzrls is OK
- 10.1039/D1MH01539G is OK
- 10.1038/s41578-022-00433-0 is OK
- 10.1021/acsenergylett.1c00380.s001 is OK
- 10.1038/s41578-018-0026-7 is OK
- 10.1021/acs.chemmater.8b01135.s001 is OK
- 10.1021/acs.chemmater.9b04319 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 1 year ago

:wave: @openjournals/bcm-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3903, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

bjmorgan commented 1 year ago

We have made minor edits to the paper in https://github.com/bjmorgan/py-sc-fermi/commit/b2e420715489deb415800bd4f7a92c8718c66679 and https://github.com/bjmorgan/py-sc-fermi/commit/fadabc716b3ae0a4e05f0c95a8d6ce257689d7dd.

Apart from these we are happy with the final proof.

alexsquires commented 1 year ago

Hi @rkurchin, just wanted to check, is there anything else we need to do now?

Kevin-Mattheus-Moerman commented 1 year ago

@alexsquires no, no steps required on your end. I am the AEiC for this track and here to help process the final steps towards acceptance. I have reviewed the archive link and all seems in order there. I will review the paper shortly and will get back to you then.

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Kevin-Mattheus-Moerman commented 1 year ago

@alexsquires below are some minor points on the paper that require your attention:

[x] In your affiliations, please spell out UK as United Kingdom. Also you may remove the street/postal code parts from the affiliations if you wish.
[x] Fix spelling of quantifiying as quantifying
[x] Fix spelling in concentations as concentrations

alexsquires commented 1 year ago

addressed in f57479f

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 1 year ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

editorialbot commented 1 year ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 1 year ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/3936
Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.04962
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

Kevin-Mattheus-Moerman commented 1 year ago

@alexsquires congratulations on this publication with JOSS!!

Thank you @rkurchin for editing this submission, and a special thanks to the reviewers @hongzhouye and @ajgoyal !!!!

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04962/status.svg)](https://doi.org/10.21105/joss.04962)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04962">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04962/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04962/status.svg
   :target: https://doi.org/10.21105/joss.04962

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews