openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
706 stars 37 forks source link

[REVIEW]: ronswanson: Building Table Models for 3ML #4969

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@grburgess<!--end-author-handle-- (J. Michael Burgess) Repository: https://github.com/grburgess/ronswanson Branch with paper.md (empty if default branch): Version: v0.2.10 Editor: !--editor-->@dfm<!--end-editor-- Reviewers: @cosimoNigro, @volodymyrss Archive: 10.5281/zenodo.7778865

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/b9ab6f687a9f3018b6b08c6575cfc6ee"><img src="https://joss.theoj.org/papers/b9ab6f687a9f3018b6b08c6575cfc6ee/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/b9ab6f687a9f3018b6b08c6575cfc6ee/status.svg)](https://joss.theoj.org/papers/b9ab6f687a9f3018b6b08c6575cfc6ee)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@cosimoNigro & @volodymyrss, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @dfm know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

πŸ“ Checklist for @volodymyrss

πŸ“ Checklist for @cosimoNigro

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/10968987_3 is OK
- 10.5281/zenodo.5646925 is OK
- 10.22323/1.312.0130 is OK
- 10.22323/1.301.0766 is OK
- 10.5281/zenodo.7734804 is OK

MISSING DOIs

- None

INVALID DOIs

- None
dfm commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago
Attempting dry run of processing paper acceptance...
editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/10968987_3 is OK
- 10.5281/zenodo.5646925 is OK
- 10.22323/1.312.0130 is OK
- 10.22323/1.301.0766 is OK
- 10.5281/zenodo.7734804 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 1 year ago

:wave: @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4084, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

dfm commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 1 year ago

🐦🐦🐦 πŸ‘‰ Tweet for this paper πŸ‘ˆ 🐦🐦🐦

editorialbot commented 1 year ago

🐘🐘🐘 πŸ‘‰ Toot for this paper πŸ‘ˆ 🐘🐘🐘

editorialbot commented 1 year ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4085
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.04969
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! πŸŽ‰πŸŒˆπŸ¦„πŸ’ƒπŸ‘»πŸ€˜

Any issues? Notify your editorial technical team...

grburgess commented 1 year ago

Thanks @volodymyrss and @cosimoNigro for a useful and thoughtful review. Thanks for the edits @dfm.

dfm commented 1 year ago

@cosimoNigro, @volodymyrss β€” Many thanks for your reviews here! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!!

@grburgess β€” Your paper is now accepted and published in JOSS! :zap::rocket::boom:

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04969/status.svg)](https://doi.org/10.21105/joss.04969)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04969">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04969/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04969/status.svg
   :target: https://doi.org/10.21105/joss.04969

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

grburgess commented 1 year ago

@editorialbot generate preprint

editorialbot commented 1 year ago

:page_facing_up: Preprint file created: Find it here in the Artifacts list :page_facing_up:

grburgess commented 1 year ago

@dfm does the preprint function still work?

grburgess commented 1 year ago

oops