openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
715 stars 38 forks source link

[REVIEW]: FijiRelax: Fast and noise-corrected estimation of MRI relaxation maps in 3D + t #4981

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@Rocsg<!--end-author-handle-- (Romain Fernandez) Repository: https://github.com/Rocsg/FijiRelax Branch with paper.md (empty if default branch): Version: 4.0.10 Editor: !--editor-->@britta-wstnr<!--end-editor-- Reviewers: @MaximLippeveld, @kasasxav, @hinerm Archive: 10.5281/zenodo.7554691

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/cdbd91c8fed50d89c7afbf83840d07a4"><img src="https://joss.theoj.org/papers/cdbd91c8fed50d89c7afbf83840d07a4/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/cdbd91c8fed50d89c7afbf83840d07a4/status.svg)](https://joss.theoj.org/papers/cdbd91c8fed50d89c7afbf83840d07a4)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@MaximLippeveld & @kasasxav & @hinerm, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @britta-wstnr know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

πŸ“ Checklist for @MaximLippeveld

πŸ“ Checklist for @hinerm

πŸ“ Checklist for @kasasxav

britta-wstnr commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago
Attempting dry run of processing paper acceptance...
editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/j.1365-313x.2012.04927.x is OK
- 10.1002/mrc.4905 is OK
- 10.1186/s13628-014-0015-1 is OK
- 10.1104/pp.15.01388 is OK
- 10.1016/j.neuroimage.2020.116884 is OK
- 10.5281/zenodo.4518730 is OK
- 10.1109/icip.2019.8804298 is OK
- 10.1093/bioinformatics/btaa846 is OK
- 10.1016/0022-2364(76)90133-5 is OK
- 10.21105/joss.02343 is OK
- 10.1002/mrm.22178 is OK
- 10.1016/j.postharvbio.2009.02.004 is OK
- 10.1016/j.jmr.2012.12.019 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 1 year ago

:wave: @openjournals/bcm-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3902, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

arfon commented 1 year ago

@Rocsg – could you please merge this pull request which fixes a couple of issues with your paper? https://github.com/Rocsg/FijiRelax/pull/20

Rocsg commented 1 year ago

@arfon - Done! Thank you for reviewing.

arfon commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago
Attempting dry run of processing paper acceptance...
editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/j.1365-313x.2012.04927.x is OK
- 10.1002/mrc.4905 is OK
- 10.1186/s13628-014-0015-1 is OK
- 10.1104/pp.15.01388 is OK
- 10.1016/j.neuroimage.2020.116884 is OK
- 10.5281/zenodo.4518730 is OK
- 10.1109/icip.2019.8804298 is OK
- 10.1093/bioinformatics/btaa846 is OK
- 10.1016/0022-2364(76)90133-5 is OK
- 10.21105/joss.02343 is OK
- 10.1002/mrm.22178 is OK
- 10.1016/j.postharvbio.2009.02.004 is OK
- 10.1016/j.jmr.2012.12.019 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 1 year ago

:wave: @openjournals/bcm-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3916, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

arfon commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 1 year ago

🐦🐦🐦 πŸ‘‰ Tweet for this paper πŸ‘ˆ 🐦🐦🐦

editorialbot commented 1 year ago

🐘🐘🐘 πŸ‘‰ Toot for this paper πŸ‘ˆ 🐘🐘🐘

editorialbot commented 1 year ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/3917
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.04981
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! πŸŽ‰πŸŒˆπŸ¦„πŸ’ƒπŸ‘»πŸ€˜

Any issues? Notify your editorial technical team...

arfon commented 1 year ago

@MaximLippeveld, @kasasxav, @hinerm – many thanks for your reviews here and to @britta-wstnr for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@Rocsg – your paper is now accepted and published in JOSS :zap::rocket::boom:

arfon commented 1 year ago

Looks like there's a minor issue with the GitHub Pages build (which serves the PDF from the JOSS site). We'll keep this review issue open until the Pages issue is resolved.

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04981/status.svg)](https://doi.org/10.21105/joss.04981)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04981">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04981/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04981/status.svg
   :target: https://doi.org/10.21105/joss.04981

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

britta-wstnr commented 1 year ago

Congratulations @Rocsg et al.! πŸŽ‰ 🌟 Many thanks for reviewing @hinerm @kasasxav and @MaximLippeveld! πŸ™ And thanks @arfon!

Rocsg commented 1 year ago

Great @britta-wstnr ! I'll probably make a little #tweeprint soon about FijiRelax. I've seen you have accounts, and JOSS too, thus I'll keep you in touch about it. Additionaly, I engaged myself in the reviewer list.

Have a nice week!

Romain