openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[PRE REVIEW]: Biosiglive: an Open Source Python Package for Real-time Biosignal Processing. #4990

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@aceglia<!--end-author-handle-- (Amedeo Ceglia) Repository: https://github.com/pyomeca/biosiglive Branch with paper.md (empty if default branch): Version: v2.0.0 Editor: !--editor-->@Kevin-Mattheus-Moerman<!--end-editor-- Reviewers: @finsberg, @marcoghislieri Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/e922a6e12b545789fca5d89648e9f1f5"><img src="https://joss.theoj.org/papers/e922a6e12b545789fca5d89648e9f1f5/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/e922a6e12b545789fca5d89648e9f1f5/status.svg)](https://joss.theoj.org/papers/e922a6e12b545789fca5d89648e9f1f5)

Author instructions

Thanks for submitting your paper to JOSS @aceglia. Currently, there isn't a JOSS editor assigned to your paper.

@aceglia if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.23 s (229.2 files/s, 272850.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
XML                             16              0              0          57346
Python                          34            458           1379           3557
Markdown                         2             47              0            242
TeX                              1              6              0             65
-------------------------------------------------------------------------------
SUM:                            53            511           1379          61210
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 959

editorialbot commented 1 year ago

:warning: An error happened when generating the pdf.

aceglia commented 1 year ago

Suggested reviewers : from the list: marcoghislieri, melund outside the list: modenaxe (Luca Modenese)

arfon commented 1 year ago

@aceglia – this PR should fix your paper compilation: https://github.com/pyomeca/biosiglive/pull/3

aceglia commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

aceglia commented 1 year ago

@arfon Thanks for the PR I included the modifications in another opened PR. The compilation works well.

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot invite @danasolav as editor

Dana do you think you can handle this one? I see you are handling several others already, if you are too busy let me know then I'll take it myself. Thanks

editorialbot commented 1 year ago

Invitation to edit this submission sent!

Kevin-Mattheus-Moerman commented 1 year ago

@aceglia thanks for this submission. A quick comment, check your title, perhaps (correct me if I'm wrong) it should be written:

Biosiglive: an Open Source Python Package for Real-Rime Biosignal Processing.

i.e. I removed the plural on sources and biosignals, and I added capital letters throughout (as it previously was only used for Open Source, alternatively remove the other capital letters too).

aceglia commented 1 year ago

@Kevin-Mattheus-Moerman You are completely right, the title should be : Biosiglive: an Open-Source Python Package for Real-Time Biosignal Processing What can I do to address this? Thanks!

Kevin-Mattheus-Moerman commented 1 year ago

@aceglia I have changed the title of this issue just now. Next can you please do the following:

I think it should probably be Real-time rather than Real-Time.

Thanks

aceglia commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

aceglia commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

aceglia commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

aceglia commented 1 year ago

@Kevin-Mattheus-Moerman Done. Thanks!

danasolav commented 1 year ago

@Kevin-Mattheus-Moerman Sorry, I'm too busy to take another one at the moment.

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot assign me as editor

editorialbot commented 1 year ago

Assigned! @Kevin-Mattheus-Moerman is now the editor

Kevin-Mattheus-Moerman commented 1 year ago

@alcantarar @romainmartinez @felixchenier @trallard @abhishektha @melund @modenaxe @BKillen05 @finsberg @bzenger would you be interested in reviewing this submission Biosiglive: an Open Source Python Package for Real-time Biosignal Processing for JOSS (the Journal of Open Source Software)?

JOSS reviews focus on the evaluation of the software and the review of a short paper.

This is a pre-review issue where reviewers are assigned. Once we have sufficient reviewers we will open a review issue, so the review will take place on GitHub. Here is an example of a complete review if you are curious as to what the process is like: https://github.com/openjournals/joss-reviews/issues/4859 As you can see, a checklist guides each reviewer through the process.

Let me know if you can help or if you have any more questions. Note we can be quite flexible regarding the time needed to complete the review. Thanks!

felixchenier commented 1 year ago

Good morning @Kevin-Mattheus-Moerman Thanks for contacting me. I'm currently on a sabbatical leave, and I do not use Vicon Nexus or Delsys Trigno in my lab, so I couldn't do this review unfortunately. Regards, Félix.

melund commented 1 year ago

Thanks for inviting me to review this @Kevin-Mattheus-Moerman. I read the article proof, but the topic a little outside my current interest, and simply too busy at the moment. So I will have to pass on this. Sorry.

Kevin-Mattheus-Moerman commented 1 year ago

@alcantarar @romainmartinez @trallard @abhishektha @modenaxe @BKillen05 @marcoghislieri @bzenger would you be interested in reviewing this submission Biosiglive: an Open Source Python Package for Real-time Biosignal Processing for JOSS (the Journal of Open Source Software)?

JOSS reviews focus on the evaluation of the software and the review of a short paper.

This is a pre-review issue where reviewers are assigned. Once we have sufficient reviewers we will open a review issue, so the review will take place on GitHub. Here is an example of a complete review if you are curious as to what the process is like: https://github.com/openjournals/joss-reviews/issues/4859 As you can see, a checklist guides each reviewer through the process.

Let me know if you can help or if you have any more questions. Note we can be quite flexible regarding the time needed to complete the review. Thanks!

finsberg commented 1 year ago

I will be happy to review this.

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot add @finsberg as reviewer

editorialbot commented 1 year ago

@finsberg added to the reviewers list!

marcoghislieri commented 1 year ago

Dear @Kevin-Mattheus-Moerman, Thanks for inviting me to review this submission. Sure, I'm interested and available to review Biosiglive: an Open Source Python Package for Real-time Biosignal Processing All the best

romainmartinez commented 1 year ago

Thank you for considering me as a reviewer. Unfortunately, at this time I am unable to commit to reviewing the paper due to my current workload and personal circumstances. I apologize for any inconvenience this may cause and wish the paper and its authors the best of luck in their research!

alcantarar commented 1 year ago

Thanks for your consideration, but I’m unavailable for reviews.

R

On Sat, Jan 21, 2023 at 12:56 PM Romain Martinez @.***> wrote:

Thank you for considering me as a reviewer. Unfortunately, at this time I am unable to commit to reviewing the paper due to my current workload and personal circumstances. I apologize for any inconvenience this may cause and wish the paper and its authors the best of luck in their research!

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/4990#issuecomment-1399330966, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJDMLEOACLP7DNVG6G4ZMKDWTREODANCNFSM6AAAAAASSVXCRY . You are receiving this because you were mentioned.Message ID: @.***>

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot add @marcoghislieri as reviewer

editorialbot commented 1 year ago

@marcoghislieri added to the reviewers list!

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot start review

editorialbot commented 1 year ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/5091.