[REVIEW]: RelativisticDynamics.jl: Relativistic Spin-Orbital 1 Dynamics in Julia

[editorialbot]

Submitting author: !--author-handle-->@tomkimpson<!--end-author-handle-- (Tom Kimpson) Repository: https://github.com/tomkimpson/RelativisticDynamics.jl Branch with paper.md (empty if default branch): Version: v0.1.2 Editor: !--editor-->@dfm<!--end-editor-- Reviewers: @langfzac, @tamasgal Archive: 10.5281/zenodo.8412240

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/48d52c30fe45aea8ea04da814301448a"><img src="https://joss.theoj.org/papers/48d52c30fe45aea8ea04da814301448a/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/48d52c30fe45aea8ea04da814301448a/status.svg)](https://joss.theoj.org/papers/48d52c30fe45aea8ea04da814301448a)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@farr & @duetosymmetry, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @dfm know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @langfzac

📝 Checklist for @tamasgal

[tomkimpson]

Thanks @dfm - I have merged your PR. To your other points:

1. I am happy with the manuscript
2. The version number is v0.1.2
3. An archived release has been created on Zenodo, doi:10.5281/zenodo.8412240

[dfm]

Thanks! (As I mentioned above ☝️) Can you update the Zenodo metadata (title and authors) to exactly match the JOSS paper? You should have an "Edit" button at the top right of the record page if you're logged in.

[dfm]

@editorialbot set v0.1.2 as version

[editorialbot]

Done! version is now v0.1.2

[dfm]

@editorialbot set 10.5281/zenodo.8412240 as archive

[editorialbot]

Done! archive is now 10.5281/zenodo.8412240

[dfm]

@editorialbot generate pdf

[dfm]

@editorialbot check references

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/s10714-010-0939-y is OK
- 10.1098/rspa.1951.0200 is OK
- 10.1007/BF02734579 is OK
- 10.1093/mnras/stz389 is OK
- 10.1093/mnras/staa2103 is OK
- 10.1093/mnras/stz845 is OK
- 10.1051/0004-6361/202038561 is OK
- 10.1175/MWR-D-16-0228.1 is OK
- 10.48550/arXiv.2203.11952 is OK
- 10.21105/joss.03703 is OK
- 10.1103/PhysRevD.45.1840 is OK

MISSING DOIs

- None

INVALID DOIs

- None

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[tomkimpson]

Thanks! (As I mentioned above ☝️) Can you update the Zenodo metadata (title and authors) to exactly match the JOSS paper? You should have an "Edit" button at the top right of the record page if you're logged in.

@dfm This is now done 👍

[dfm]

@editorialbot recommend-accept

[editorialbot]

Attempting dry run of processing paper acceptance...

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/s10714-010-0939-y is OK
- 10.1098/rspa.1951.0200 is OK
- 10.1007/BF02734579 is OK
- 10.1093/mnras/stz389 is OK
- 10.1093/mnras/staa2103 is OK
- 10.1093/mnras/stz845 is OK
- 10.1051/0004-6361/202038561 is OK
- 10.1175/MWR-D-16-0228.1 is OK
- 10.48550/arXiv.2203.11952 is OK
- 10.21105/joss.03703 is OK
- 10.1103/PhysRevD.45.1840 is OK

MISSING DOIs

- None

INVALID DOIs

- None

[editorialbot]

:warning: Error preparing paper acceptance. The generated XML metadata file is invalid.

ID figU003Aexample already defined

[dfm]

@editorialbot recommend-accept

[editorialbot]

Attempting dry run of processing paper acceptance...

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/s10714-010-0939-y is OK
- 10.1098/rspa.1951.0200 is OK
- 10.1007/BF02734579 is OK
- 10.1093/mnras/stz389 is OK
- 10.1093/mnras/staa2103 is OK
- 10.1093/mnras/stz845 is OK
- 10.1051/0004-6361/202038561 is OK
- 10.1175/MWR-D-16-0228.1 is OK
- 10.48550/arXiv.2203.11952 is OK
- 10.21105/joss.03703 is OK
- 10.1103/PhysRevD.45.1840 is OK

MISSING DOIs

- None

INVALID DOIs

- None

[editorialbot]

:wave: @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4675, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

[dfm]

@editorialbot accept

[editorialbot]

Doing it live! Attempting automated processing of paper acceptance...

[editorialbot]

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Kimpson given-names: Tom doi: 10.5281/zenodo.8412240 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Kimpson given-names: Tom date-published: 2023-10-10 doi: 10.21105/joss.04992 issn: 2475-9066 issue: 90 journal: Journal of Open Source Software publisher: name: Open Journals start: 4992 title: "RelativisticDynamics.jl: Relativistic Spin-Orbital Dynamics in Julia" type: article url: "https://joss.theoj.org/papers/10.21105/joss.04992" volume: 8 title: "RelativisticDynamics.jl: Relativistic Spin-Orbital Dynamics in Julia" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

[editorialbot]

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

[editorialbot]

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

0. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4677
1. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.04992
2. If everything looks good, then close this review issue.
3. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

[dfm]

@langfzac, @tamasgal — Many thanks for your reviews here! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!!

@tomkimpson — Your paper is now accepted and published in JOSS! :zap::rocket::boom:

Note: The PDF doesn't seem to be rendering properly on the publication page. Don't worry, this happens frequently and it's caused by a caching issue when the DOI link is clicked on too soon. It should be fixed within a few hours, but we can check back later to make sure!

[editorialbot]

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04992/status.svg)](https://doi.org/10.21105/joss.04992)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04992">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04992/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04992/status.svg
   :target: https://doi.org/10.21105/joss.04992

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

• Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
• Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

[tamasgal]

My sincere congratulations on your paper and Julia package, nice work!

[tomkimpson]

Thanks @dfm @tamasgal @langfzac ! Really appreciate your time and feedback.

[tomkimpson]

@editorialbot generate preprint

[editorialbot]

:page_facing_up: Preprint file created: Find it here in the Artifacts list :page_facing_up: