search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[REVIEW]: GNS: A generalizable Graph Neural Network-based simulator for particulate and fluid modeling #5025

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@kks32<!--end-author-handle-- (Krishna Kumar) Repository: https://github.com/geoelements/gns Branch with paper.md (empty if default branch): Version: v1.1.1 Editor: !--editor-->@osorensen<!--end-editor-- Reviewers: @WPettersson, @archermarx Archive: 10.5281/zenodo.8249813

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/d5d6ee3247e52ec932107d87ab7a9549"><img src="https://joss.theoj.org/papers/d5d6ee3247e52ec932107d87ab7a9549/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/d5d6ee3247e52ec932107d87ab7a9549/status.svg)](https://joss.theoj.org/papers/d5d6ee3247e52ec932107d87ab7a9549)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@WPettersson & @archermarx, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @osorensen know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @WPettersson

📝 Checklist for @archermarx

editorialbot commented 1 year ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.6658322 is OK
- 10.1016/j.cma.2022.115704 is OK
- 10.17603/ds2-0phb-dg64 is OK
- 10.1680/jgeot.15.LM.005 is OK
- 10.1145/3197517.3201293 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 1 year ago

:wave: @openjournals/dsais-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4493, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

gkthiruvathukal commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago 
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 1 year ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Kumar given-names: Krishna orcid: "https://orcid.org/0000-0003-2144-5562" - family-names: Vantassel given-names: Joseph orcid: "https://orcid.org/0000-0002-1601-3354" doi: 10.5281/zenodo.8249813 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Kumar given-names: Krishna orcid: "https://orcid.org/0000-0003-2144-5562" - family-names: Vantassel given-names: Joseph orcid: "https://orcid.org/0000-0002-1601-3354" date-published: 2023-08-25 doi: 10.21105/joss.05025 issn: 2475-9066 issue: 88 journal: Journal of Open Source Software publisher: name: Open Journals start: 5025 title: "GNS: A generalizable Graph Neural Network-based simulator for particulate and fluid modeling" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05025" volume: 8 title: "GNS: A generalizable Graph Neural Network-based simulator for particulate and fluid modeling" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 1 year ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 1 year ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4511
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05025
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...