openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[REVIEW]: mlpack 4: a fast, header-only C++ machine learning library #5026

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@rcurtin<!--end-author-handle-- (Ryan Curtin) Repository: https://github.com/mlpack/mlpack Branch with paper.md (empty if default branch): mlpack4_joss Version: 4.0.1 Editor: !--editor-->@osorensen<!--end-editor-- Reviewers: @sandeep-ps, @zhangjy-ge Archive: 10.5281/zenodo.7587252

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/35ade482a14780ee52bad48fcc5f2be5"><img src="https://joss.theoj.org/papers/35ade482a14780ee52bad48fcc5f2be5/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/35ade482a14780ee52bad48fcc5f2be5/status.svg)](https://joss.theoj.org/papers/35ade482a14780ee52bad48fcc5f2be5)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@sandeep-ps & @zhangjy-ge, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @osorensen know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

πŸ“ Checklist for @sandeep-ps

πŸ“ Checklist for @zhangjy-ge

editorialbot commented 1 year ago

:wave: @openjournals/dsais-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3923, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.21105/joss.00726 may be a valid DOI for title: mlpack 3: a fast, flexible machine learning library
- 10.1126/science.aaa8415 may be a valid DOI for title: Machine learning: Trends, perspectives, and prospects
- 10.1145/3219819.3220124 may be a valid DOI for title: Training big random forests with little resources
- 10.1145/3533378 may be a valid DOI for title: Challenges in deploying machine learning: a survey of case studies
- 10.21203/rs.3.rs-133138/v1 may be a valid DOI for title: Technology readiness levels for machine learning systems
- 10.3390/make3010004 may be a valid DOI for title: AI System Engineeringβ€”Key Challenges and Lessons Learned
- 10.1007/978-3-319-46759-7_17 may be a valid DOI for title: Fast approximate furthest neighbors with data-dependent candidate selection
- 10.1002/sam.11218 may be a valid DOI for title: Dual-tree fast exact max-kernel search
- 10.21105/joss.00026 may be a valid DOI for title: Armadillo: a template-based C++ library for linear algebra
- 10.1137/141000671 may be a valid DOI for title: Julia: A fresh approach to numerical computing
- 10.1109/tbdata.2019.2921572 may be a valid DOI for title: Billion-scale similarity search with GPUs
- 10.5220/0001787803310340 may be a valid DOI for title: Fast approximate nearest neighbors with automatic algorithm configuration

INVALID DOIs

- None
osorensen commented 1 year ago

Sorry @rcurtin, I forgot to check the references. Could you please add the suggested DOIs above to your .bib file?

rcurtin commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

rcurtin commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.00726 is OK
- 10.1126/science.aaa8415 is OK
- 10.1103/RevModPhys.91.045002 is OK
- 10.1145/3219819.3220124 is OK
- 10.1145/3533378 is OK
- 10.21203/rs.3.rs-133138/v1 is OK
- 10.3390/make3010004 is OK
- 10.1007/978-3-319-46759-7_17 is OK
- 10.1137/1.9781611974973.34 is OK
- 10.1002/sam.11218 is OK
- 10.21105/joss.00026 is OK
- 10.3233/978-1-61499-649-1-87 is OK
- 10.1137/141000671 is OK
- 10.1109/tbdata.2019.2921572 is OK
- 10.5220/0001787803310340 is OK

MISSING DOIs

- None

INVALID DOIs

- None
rcurtin commented 1 year ago

Ok @osorensen, I think I've got everything worked out. Let me know if there's anything else to do. Thanks! :+1:

osorensen commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago
Attempting dry run of processing paper acceptance...
editorialbot commented 1 year ago

:wave: @openjournals/dsais-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/3929, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.00726 is OK
- 10.1126/science.aaa8415 is OK
- 10.1103/RevModPhys.91.045002 is OK
- 10.1145/3219819.3220124 is OK
- 10.1145/3533378 is OK
- 10.21203/rs.3.rs-133138/v1 is OK
- 10.3390/make3010004 is OK
- 10.1007/978-3-319-46759-7_17 is OK
- 10.1137/1.9781611974973.34 is OK
- 10.1002/sam.11218 is OK
- 10.21105/joss.00026 is OK
- 10.3233/978-1-61499-649-1-87 is OK
- 10.1137/141000671 is OK
- 10.1109/tbdata.2019.2921572 is OK
- 10.5220/0001787803310340 is OK

MISSING DOIs

- None

INVALID DOIs

- None
arfon commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 1 year ago

🐦🐦🐦 πŸ‘‰ Tweet for this paper πŸ‘ˆ 🐦🐦🐦

editorialbot commented 1 year ago

🐘🐘🐘 πŸ‘‰ Toot for this paper πŸ‘ˆ 🐘🐘🐘

editorialbot commented 1 year ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/3931
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05026
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! πŸŽ‰πŸŒˆπŸ¦„πŸ’ƒπŸ‘»πŸ€˜

Any issues? Notify your editorial technical team...

arfon commented 1 year ago

@sandeep-ps, @zhangjy-ge – many thanks for your reviews here and to @osorensen for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@rcurtin – your paper is now accepted and published in JOSS :zap::rocket::boom:

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05026/status.svg)](https://doi.org/10.21105/joss.05026)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05026">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05026/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05026/status.svg
   :target: https://doi.org/10.21105/joss.05026

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

rcurtin commented 1 year ago

Thanks everyone!