Closed editorialbot closed 1 year ago
If JOSS is very strict on the definition of the term ‘contributors' (= everyone who ever created a commit to the project) then yes. Otherwise, my contribution was so minor and in an early stage of the software that I would not mind not being mentioned :-)
On 12 Jan 2023, at 14:12, Daniel S. Katz @.***> wrote:
👋 @mmoelle1https://urldefense.com/v3/__https://github.com/mmoelle1__;!!PAKc-5URQlI!98G1i1s5Poknv_tnSFC5MPwEf2TH2LVnhd7uhL1ThOvH3FTGRAqnhBjEidechqpsjBNGFo93NW-mrAMrsyDzSpqDCWs$ - I see a bunch of contributions from you: https://github.com/stillwater-sc/universal/commits/main?author=mmoelle1https://urldefense.com/v3/__https://github.com/stillwater-sc/universal/commits/main?author=mmoelle1__;!!PAKc-5URQlI!98G1i1s5Poknv_tnSFC5MPwEf2TH2LVnhd7uhL1ThOvH3FTGRAqnhBjEidechqpsjBNGFo93NW-mrAMrsyDzwva2sns$ mostly in 2018 and then a couple of minor bug fixes in 2021 and 2022.
You don't consider yourself a contributor to the software or someone who should be listed as an author of it? I'm asking in part because of the COI issue but also because this is one of the review criteria - see https://joss.readthedocs.io/en/latest/review_checklist.html#general-checkshttps://urldefense.com/v3/__https://joss.readthedocs.io/en/latest/review_checklist.html*general-checks__;Iw!!PAKc-5URQlI!98G1i1s5Poknv_tnSFC5MPwEf2TH2LVnhd7uhL1ThOvH3FTGRAqnhBjEidechqpsjBNGFo93NW-mrAMrsyDzAI_SbEE$
— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/openjournals/joss-reviews/issues/5058*issuecomment-1380332244__;Iw!!PAKc-5URQlI!98G1i1s5Poknv_tnSFC5MPwEf2TH2LVnhd7uhL1ThOvH3FTGRAqnhBjEidechqpsjBNGFo93NW-mrAMrsyDzBDzTtug$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AAPGPIZZRMXWJXTO7HIO4BLWR77LNANCNFSM6AAAAAATV7J6JI__;!!PAKc-5URQlI!98G1i1s5Poknv_tnSFC5MPwEf2TH2LVnhd7uhL1ThOvH3FTGRAqnhBjEidechqpsjBNGFo93NW-mrAMrsyDz86eqnyQ$. You are receiving this because you were mentioned.Message ID: @.***>
👋 - thanks @mmoelle1. That sounds fine to me, and it's recorded here so its transparent. Let's start the review.
@editorialbot start review
OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/5072.
Submitting author: !--author-handle-->@Ravenwater<!--end-author-handle-- (E. Theodore L. Omtzigt) Repository: https://github.com/stillwater-sc/universal Branch with paper.md (empty if default branch): Version: v3.66.1 Editor: !--editor-->@danielskatz<!--end-editor-- Reviewers: @mmoelle1, @mlxd Managing EiC: Daniel S. Katz
Status
Status badge code:
Author instructions
Thanks for submitting your paper to JOSS @Ravenwater. Currently, there isn't a JOSS editor assigned to your paper.
@Ravenwater if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).
Editor instructions
The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type: