search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
722 stars 38 forks source link

[REVIEW]: TopoPyScale: A Python Package for Hillslope Climate Downscaling #5059

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@arcticsnow<!--end-author-handle-- (Simon Filhol) Repository: https://github.com/ArcticSnow/TopoPyScale Branch with paper.md (empty if default branch): Version: v0.2.3 Editor: !--editor-->@hugoledoux<!--end-editor-- Reviewers: @dvalters, @arbennett Archive: 10.5281/zenodo.8043606

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/91621581b2d0c097495fdd1e58179e87"><img src="https://joss.theoj.org/papers/91621581b2d0c097495fdd1e58179e87/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/91621581b2d0c097495fdd1e58179e87/status.svg)](https://joss.theoj.org/papers/91621581b2d0c097495fdd1e58179e87)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@dvalters & @arbennett, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @hugoledoux know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @dvalters

📝 Checklist for @arbennett

kthyng commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kthyng commented 1 year ago

The paper looks good except for capitalization in the references. You can preserve capitalization by placing {} around characters/words in your .bib file. For example, Kronenberg et al seems to have a proper noun in the title that is not capitalized.

ArcticSnow commented 1 year ago

@kthyng , Sorry for this typo. I was not aware of it. It should be corrected throughout the whole .bib file with the latest commit. Thanks

ArcticSnow commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kthyng commented 1 year ago

Ok great looks ready to go!

kthyng commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago 
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 1 year ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Filhol given-names: Simon orcid: "https://orcid.org/0000-0003-1282-7307" - family-names: Fiddes given-names: Joel orcid: "https://orcid.org/0000-0003-2870-6972" - family-names: Aalstad given-names: Kristoffer orcid: "https://orcid.org/0000-0002-2475-3731" contact: - family-names: Filhol given-names: Simon orcid: "https://orcid.org/0000-0003-1282-7307" doi: 10.5281/zenodo.8043606 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Filhol given-names: Simon orcid: "https://orcid.org/0000-0003-1282-7307" - family-names: Fiddes given-names: Joel orcid: "https://orcid.org/0000-0003-2870-6972" - family-names: Aalstad given-names: Kristoffer orcid: "https://orcid.org/0000-0002-2475-3731" date-published: 2023-06-23 doi: 10.21105/joss.05059 issn: 2475-9066 issue: 86 journal: Journal of Open Source Software publisher: name: Open Journals start: 5059 title: "TopoPyScale: A Python Package for Hillslope Climate Downscaling" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05059" volume: 8 title: "TopoPyScale: A Python Package for Hillslope Climate Downscaling" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 1 year ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

editorialbot commented 1 year ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 1 year ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4341
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05059
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

kthyng commented 1 year ago

Congrats on your new publication @ArcticSnow! Many thanks to editor @hugoledoux and reviewers @dvalters and @arbennett for your time, hard work, and expertise!!

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05059/status.svg)](https://doi.org/10.21105/joss.05059)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05059">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05059/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05059/status.svg
   :target: https://doi.org/10.21105/joss.05059

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

kthyng commented 1 year ago

@ArcticSnow If you're willing, we'd love to have you join our ranks of reviewers! You can sign up here: https://reviewers.joss.theoj.org/join

ArcticSnow commented 1 year ago

Thank you @kthyng for finalizing the publication of the manuscript.

Thank you also to @hugoledoux , @arbennett and @dvalters for a constructive reviewing process. I enjoyed the emphasis on publishing a user-focused paper/software package. It forced us to put in place a consistent platform for using and developing this package

I will gladly take part to the JOSS adventure and will sign up for joining as a reviewer.

Thank you from me and my co-authors!