openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: spgrep: On-the-fly generator of space-group irreducible representations #5064

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@lan496<!--end-author-handle-- (Kohei Shinohara) Repository: https://github.com/spglib/spgrep Branch with paper.md (empty if default branch): Version: v0.3.2 Editor: !--editor-->@drvinceknight<!--end-editor-- Reviewers: @ml-evs, @mdavezac, @PKKeerati Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9a9b64fd8961e7d09f21fc85a6a4fb4e"><img src="https://joss.theoj.org/papers/9a9b64fd8961e7d09f21fc85a6a4fb4e/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9a9b64fd8961e7d09f21fc85a6a4fb4e/status.svg)](https://joss.theoj.org/papers/9a9b64fd8961e7d09f21fc85a6a4fb4e)

Author instructions

Thanks for submitting your paper to JOSS @lan496. Currently, there isn't a JOSS editor assigned to your paper.

@lan496 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.08 s (903.8 files/s, 116762.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          26            684           1048           3490
Markdown                        30            318              0           1492
TeX                              2              0             37            478
Jupyter Notebook                 3              0            801            264
YAML                             5             30             15            216
TOML                             1              4              1             30
SVG                              1              0              0              4
reStructuredText                 1              0              0              2
-------------------------------------------------------------------------------
SUM:                            69           1036           1902           5976
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 740

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-642-80021-4 is OK
- 10.1017/CBO9780511755736 is OK
- 10.1107/S0567739473001129 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.48550/ARXIV.1808.01590 is OK
- 10.48550/ARXIV.2211.15008 is OK
- 10.1142/0751 is OK
- 10.1107/97809553602060000114 is OK
- 10.1016/j.cpc.2021.108226 is OK
- 10.1016/j.cpc.2021.107948 is OK
- 10.1016/j.cpc.2020.107760 is OK
- 10.1016/j.cpc.2021.107993 is OK
- 10.1107/S0108767313007538 is OK
- 10.1107/S1600576717011712 is OK
- 10.1107/S0108767305040286 is OK
- 10.1103/PhysRevB.43.11010 is OK

MISSING DOIs

- None

INVALID DOIs

- doi:10.1524/zkri.2006.221.1.15 is INVALID (failed connection)
editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

danielskatz commented 1 year ago

šŸ‘‹ @lan496 - thanks for your submission. The next step is for me to find an editor, which I will now work on.

danielskatz commented 1 year ago

šŸ‘‹ @drvinceknight - Would you be able to edit this JOSS submission?

danielskatz commented 1 year ago

@editorialbot invite @drvinceknight as editor

editorialbot commented 1 year ago

Invitation to edit this submission sent!

lan496 commented 1 year ago

@danielskatz Thank you for starting the pre-review process. This package is a bit interdisciplinary: the implementation is related to (elemental) computational group theory or representation theory (Track 7 CSISM), but the main application is for condensed matter physics and materials science (Track 2 BCM). I am not sure which tracks are appropriate.

Here are potential reviewers from the list (specialized in computational physics, materials science, or crystallography): bjmorgan jarvist mkhorton mdavezac ml-evs hungpham2017

drvinceknight commented 1 year ago

@editorialbot assign me as editor

editorialbot commented 1 year ago

Assigned! @drvinceknight is now the editor

drvinceknight commented 1 year ago

@bjmorgan @jarvist @mkhortonI am pinging you to ask if you would be able to assist with reviewing this submissions to JOSS (The Journal of Open Source Software).

JOSS publishes articles about open source research software. The submission I'd like you to review is titled: ā€œspgrep: On-the-fly generator of space-group irreducible representationsā€. You can find more information at the top of this Github issue.

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

jarvist commented 1 year ago

As an Editor for JOSS, I don't generally review right now.

My PhD student Keerati Keeratikarn @PKKeerati might be a suitable reviewer though.

On Mon, 6 Mar 2023 at 10:08, Vince Knight @.***> wrote:

@bjmorgan @jarvist @mkhortonI am pinging you to ask if you would be able to assist with reviewing this submissions to JOSS (The Journal of Open Source Software).

JOSS publishes articles about open source research software. The submission I'd like you to review is titled: ā€œspgrep: On-the-fly generator of space-group irreducible representationsā€. You can find more information at the top of this Github issue.

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

ā€” Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

drvinceknight commented 1 year ago

@PKKeerati @mdavezac @ml-evs @hungpham2017 I am pinging you to ask if you would be able to assist with reviewing this submissions to JOSS (The Journal of Open Source Software).

JOSS publishes articles about open source research software. The submission I'd like you to review is titled: ā€œspgrep: On-the-fly generator of space-group irreducible representationsā€. You can find more information at the top of this Github issue.

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

ml-evs commented 1 year ago

I have another review ongoing but I think I am a suitable reviewer for this and can take it on.

mdavezac commented 1 year ago

I can also take on this review, though I won't be able to get it for another week.

PKKeerati commented 1 year ago

I am happy to review but this is my first time of reviewing. So it might take time for me.

drvinceknight commented 1 year ago

Thank you @ml-evs, @mdavezac and @PKKeerati. I will add you all as reviewers.

drvinceknight commented 1 year ago

@editorialbot add @ml-evs as reviewer

editorialbot commented 1 year ago

@ml-evs added to the reviewers list!

drvinceknight commented 1 year ago

@editorialbot add @mdavezac as reviewer

editorialbot commented 1 year ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

drvinceknight commented 1 year ago

@editorialbot add @mdavezac as reviewer

editorialbot commented 1 year ago

@mdavezac added to the reviewers list!

drvinceknight commented 1 year ago

@editorialbot add @PKKeerati as reviewer

editorialbot commented 1 year ago

@PKKeerati added to the reviewers list!

drvinceknight commented 1 year ago

@editorialbot start review

editorialbot commented 1 year ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/5269.