openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: DFM Generator v2.1: a new method for simulating the growth of natural fracture networks #5066

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@JointFlow<!--end-author-handle-- (Michael Welch) Repository: https://github.com/JointFlow/DFMGenerator Branch with paper.md (empty if default branch): Version: v2.1.1 Editor: Pending Reviewers: Pending Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/3f6a0e0181e6408ccd59c86ec8b20fca"><img src="https://joss.theoj.org/papers/3f6a0e0181e6408ccd59c86ec8b20fca/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/3f6a0e0181e6408ccd59c86ec8b20fca/status.svg)](https://joss.theoj.org/papers/3f6a0e0181e6408ccd59c86ec8b20fca)

Author instructions

Thanks for submitting your paper to JOSS @JointFlow. Currently, there isn't a JOSS editor assigned to your paper.

@JointFlow if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago

:warning: An error happened when generating the pdf.

editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=1.64 s (29.3 files/s, 121628.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                             1            632           4232         153486
C#                              29           2966          11867          24201
XML                             11             22             96            761
MSBuild script                   3              0             23            349
Markdown                         2             70              0            137
TeX                              1              6              0             57
YAML                             1              1              4             18
-------------------------------------------------------------------------------
SUM:                            48           3697          16222         179009
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1029/jb089ib06p04077 is OK
- 10.1088/0959-5309/58/6/312 is OK
- 10.1016/0020-7225(65)90028-5 is OK
- 10.1029/jb089ib06p04137 is OK
- 10.1144/petgeo2018-161 is OK
- 10.1007/978-3-030-52414-2 is OK

MISSING DOIs

- None

INVALID DOIs

- 0.1098/rsta.1921.0006 is INVALID
editorialbot commented 1 year ago

Wordcount for paper.md is 937

kthyng commented 1 year ago

@JointFlow in the paper error I see:

Author (Mikael Luthje) is missing affiliation

kthyng commented 1 year ago

@JointFlow Thanks for your submission. Unfortunately our editors with relevant expertise are occupied at the moment so I will add this to the waitlist. Thanks for your patience.

JointFlow commented 1 year ago

@JointFlow in the paper error I see:

Author (Mikael Luthje) is missing affiliation

Hi, Mikael has joint affiliation, to Danish Offshore Technology Centre, Danish Technical University, Kgs. Lyngby, 2800, Denmark (1) and to Gas Storage Denmark A/S, Merloesevej 1B, 4296 Nyrup, Denmark (2). As far as I can see, both of these are listed in the paper - is there anywhere else they need to be listed?

Best regards, Michael

kthyng commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:warning: An error happened when generating the pdf.

kthyng commented 1 year ago

@JointFlow I suspect it is your typo "affilitation"

JointFlow commented 1 year ago

Hi, Thanks for your help, I have now corrected the file and regenerated the pdf.

Best regards, Michael

kthyng commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kthyng commented 1 year ago

@JointFlow Thank you for your patience. We have two new editors coming on next week so my hope is to get your submission taken up by one of them.

JointFlow commented 1 year ago

Hi Kristen

Is it possible to suspend the review for a short period? We have just been told by the university (DTU) that they would like to host the repository on their own Github site, and have asked us to take it down from our site until this is sorted out, so I have had to make the repository private. I hope to get it back up again within the next week or so, and will let you know as soon as this is the case. I apologise for any inconvenience this has caused.

Best regards

Michael

kthyng commented 1 year ago

@JointFlow Yes that's fine. I would recommend withdrawing this submission until then, and resubmitting once you're ready. You can link to this pre-review issue to fill out the background details. Let me know if you want to withdraw and I could do that for you. Just know that one of our requirements is that people are able to make their own accounts to be able to contribute code and open issues, like on github. Would being on DTU's gitlab preclude that?

JointFlow commented 1 year ago

Hi Kristen

Sorry for being so slow in getting back to you - yes, if you could please withdraw the submission for now and I will get back to you once the issue is resolved. Regarding the account, we should be able to set up a fork of the code on our own account, if that will be OK for you? Otherwise, I can ask DTU how they normally resolve this problem - I am sure they must have come across it before.

Best regards

Michael

kthyng commented 1 year ago

@JointFlow

we should be able to set up a fork of the code on our own account, if that will be OK for you

As long as reviewers can open issues and future users can contribute code in some way through gitlab, it is ok. It might be worth checking in with the organization to see if it has come up before.

I'll withdraw now!

kthyng commented 1 year ago

@editorialbot withdraw

editorialbot commented 1 year ago

Paper withdrawn.