openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[PRE REVIEW]: r2ogs6: An R wrapper of the OpenGeoSys 6 Multiphysics Simulator #5067

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@joboog<!--end-author-handle-- (Johannes Boog) Repository: https://gitlab.opengeosys.org/ogs/tools/r2ogs6 Branch with paper.md (empty if default branch): 40-joss-submission Version: 0.4.643 Editor: !--editor-->@jsta<!--end-editor-- Reviewers: @jmp75, @waternumbers Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/08cb661c22ca8553e418acafeb9e7cb5"><img src="https://joss.theoj.org/papers/08cb661c22ca8553e418acafeb9e7cb5/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/08cb661c22ca8553e418acafeb9e7cb5/status.svg)](https://joss.theoj.org/papers/08cb661c22ca8553e418acafeb9e7cb5)

Author instructions

Thanks for submitting your paper to JOSS @joboog. Currently, there isn't a JOSS editor assigned to your paper.

@joboog if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago

Couldn't check the bibtex because branch name is incorrect: https://gitlab.opengeosys.org/ogs/tools/r2ogs6/-/tree/40-joss-submission

editorialbot commented 1 year ago

Couldn't check the bibtex because branch name is incorrect: https://gitlab.opengeosys.org/ogs/tools/r2ogs6/-/tree/40-joss-submission

editorialbot commented 1 year ago

:warning: An error happened when generating the pdf.

kthyng commented 1 year ago

@editorialbot set branch as 40-joss-submission

editorialbot commented 1 year ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

kthyng commented 1 year ago

@editorialbot set 40-joss-submission as branch

editorialbot commented 1 year ago

Done! branch is now 40-joss-submission

kthyng commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kthyng commented 1 year ago

@editorialbot check repository

editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.14 s (1232.2 files/s, 182514.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                              118           2903           2379          10071
XML                             39             12             61           6240
HTML                             3            100              6           1263
Markdown                         4            167              0            642
Rmd                              3            265            372            340
CMake                            1             21             23            295
TeX                              1             21              5            171
YAML                             2              2              9             54
Python                           1             14              5             36
-------------------------------------------------------------------------------
SUM:                           172           3505           2860          19112
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 1551

joboog commented 1 year ago

Thanks for starting the review thread.

Potential reviewers may be from list: nilzon123, babakmohammadi, tamnva, mikemahoney218, khaors

kthyng commented 1 year ago

Thanks for your submission @joboog and sorry about the delay around the holidays.

Our relevant editors are currently occupied so I need to add this to the waitlist. Thanks for your patience.

joboog commented 1 year ago

@kthyng Did the waitlist got any shorter?

kthyng commented 1 year ago

@joboog Thank you for your patience. We have two new editors coming on next week so my hope is to get your submission taken up by one of them.

kthyng commented 1 year ago

Hi @jsta! What do you think about editing this submission?

kthyng commented 1 year ago

@editorialbot invite @jsta as editor

editorialbot commented 1 year ago

Invitation to edit this submission sent!

editorialbot commented 1 year ago

Assigned! @editorname is now the editor

jsta commented 1 year ago

@editorialbot assign @jsta as editor

editorialbot commented 1 year ago

Assigned! @jsta is now the editor

jsta commented 1 year ago

Hi @joboog! I'm checking your submission against the scope requirements while I look for reviewers. Is there somewhere where the package vignettes are built in pdf or html? A link would be great, I think it would help immensely in checking scope. Thanks!

Edit: nevermind, I found them. stay tuned.

jsta commented 1 year ago

@NilzonAV and/or @khaors are you willing and able to review this submission?

jsta commented 1 year ago

@tamnva are you willing and able to review this submission?

jsta commented 1 year ago

@zgxn are you willing and able to review this submission?

jsta commented 1 year ago

:wave: @teeratornk Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

tamnva commented 1 year ago

@tamnva are you willing and able to review this submission?

yes, I can review this work

jsta commented 1 year ago

Thanks so much @tamnva !

jsta commented 1 year ago

@editorialbot add @tamnva as reviewer

editorialbot commented 1 year ago

@tamnva added to the reviewers list!

tamnva commented 1 year ago

@editorialbot add @tamnva as reviewer

Hi @jsta and @editorialbot, I just check the JOSS Conflict of Interest Policy. I am now working in the same organization (Helmholtz Centre for Environmental Research) with the 3 co-authors from this work. Can I still be a reviewer?

jsta commented 1 year ago

This is what the policy (https://joss.readthedocs.io/en/latest/reviewer_guidelines.html#joss-conflict-of-interest-policy) says. Is it the case that "you and a submitter are both employed by the same very large organization but in different units without any knowledge of each other"? @kthyng

tamnva commented 1 year ago

I checked again the co-authors detail and I think I am not eligible for being a reviewer as the second condition (.....without any knowledge of each other) is not really TRUE in my case. Sorry for not checking this carefully before. Please remove me from the reviewer list. Thank you

jsta commented 1 year ago

@kthyng Do you have any thoughts on the conflict of interest policy here?

jsta commented 1 year ago

@jmp75 are you willing and able to review this submission?

jmp75 commented 1 year ago

@jsta yes I can do this review

jsta commented 1 year ago

@editorialbot add @jmp75 as reviewer

editorialbot commented 1 year ago

@jmp75 added to the reviewers list!

kthyng commented 1 year ago

@jsta I'm sorry — I read through these comments when you pinged me before but apparently didn't say anything. I think if @tamnva feels like it is a conflict then we should treat it as such. If it is more of a technicality than a real conflict that impacts the ability to perform a review, then it is fine to state and waive.

jsta commented 1 year ago

@editorialbot remove @tamnva from reviewers

editorialbot commented 1 year ago

@tamnva removed from the reviewers list!

jsta commented 1 year ago

:wave: @waternumbers Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

jsta commented 1 year ago

:wave: @cneyens Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

waternumbers commented 1 year ago

Hi @jsta Happy to review.

jsta commented 1 year ago

Great! Thanks @waternumbers

jsta commented 1 year ago

@editorialbot add @waternumbers as reviewer

editorialbot commented 1 year ago

@waternumbers added to the reviewers list!

jsta commented 1 year ago

@editorialbot start review