openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: DAPPER: Data Assimilation with Python: a Package for Experimental Research #5080

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@patnr<!--end-author-handle-- (Patrick Nima Raanes) Repository: https://github.com/nansencenter/DAPPER Branch with paper.md (empty if default branch): paper_joss Version: v1.4.0 Editor: !--editor-->@Fei-Tao<!--end-editor-- Reviewers: @sara-02, @Shreyas911 Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/bb5284cf4b025308352da7544a9f6001"><img src="https://joss.theoj.org/papers/bb5284cf4b025308352da7544a9f6001/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/bb5284cf4b025308352da7544a9f6001/status.svg)](https://joss.theoj.org/papers/bb5284cf4b025308352da7544a9f6001)

Author instructions

Thanks for submitting your paper to JOSS @patnr. Currently, there isn't a JOSS editor assigned to your paper.

@patnr if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-030-77722-7_1 is OK
- 10.1007/s11004-021-09937-x is OK
- 10.5194/npg-26-325-2019 is OK
- 10.1002/qj.3386 is OK
- 10.1016/j.jocs.2020.101171 is OK
- 10.1137/1.9781611974546 is OK
- 10.1002/qj.2236 is OK
- 10.1175/2010MWR3253.1 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.25 s (659.2 files/s, 117617.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                         128           3622           6718           8594
SVG                              1              0             70           5726
Fortran 90                      10            251            310           1317
Markdown                        10            235              0            817
TeX                              2             62              0            571
XML                              1              0              0            228
YAML                             5             25             31            195
TOML                             1             17             27             99
Jupyter Notebook                 2              0            528             44
make                             1             14              4             37
Bourne Shell                     1              9             12             27
Jinja Template                   3              3              1             22
CSS                              1              0              0              4
-------------------------------------------------------------------------------
SUM:                           166           4238           7701          17681
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 442

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

arfon commented 1 year ago

@patnr - thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

patnr commented 1 year ago

Thank you arfon for beginning the process, and the information.

If it's any help, a similar library is https://github.com/cgrudz/DataAssimilationBenchmarks.jl with pre-review #3976 and review #4129

The assigned editor was taless474 while the assigned reviewers were peanutfun and tmigot. Among these peanutfun is perhaps particularly relevant since he knows about the subject and python. Please let me know if/when I should propose more reviewers.

sara-02 commented 1 year ago

@arfon @patnr, when this opens up, I would be interested in reviewing it.

Fei-Tao commented 1 year ago

@editorialbot assign me as editor

editorialbot commented 1 year ago

Assigned! @Fei-Tao is now the editor

Fei-Tao commented 1 year ago

๐Ÿ‘‹๐Ÿป Hi, @sara-02, @bonh,@peanutfun, @mbudisic, @Shreyas911, @zcstanley, if you'd like to review this submission, please comment here! Feel free to unsubscribe from this issue if you are not interested. Thanks for your time!

sara-02 commented 1 year ago

๐Ÿ‘‹๐Ÿป Hi, @sara-02, @bonh,@peanutfun, @mbudisic, @Shreyas911, @zcstanley, if you'd like to review this submission, please comment here! Feel free to unsubscribe from this issue if you are not interested. Thanks for your time!

Hey @Fei-Tao happy to help.

Shreyas911 commented 1 year ago

I am happy to review this too, @Fei-Tao. :)

Fei-Tao commented 1 year ago

Hi @sara-02 and @Shreyas911, thanks for your quick response. I will add you to the reviewer list. Since we have two reviewers, we can start the review process.

Fei-Tao commented 1 year ago

@editorialbot add @sara-02 as reviewer

editorialbot commented 1 year ago

@sara-02 added to the reviewers list!

Fei-Tao commented 1 year ago

@editorialbot add @Shreyas911 as reviewer

editorialbot commented 1 year ago

@Shreyas911 added to the reviewers list!

Fei-Tao commented 1 year ago

@editorialbot start review

editorialbot commented 1 year ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/5150.

Fei-Tao commented 1 year ago

Thanks everyone! Looking forward to your reviews in https://github.com/openjournals/joss-reviews/issues/5150.