Closed editorialbot closed 1 year ago
@mdhaber - I've just sent a pull request that includes minor changes. Could you please review the changes and apply the PR? Thank you in advance.
@mdhaber - One more thing, could you please add the ISBN code to the Fisher(1949) book in your bibtex file?
@editorialbot check references
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.2307/2331554 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1214/aoms/1177729437 is OK
- 1544-6115.1585 is OK
MISSING DOIs
- None
INVALID DOIs
- None
@editorialbot generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
@editorialbot set <DOI here> as archive
@editorialbot set <version here> as version
@editorialbot generate pdf
@editorialbot check references
and ask author(s) to update as needed@editorialbot recommend-accept
@mdhaber - could you please fulfill the requirements addressed in post-review checklist?
Sure, I'll work on that. Should I reformat these citations?
There probably should not be double parentheses. Do you remember offhand the syntax for removing those?
@mdhaber - sure, I think you don't need an e.g. here and just (Omar, 2021; Saenger, 2019; Ye, 2020) is enough.
For a quick reference, the following citation commands can be used:
@author:2001
-> "Author et al. (2001)"[@author:2001]
-> "(Author et al., 2001)"[@author1:2001; @author2:2001]
-> "(Author1 et al., 2001; Author2 et al., 2002)"@editorialbot generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
Here is the release: https://github.com/mdhaber/scipy/releases/tag/v1.10.0-joss-article
@editorialbot set v1.10.0-joss-article as version
Done! version is now v1.10.0-joss-article
The author, affiliation, and ORCID is correct.
Oops. Well, the release was created before those last commits. Should I remove and re-create the release?
@mdhaber - sure
@mdhaber - if commits are only on manuscript and bibtex, it is okay, we can proceed with the current one.
Good to know. But I went ahead and recreated it. Same URL. https://github.com/mdhaber/scipy/releases/tag/v1.10.0-joss-article
@editorialbot set v1.10.0-joss-article as version
@mdhaber - we can now go on with the archive creation. most authors choose Zenodo. please create an archive associated to this version tag and report the DOI here.
Done! version is now v1.10.0-joss-article
10.5281/zenodo.8031631
@mdhaber - In the software repo, it seems the license is BSD-3-Clause license
whereas in Zenodo archive it is Creative Commons Attribution 4.0 International
. Could you please correct that and report the changes here
Thanks. I must have been fixing that as you were writing this. I think it fixed the license at the original DOI.
@editorialbot set 10.5281/zenodo.8031631 as archive
Done! archive is now 10.5281/zenodo.8031631
@editorialbot check references
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.2307/2331554 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1214/aoms/1177729437 is OK
- 1544-6115.1585 is OK
MISSING DOIs
- None
INVALID DOIs
- None
@editorialbot generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
@mdhaber - All of the stuff looks fine to me. I am now recommending an acceptance. The track editor or editor-in-chief will have the final decision. Thank you!
@editorialbot recommend-accept
Attempting dry run of processing paper acceptance...
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.2307/2331554 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1214/aoms/1177729437 is OK
- 1544-6115.1585 is OK
MISSING DOIs
- None
INVALID DOIs
- None
:wave: @openjournals/dsais-eics, this paper is ready to be accepted and published.
Check final proof :point_right::page_facing_up: Download article
If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4302, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept
@editorialbot accept
Doing it live! Attempting automated processing of paper acceptance...
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.
If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.
You can copy the contents for your CITATION.cff file here:
``` cff-version: "1.2.0" authors: - family-names: Haberland given-names: Matt orcid: "https://orcid.org/0000-0003-4806-3601" contact: - family-names: Haberland given-names: Matt orcid: "https://orcid.org/0000-0003-4806-3601" doi: 10.5281/zenodo.8031631 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Haberland given-names: Matt orcid: "https://orcid.org/0000-0003-4806-3601" date-published: 2023-06-24 doi: 10.21105/joss.05092 issn: 2475-9066 issue: 86 journal: Journal of Open Source Software publisher: name: Open Journals start: 5092 title: Fast Resampling and Monte Carlo Methods in Python type: article url: "https://joss.theoj.org/papers/10.21105/joss.05092" volume: 8 title: Fast Resampling and Monte Carlo Methods in Python ```
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨
Here's what you must now do:
Any issues? Notify your editorial technical team...
:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:
If you would like to include a link to your paper from your README use the following code snippets:
Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05092/status.svg)](https://doi.org/10.21105/joss.05092)
HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05092">
<img src="https://joss.theoj.org/papers/10.21105/joss.05092/status.svg" alt="DOI badge" >
</a>
reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05092/status.svg
:target: https://doi.org/10.21105/joss.05092
This is how it will look in your documentation:
We need your help!
The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
Thanks, everyone!
Submitting author: !--author-handle-->@mdhaber<!--end-author-handle-- (Matt Haberland) Repository: https://github.com/mdhaber/scipy Branch with paper.md (empty if default branch): joss_resampling Version: v1.10.0-joss-article Editor: !--editor-->@jbytecode<!--end-editor-- Reviewers: @SaranjeetKaur, @kose-y Archive: 10.5281/zenodo.8031631
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@coatless & @SaranjeetKaur, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jbytecode know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @SaranjeetKaur
📝 Checklist for @kose-y