editorialbot commented 1 year ago

Submitting author: !--author-handle-->@mdhaber@jbytecode<!--end-editor-- Reviewers: @SaranjeetKaur, @kose-y Archive: 10.5281/zenodo.8031631

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/59d971c467460f42be7168b87a1dfbd4"><img src="https://joss.theoj.org/papers/59d971c467460f42be7168b87a1dfbd4/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/59d971c467460f42be7168b87a1dfbd4/status.svg)](https://joss.theoj.org/papers/59d971c467460f42be7168b87a1dfbd4)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@coatless & @SaranjeetKaur, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jbytecode know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @SaranjeetKaur

📝 Checklist for @kose-y

jbytecode commented 1 year ago

@mdhaber - I've just sent a pull request that includes minor changes. Could you please review the changes and apply the PR? Thank you in advance.

jbytecode commented 1 year ago

@mdhaber - One more thing, could you please add the ISBN code to the Fisher(1949) book in your bibtex file?

jbytecode commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.2307/2331554 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1214/aoms/1177729437 is OK
- 1544-6115.1585 is OK

MISSING DOIs

- None

INVALID DOIs

- None

jbytecode commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

jbytecode commented 1 year ago

Post-Review Checklist for Editor and Authors

Additional Author Tasks After Review is Complete

[ ] Double check authors and affiliations (including ORCIDs)
[ ] Make a release of the software with the latest changes from the review and post the version number here. This is the version that will be used in the JOSS paper.
[ ] Archive the release on Zenodo/figshare/etc and post the DOI here.
[ ] Make sure that the title and author list (including ORCIDs) in the archive match those in the JOSS paper.
[ ] Make sure that the license listed for the archive is the same as the software license.

Editor Tasks Prior to Acceptance

[x] Read the text of the paper and offer comments/corrections (as either a list or a PR)
[x] Check the references in the paper for corrections (e.g. capitalization)
[x] Check that the archive title, author list, version tag, and the license are correct
[x] Set archive DOI with @editorialbot set <DOI here> as archive
[x] Set version with @editorialbot set <version here> as version
[x] Double check rendering of paper with @editorialbot generate pdf
[x] Specifically check the references with @editorialbot check references and ask author(s) to update as needed
[ ] Recommend acceptance with @editorialbot recommend-accept

jbytecode commented 1 year ago

@mdhaber - could you please fulfill the requirements addressed in post-review checklist?

mdhaber commented 1 year ago

Sure, I'll work on that. Should I reformat these citations?

There probably should not be double parentheses. Do you remember offhand the syntax for removing those?

jbytecode commented 1 year ago

@mdhaber - sure, I think you don't need an e.g. here and just (Omar, 2021; Saenger, 2019; Ye, 2020) is enough.

jbytecode commented 1 year ago

For a quick reference, the following citation commands can be used:

@author:2001 -> "Author et al. (2001)"
[@author:2001] -> "(Author et al., 2001)"
[@author1:2001; @author2:2001] -> "(Author1 et al., 2001; Author2 et al., 2002)"

mdhaber commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

mdhaber commented 1 year ago

Here is the release: https://github.com/mdhaber/scipy/releases/tag/v1.10.0-joss-article

jbytecode commented 1 year ago

@editorialbot set v1.10.0-joss-article as version

editorialbot commented 1 year ago

Done! version is now v1.10.0-joss-article

mdhaber commented 1 year ago

The author, affiliation, and ORCID is correct.

mdhaber commented 1 year ago

Oops. Well, the release was created before those last commits. Should I remove and re-create the release?

jbytecode commented 1 year ago

@mdhaber - sure

jbytecode commented 1 year ago

@mdhaber - if commits are only on manuscript and bibtex, it is okay, we can proceed with the current one.

mdhaber commented 1 year ago

Good to know. But I went ahead and recreated it. Same URL. https://github.com/mdhaber/scipy/releases/tag/v1.10.0-joss-article

jbytecode commented 1 year ago

@editorialbot set v1.10.0-joss-article as version

@mdhaber - we can now go on with the archive creation. most authors choose Zenodo. please create an archive associated to this version tag and report the DOI here.

editorialbot commented 1 year ago

Done! version is now v1.10.0-joss-article

mdhaber commented 1 year ago

10.5281/zenodo.8031631

jbytecode commented 1 year ago

@mdhaber - In the software repo, it seems the license is BSD-3-Clause license whereas in Zenodo archive it is Creative Commons Attribution 4.0 International. Could you please correct that and report the changes here

mdhaber commented 1 year ago

Thanks. I must have been fixing that as you were writing this. I think it fixed the license at the original DOI.

jbytecode commented 1 year ago

@editorialbot set 10.5281/zenodo.8031631 as archive

editorialbot commented 1 year ago

Done! archive is now 10.5281/zenodo.8031631

jbytecode commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.2307/2331554 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1214/aoms/1177729437 is OK
- 1544-6115.1585 is OK

MISSING DOIs

- None

INVALID DOIs

- None

jbytecode commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

jbytecode commented 1 year ago

@mdhaber - All of the stuff looks fine to me. I am now recommending an acceptance. The track editor or editor-in-chief will have the final decision. Thank you!

jbytecode commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago

Attempting dry run of processing paper acceptance...

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.2307/2331554 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1214/aoms/1177729437 is OK
- 1544-6115.1585 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 1 year ago

:wave: @openjournals/dsais-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4302, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

gkthiruvathukal commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 1 year ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Haberland given-names: Matt orcid: "https://orcid.org/0000-0003-4806-3601" contact: - family-names: Haberland given-names: Matt orcid: "https://orcid.org/0000-0003-4806-3601" doi: 10.5281/zenodo.8031631 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Haberland given-names: Matt orcid: "https://orcid.org/0000-0003-4806-3601" date-published: 2023-06-24 doi: 10.21105/joss.05092 issn: 2475-9066 issue: 86 journal: Journal of Open Source Software publisher: name: Open Journals start: 5092 title: Fast Resampling and Monte Carlo Methods in Python type: article url: "https://joss.theoj.org/papers/10.21105/joss.05092" volume: 8 title: Fast Resampling and Monte Carlo Methods in Python ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 1 year ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 1 year ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4344
Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05092
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05092/status.svg)](https://doi.org/10.21105/joss.05092)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05092">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05092/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05092/status.svg
   :target: https://doi.org/10.21105/joss.05092

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

mdhaber commented 1 year ago

Thanks, everyone!

openjournals / joss-reviews

[REVIEW]: Fast Resampling and Monte Carlo Methods in Python #5092

Status

Reviewer instructions & questions

Checklists

Post-Review Checklist for Editor and Authors

Additional Author Tasks After Review is Complete

Editor Tasks Prior to Acceptance