search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[REVIEW]: FitSNAP: Atomistic machine learning with LAMMPS #5118

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@rohskopf<!--end-author-handle-- (Andrew Rohskopf) Repository: https://github.com/FitSNAP/FitSNAP Branch with paper.md (empty if default branch): Version: 3.0.1 Editor: !--editor-->@jmschrei<!--end-editor-- Reviewers: @tpurcell90, @bahung Archive: 10.5281/zenodo.7764752

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/daf91b67f1e71277e59f2ba6fc0b694f"><img src="https://joss.theoj.org/papers/daf91b67f1e71277e59f2ba6fc0b694f/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/daf91b67f1e71277e59f2ba6fc0b694f/status.svg)](https://joss.theoj.org/papers/daf91b67f1e71277e59f2ba6fc0b694f)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@tpurcell90 & @bahung, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jmschrei know.

āœØ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest āœØ

Checklists

šŸ“ Checklist for @tpurcell90

šŸ“ Checklist for @bahung

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago 
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 1 year ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Rohskopf given-names: A. orcid: "https://orcid.org/0000-0002-2712-8296" - family-names: Sievers given-names: C. - family-names: Lubbers given-names: N. orcid: "https://orcid.org/0000-0002-9001-9973" - family-names: Cusentino given-names: M. A. orcid: "https://orcid.org/0000-0001-9505-6442" - family-names: Goff given-names: J. orcid: "https://orcid.org/0000-0001-7026-7200" - family-names: Janssen given-names: J. orcid: "https://orcid.org/0000-0001-9948-7119" - family-names: McCarthy given-names: M. orcid: "https://orcid.org/0000-0003-4388-4953" - family-names: Oca Zapiain given-names: D. Montes name-particle: de orcid: "https://orcid.org/0000-0001-7890-0859" - family-names: Nikolov given-names: S. orcid: "https://orcid.org/0000-0002-2907-6629" - family-names: Sargsyan given-names: K. orcid: "https://orcid.org/0000-0002-1037-786X" - family-names: Sema given-names: D. orcid: "https://orcid.org/0000-0002-0160-1743" - family-names: Sikorski given-names: E. orcid: "https://orcid.org/0000-0003-3292-6564" - family-names: Williams given-names: L. orcid: "https://orcid.org/0000-0002-9062-8293" - family-names: Thompson given-names: A. P. orcid: "https://orcid.org/0000-0002-0324-9114" - family-names: Wood given-names: M. A. orcid: "https://orcid.org/0000-0001-5878-4096" contact: - family-names: Wood given-names: M. A. orcid: "https://orcid.org/0000-0001-5878-4096" doi: 10.5281/zenodo.7764752 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Rohskopf given-names: A. orcid: "https://orcid.org/0000-0002-2712-8296" - family-names: Sievers given-names: C. - family-names: Lubbers given-names: N. orcid: "https://orcid.org/0000-0002-9001-9973" - family-names: Cusentino given-names: M. A. orcid: "https://orcid.org/0000-0001-9505-6442" - family-names: Goff given-names: J. orcid: "https://orcid.org/0000-0001-7026-7200" - family-names: Janssen given-names: J. orcid: "https://orcid.org/0000-0001-9948-7119" - family-names: McCarthy given-names: M. orcid: "https://orcid.org/0000-0003-4388-4953" - family-names: Oca Zapiain given-names: D. Montes name-particle: de orcid: "https://orcid.org/0000-0001-7890-0859" - family-names: Nikolov given-names: S. orcid: "https://orcid.org/0000-0002-2907-6629" - family-names: Sargsyan given-names: K. orcid: "https://orcid.org/0000-0002-1037-786X" - family-names: Sema given-names: D. orcid: "https://orcid.org/0000-0002-0160-1743" - family-names: Sikorski given-names: E. orcid: "https://orcid.org/0000-0003-3292-6564" - family-names: Williams given-names: L. orcid: "https://orcid.org/0000-0002-9062-8293" - family-names: Thompson given-names: A. P. orcid: "https://orcid.org/0000-0002-0324-9114" - family-names: Wood given-names: M. A. orcid: "https://orcid.org/0000-0001-5878-4096" date-published: 2023-04-06 doi: 10.21105/joss.05118 issn: 2475-9066 issue: 84 journal: Journal of Open Source Software publisher: name: Open Journals start: 5118 title: "FitSNAP: Atomistic machine learning with LAMMPS" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05118" volume: 8 title: "FitSNAP: Atomistic machine learning with LAMMPS" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 1 year ago

šŸ¦šŸ¦šŸ¦ šŸ‘‰ Tweet for this paper šŸ‘ˆ šŸ¦šŸ¦šŸ¦

editorialbot commented 1 year ago

šŸ˜šŸ˜šŸ˜ šŸ‘‰ Toot for this paper šŸ‘ˆ šŸ˜šŸ˜šŸ˜

editorialbot commented 1 year ago

šŸšØšŸšØšŸšØ THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! šŸšØšŸšØšŸšØ

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4105
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05118
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! šŸŽ‰šŸŒˆšŸ¦„šŸ’ƒšŸ‘»šŸ¤˜

Any issues? Notify your editorial technical team...

Kevin-Mattheus-Moerman commented 1 year ago

Congratulations on this paper @rohskopf

Thanks for editing @jmschrei, and a special thanks to the reviewers @tpurcell90 and @bahung!!!

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05118/status.svg)](https://doi.org/10.21105/joss.05118)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05118">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05118/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05118/status.svg
   :target: https://doi.org/10.21105/joss.05118

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: