[REVIEW]: excitingtools: An exciting Workflow Tool

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@AlexBuccheri@richardjgowers<!--end-editor-- Reviewers: @fjmartinmartinez, @hmacdope Archive: 10.5281/zenodo.7799887

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f7f9fd278e2f257e43cd4fb99986848e"><img src="https://joss.theoj.org/papers/f7f9fd278e2f257e43cd4fb99986848e/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f7f9fd278e2f257e43cd4fb99986848e/status.svg)](https://joss.theoj.org/papers/f7f9fd278e2f257e43cd4fb99986848e)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@fjmartinmartinez & @hmacdope, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @richardjgowers know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @fjmartinmartinez

📝 Checklist for @hmacdope

AlexBuccheri commented 1 year ago

No problem 🙂

kyleniemeyer commented 1 year ago

Whoops, missed this one earlier somehow. I'll now do final checks before publishing.

kyleniemeyer commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago

Attempting dry run of processing paper acceptance...

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1088/0953-8984/26/36/363202 is OK
- 10.1103/physrevb.97.161105 is OK
- 10.1103/PhysRevB.94.035118 is OK
- 10.1126/science.aad3000 is OK
- 10.1088/1361-648X/aa680e is OK
- 10.1016/j.commatsci.2017.07.030 is OK
- 10.1016/j.commatsci.2021.110731 is OK
- 10.48550/arXiv.2209.12747 is OK
- 10.1063/1.4812323 is OK
- 10.1016/j.commatsci.2012.02.005 is OK
- 10.1088/2515-7639/ab13bb is OK
- 10.1007/978-3-319-44677-6_104 is OK
- 10.1038/s42256-021-00319-w is OK
- 10.1093/bib/bbab391 is OK
- 10.1063/1.5143061 is OK
- 10.1103/physrevb.12.3060 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 1 year ago

:wave: @openjournals/pe-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4193, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

kyleniemeyer commented 1 year ago

Hi @AlexBuccheri, it looks like the author list on the Zenodo archive does not fully match the paper author list—generally these should be the same. Can you check on that?

AlexBuccheri commented 1 year ago

Hi @kyleniemeyer ah, the difference was the PI. She is not in theCONTRIBUTING.md having not worked on the code, but was part of the paper. I've amended the information on Zenodo to include her.

kyleniemeyer commented 1 year ago

@AlexBuccheri got it, thanks!

kyleniemeyer commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 1 year ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Buccheri given-names: Alexander orcid: "https://orcid.org/0000-0001-5983-8631" - family-names: Peschel given-names: Fabian orcid: "https://orcid.org/0000-0003-0619-6713" - family-names: Maurer given-names: Benedikt orcid: "https://orcid.org/0000-0001-9152-7390" - family-names: Voiculescu given-names: Mara orcid: "https://orcid.org/0000-0003-4393-8528" - family-names: Speckhard given-names: Daniel T. orcid: "https://orcid.org/0000-0002-9849-0022" - family-names: Kleine given-names: Hannah orcid: "https://orcid.org/0000-0003-2251-8719" - family-names: Stephan given-names: Elisa orcid: "https://orcid.org/0000-0002-6359-9044" - family-names: Kuban given-names: Martin orcid: "https://orcid.org/0000-0002-1619-2460" - family-names: Draxl given-names: Claudia orcid: "https://orcid.org/0000-0003-3523-6657" doi: 10.5281/zenodo.7799887 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Buccheri given-names: Alexander orcid: "https://orcid.org/0000-0001-5983-8631" - family-names: Peschel given-names: Fabian orcid: "https://orcid.org/0000-0003-0619-6713" - family-names: Maurer given-names: Benedikt orcid: "https://orcid.org/0000-0001-9152-7390" - family-names: Voiculescu given-names: Mara orcid: "https://orcid.org/0000-0003-4393-8528" - family-names: Speckhard given-names: Daniel T. orcid: "https://orcid.org/0000-0002-9849-0022" - family-names: Kleine given-names: Hannah orcid: "https://orcid.org/0000-0003-2251-8719" - family-names: Stephan given-names: Elisa orcid: "https://orcid.org/0000-0002-6359-9044" - family-names: Kuban given-names: Martin orcid: "https://orcid.org/0000-0002-1619-2460" - family-names: Draxl given-names: Claudia orcid: "https://orcid.org/0000-0003-3523-6657" date-published: 2023-05-03 doi: 10.21105/joss.05148 issn: 2475-9066 issue: 85 journal: Journal of Open Source Software publisher: name: Open Journals start: 5148 title: "excitingtools: An exciting Workflow Tool" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05148" volume: 8 title: "excitingtools: An exciting Workflow Tool" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 1 year ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

editorialbot commented 1 year ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 1 year ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4194
Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05148
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

AlexBuccheri commented 1 year ago

I can confirm that the DOI is now live. It appears that I don't have the option to close the issue, so perhaps @kyleniemeyer or @richardjgowers would like do so?

Thanks once again for all the hard work.

kyleniemeyer commented 1 year ago

@AlexBuccheri I've been waiting for the PDF itself to appear before closing the issue, but yes otherwise this looks good to go. Congratulations on your article's publication in JOSS!

Many thanks to @fjmartinmartinez and @hmacdope for reviewing this, and @richardjgowers for editing.

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05148/status.svg)](https://doi.org/10.21105/joss.05148)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05148">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05148/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05148/status.svg
   :target: https://doi.org/10.21105/joss.05148

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews