openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[PRE REVIEW]: ViMag: A Visual Vibration Analysis Toolbox #5178

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@RLado<!--end-author-handle-- (Ricard Lado Roigé) Repository: https://github.com/RLado/ViMag Branch with paper.md (empty if default branch): JOSS Version: v0.1.6 Editor: !--editor-->@Kevin-Mattheus-Moerman<!--end-editor-- Reviewers: @jankoslavic, @iamtsac Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/a0149e43cf19bbafe1cb9eecdcde6189"><img src="https://joss.theoj.org/papers/a0149e43cf19bbafe1cb9eecdcde6189/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/a0149e43cf19bbafe1cb9eecdcde6189/status.svg)](https://joss.theoj.org/papers/a0149e43cf19bbafe1cb9eecdcde6189)

Author instructions

Thanks for submitting your paper to JOSS @RLado. Currently, there isn't a JOSS editor assigned to your paper.

@RLado if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.11 s (239.5 files/s, 207460.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                             2              0              0          10779
CSS                              3           2571             31           5698
JavaScript                       4            299            352           1657
SVG                              4              4              4            865
Python                           4             90             90            344
HTML                             3             26              7            188
TeX                              1             10              0            150
Markdown                         2             51              0             88
Bourne Shell                     2              4              4             24
DOS Batch                        1              4              5             19
YAML                             1              1              4             18
-------------------------------------------------------------------------------
SUM:                            27           3060            497          19830
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 899

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.measurement.2022.112218 is OK
- 10.48550/arXiv.2302.10001 is OK
- 10.48550/arXiv.1804.02684 is OK
- 10.1016/j.ymssp.2017.09.019 is OK
- 10.1016/j.ymssp.2020.106995 is OK
- 10.1145/2601097.2601119 is OK
- 10.1061/(ASCE)0733-9445(1987)113:7(1533) is OK
- 10.1002/(SICI)1528-2716(200001/03)2:1<50::AID-PSE7>3.0.CO;2-S is OK
- 10.48550/ARXIV.2010.11929 is OK
- 10.48550/ARXIV.1706.03762 is OK
- 10.48550/ARXIV.2103.14030 is OK
- 10.48550/arXiv.2009.07432 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

arfon commented 1 year ago

:wave: @RLado – thanks for your submission to JOSS. Could you please help me understand where the novel code contributions are for this software? For example, I see some Python code but also some linked submodules. There also looks to be some JavaScript in the project too. Essentially, please explain what parts are written by you as part of this submission.

Thank you!

RLado commented 1 year ago

Hello @arfon.

The submodule STB-VMM [1] corresponds to a previous submission to Knowledge-Based Systems (under review) and is used as the motion magnification backend for ViMag.

The other included Python submodules [2][3] are part of the core functionality of ViMag and do not correspond to any previous publications. I have used these submodules as standalone CLI tools to verify our damage detection methodology, for this reason they are presented in this format. The javascript code corresponds to the electron app that combines these tools into a user-friendly, multiplatform and practical interface.

Sorry for any confusion caused. And thank you for your time.

arfon commented 1 year ago

@editorialbot query scope

Thanks @RLado – I'm going to ask for the input of the wider JOSS editorial team here on whether we think this submission is in scope for JOSS.

Note to JOSS editors: These are the two submodules being references above:

cloc TempSlice/
       8 text files.
       8 unique files.                              
       1 file ignored.

github.com/AlDanial/cloc v 1.96  T=0.01 s (781.9 files/s, 79757.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           6            107             72            453
Markdown                         1             33              0            139
Text                             1              0              0             12
-------------------------------------------------------------------------------
SUM:                             8            140             72            604
-------------------------------------------------------------------------------
cloc Tiled-STB-VMM/
       6 text files.
       4 unique files.                              
       3 files ignored.

github.com/AlDanial/cloc v 1.96  T=0.01 s (430.6 files/s, 40370.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           1             45             48            199
Markdown                         2             16              0             62
Text                             1              0              0              5
-------------------------------------------------------------------------------
SUM:                             4             61             48            266
-------------------------------------------------------------------------------
editorialbot commented 1 year ago

Submission flagged for editorial review.

arfon commented 1 year ago

@editorialbot assign @Kevin-Mattheus-Moerman as editor

Thanks for agreeing to edit this Kevin!

editorialbot commented 1 year ago

Assigned! @Kevin-Mattheus-Moerman is now the editor

kyleniemeyer commented 1 year ago

I've moved this to the PE track as well

Kevin-Mattheus-Moerman commented 1 year ago

@iamtsac @ZHANGKEON @capepoint would you be interested in reviewing a paper for the Journal of Open Source Software (JOSS) entitled: "ViMag: A Visual Vibration Analysis Toolbox"?

JOSS reviews focus on the software as well as a short paper

JOSS reviews take place on GitHub and reviewers are guided by a set of check boxes. Here is an example of an ongoing review: https://github.com/openjournals/joss-reviews/issues/5278.

You can let me know here if you are interested. Let me know if you have any question.

Kevin-Mattheus-Moerman commented 1 year ago

@josepfontm at first sight it seems your expertise would qualify you to review this work, however, I assume you have a conflict of interest with the authors?

Kevin-Mattheus-Moerman commented 1 year ago

@RLado would you be able to help suggest any reviewers? Please mention their github handles here, but leave out the @ to avoid them being tagged. Thanks.

josepfontm commented 1 year ago

@Kevin-Mattheus-Moerman Thanks for considering me as a possible reviewer. Unfortunately, I collaborate with @RLado frequently, as you correctly assumed I am not a viable reviewer. Nonetheless, I have some suggestions which might interest you. All the reviewers I propose are researchers working in the same field as us: Structural Health Monitoring/Vibration Analysis and have active communities on Github.

I would suggest contacting the people behind the PyOMA project. https://github.com/dagghe/PyOMA

In addition, the research group from Professor Janko Slavič has wide experience in open-source projects and, more specifically, in vibration analysis. I attach their website: http://lab.fs.uni-lj.si/ladisk/?

Best,

Kevin-Mattheus-Moerman commented 1 year ago

@iamtsac @ZHANGKEON @capepoint @marco-rosso-m @jankoslavic would you be interested in reviewing a paper for the Journal of Open Source Software (JOSS) entitled: "ViMag: A Visual Vibration Analysis Toolbox"?

JOSS reviews focus on the software as well as a short paper

JOSS reviews take place on GitHub and reviewers are guided by a set of check boxes. Here is an example of an ongoing review: https://github.com/openjournals/joss-reviews/issues/5278.

You can let me know here if you are interested. Let me know if you have any question.

jankoslavic commented 1 year ago

@Kevin-Mattheus-Moerman Thank you for the invite. I can take the effort. How much time do I have?

Kevin-Mattheus-Moerman commented 1 year ago

@jankoslavic that is great. We used to aim for a 2-3 week turn around but we have to be more flexible these days :) . Perhaps you can aim for ~3 weeks and just let me know if you need more time. I'll assign you as a reviewer now. Thanks. FYI this is a pre-review issue, I'll open a dedicated review issue once I'll have enough reviewers and then we'll start. Having said that, if you'd like to get started reviewing the paper and testing the software already, you are more then welcome too.

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot add @jankoslavic as reviewer

editorialbot commented 1 year ago

@jankoslavic added to the reviewers list!

marco-rosso-m commented 1 year ago

Dear @Kevin-Mattheus-Moerman Thank you for inviting me to this review. However, I have some issues at the moment and I can not dedicate any time resources to properly work on this review. I feel better to decline your invitation. Thank you anyway for considering me. Best regards.

iamtsac commented 1 year ago

@Kevin-Mattheus-Moerman, sorry for the late reply. You can add me as a reviewer, and thank you for the invitation.

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot add @iamtsac as reviewer

editorialbot commented 1 year ago

@iamtsac added to the reviewers list!

Kevin-Mattheus-Moerman commented 1 year ago

I'll trigger the start of the review now.

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot start review

editorialbot commented 1 year ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/5491.