openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: A Python package for homogenization procedures in fiber reinforced polymers #5199

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@Extraweich<!--end-author-handle-- (Nicolas Christ) Repository: https://github.com/Extraweich/homopy Branch with paper.md (empty if default branch): Version: v1.0.10 Editor: !--editor-->@Kevin-Mattheus-Moerman<!--end-editor-- Reviewers: @likask, @nicoguaro, @lizarett Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/3ff6841e9a89fc91a0578df9ca677179"><img src="https://joss.theoj.org/papers/3ff6841e9a89fc91a0578df9ca677179/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/3ff6841e9a89fc91a0578df9ca677179/status.svg)](https://joss.theoj.org/papers/3ff6841e9a89fc91a0578df9ca677179)

Author instructions

Thanks for submitting your paper to JOSS @Extraweich. Currently, there isn't a JOSS editor assigned to your paper.

@Extraweich if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.20 s (380.8 files/s, 229841.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              8              3             51          22133
JavaScript                      14           2420           2485           9106
HTML                            16            543             48           4103
Python                          10            291            619            879
Jupyter Notebook                 5              0           1795            788
CSS                              5            187             39            759
TeX                              1             22              0            270
Markdown                         5             70              0            216
YAML                             2              7              4             42
reStructuredText                10             35             66             40
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            78           3590           5115          38371
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 889

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.mechmat.2022.104307 is OK
- 10.21105/joss.04389 is OK
- 10.1115/1.3153710 is OK
- 10.1007/978-3-030-28983-6 is OK
- 10.1122/1.549945 is OK
- 10.1016/0001-6160(73)90064-3 is OK
- 10.1088/0508-3443/3/3/302 is OK
- 10.1088/978-0-7503-1454-1ch26 is OK
- 10.1016/0167-6636(87)90005-6 is OK
- 10.5445/KSP/1000070061 is OK
- 10.1007/978-3-662-46737-4 is OK
- 10.1002/pc.750050413 is OK
- 10.1007/978-94-009-3489-4 is OK
- 10.1016/S0266-3538(97)00129-2 is OK
- 10.1016/j.mechmat.2023.104555 is OK
- 10.1016/S1359-835X(97)00117-6 is OK
- 10.1016/0010-4361(78)90341-5 is OK
- 10.1016/j.compositesa.2014.08.027 is OK
- 10.5281/zenodo.6461940 is OK
- 10.5281/zenodo.4029448 is OK

MISSING DOIs

- 10.21236/ad0692481 may be a valid DOI for title: Effects of Environmental Factors on Composite Materials

INVALID DOIs

- None
editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Extraweich commented 1 year ago

Potential reviewer seem to be timokoch, shravantata, sthavishtha and mbagheri20, to name a few.

Extraweich commented 1 year ago

@editorialbot commands

editorialbot commented 1 year ago

Hello @Extraweich, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers
Extraweich commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.mechmat.2022.104307 is OK
- 10.21105/joss.04389 is OK
- 10.1115/1.3153710 is OK
- 10.1007/978-3-030-28983-6 is OK
- 10.1122/1.549945 is OK
- 10.1016/0001-6160(73)90064-3 is OK
- 10.1088/0508-3443/3/3/302 is OK
- 10.21236/ad0692481 is OK
- 10.1088/978-0-7503-1454-1ch26 is OK
- 10.1016/0167-6636(87)90005-6 is OK
- 10.5445/KSP/1000070061 is OK
- 10.1007/978-3-662-46737-4 is OK
- 10.1002/pc.750050413 is OK
- 10.1007/978-94-009-3489-4 is OK
- 10.1016/S0266-3538(97)00129-2 is OK
- 10.1016/j.mechmat.2023.104555 is OK
- 10.1016/S1359-835X(97)00117-6 is OK
- 10.1016/0010-4361(78)90341-5 is OK
- 10.1016/j.compositesa.2014.08.027 is OK
- 10.5281/zenodo.6461940 is OK
- 10.5281/zenodo.4029448 is OK

MISSING DOIs

- None

INVALID DOIs

- None
Extraweich commented 1 year ago

@editorialbot check repository

editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.22 s (348.8 files/s, 210427.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              8              3             51          22133
JavaScript                      14           2420           2485           9106
HTML                            16            544             48           4087
Python                          10            291            617            879
Jupyter Notebook                 5              0           1795            788
CSS                              5            187             39            759
TeX                              1             22              0            271
Markdown                         5             70              0            216
YAML                             2              7              4             42
reStructuredText                10             35             66             40
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            78           3591           5113          38356
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 889

Extraweich commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Extraweich commented 1 year ago

I think a better label would be "Track: 3 PE", since it is really more of an engineering / material science / material physics software.

kyleniemeyer commented 1 year ago

Hi @Extraweich, we made that track move, and @Kevin-Mattheus-Moerman has volunteered to edit your submission. We'll use this issue to also find reviewers—any suggestions you have would be welcome.

kyleniemeyer commented 1 year ago

@editorialbot invite @Kevin-Mattheus-Moerman as editor

editorialbot commented 1 year ago

Invitation to edit this submission sent!

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot assign me as editor

editorialbot commented 1 year ago

Assigned! @Kevin-Mattheus-Moerman is now the editor

Extraweich commented 1 year ago

@editorialbot assign me as editor

Thanks a lot for your volunteering!

Kevin-Mattheus-Moerman commented 1 year ago

@JulianKarlBauer you are a code contributor for this work but not listed as an author. @Extraweich it may be okay to exclude certain contributors as authors, but I am just raising this here in case this is by mistake or in case the contributor in questions feels co-authorship would be appropriate. Can you confirm the author set of the paper is accurate/complete? Note, if you like, you may also consider acknowledging contributors in the paper's acknowledgement section.

Kevin-Mattheus-Moerman commented 1 year ago

@nicoguaro, @likask, @lizarett, @nickelnine37, @frederickgosselin, @PolymerGuy, @fmatuschke would you be interested in reviewing this submission for JOSS? It concerns a "Python package for homogenization procedures in fiber reinforced polymers".

Paper Software

likask commented 1 year ago

@Kevin-Mattheus-Moerman Happy to do this.

frederickgosselin commented 1 year ago

Hi Kevin, Thanks for the invitation. This is a bit besides my area of expertise. Perhaps my colleague Martin Levesque at Polytechnique Montréal or his former PhD student Elias Ghossein who now work at Maya HTT could be available. This is dead on their specialty.

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot add @likask as reviewer

editorialbot commented 1 year ago

@likask added to the reviewers list!

nicoguaro commented 1 year ago

@Kevin-Mattheus-Moerman, I can help with this.

lizarett commented 1 year ago

hello, this is a bit aside from my knowledge, but i can look. please, add me @Kevin-Mattheus-Moerman

nickelnine37 commented 1 year ago

Hi @Kevin-Mattheus-Moerman, this looks interesting but it's also a little far outside of my area of expertise, so I will have to decline. Best wishes. Ed

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot add @nicoguaro as reviewer

editorialbot commented 1 year ago

@nicoguaro added to the reviewers list!

Kevin-Mattheus-Moerman commented 1 year ago

@lizarett I'll add you an an $(n+1)^{th}$ reviewer, since you expressed an interest.

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot add @lizarett as reviewer

editorialbot commented 1 year ago

@lizarett added to the reviewers list!

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot start review

editorialbot commented 1 year ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/5295.

JulianKarlBauer commented 1 year ago

@JulianKarlBauer you are a code contributor for this work but not listed as an author. @Extraweich it may be okay to exclude certain contributors as authors, but I am just raising this here in case this is by mistake or in case the contributor in questions feels co-authorship would be appropriate. Can you confirm the author set of the paper is accurate/complete? Note, if you like, you may also consider acknowledging contributors in the paper's acknowledgement section.

Thank you @Kevin-Mattheus-Moerman for raising this question. @Extraweich kindly contacted me beforehand and again after your remark. I only did a little bit of code clean-up and took the opportunity to compare some minor features which homopy shares with mechkit and mechmean. These comparisons actually made their way to the tests, which I am very happy about. However, I did not contribute to the actual new content within homopy nor the paper itself. Therefore, I think that co-authorship is not appropriate. Thank you again for raising the question :) And thanks @Extraweich for making this great contribution and giving the opportunity for comparisons, this is very valuable.

Kevin-Mattheus-Moerman commented 1 year ago

@JulianKarlBauer okay, thanks for getting back to us with this information.