[REVIEW]: Mobilkit: A Python Toolkit for Urban Resilience and Disaster Risk Management Analytics using High Frequency Human Mobility Data

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@takayabe0505@crvernon<!--end-editor-- Reviewers: @ifthompson, @levisweetbreu Archive: 10.6084/m9.figshare.24707115

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/aee7d69db418d0e47105ce41c91a096d"><img src="https://joss.theoj.org/papers/aee7d69db418d0e47105ce41c91a096d/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/aee7d69db418d0e47105ce41c91a096d/status.svg)](https://joss.theoj.org/papers/aee7d69db418d0e47105ce41c91a096d)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@ssujit & @jlevente, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @crvernon know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @levisweetbreu

📝 Checklist for @ifthompson

crvernon commented 8 months ago

@editorialbot recommend-accept

editorialbot commented 8 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 8 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 8 months ago

:wave: @openjournals/sbcs-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4984, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

oliviaguest commented 8 months ago

@editorialbot recommend-accept

editorialbot commented 8 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 8 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 8 months ago

:wave: @openjournals/sbcs-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5003, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

oliviaguest commented 8 months ago

@takayabe0505 can you fix the double parentheses for the citations please? So make it for example:

(e.g., De Montjoye et al., 2016 or Pappalardo et al., 2019)

Otherwise, it's looking good. Just tag me when you're done. :)

ubi15 commented 8 months ago

@oliviaguest we substituted the parentheses with an em dash (as the inner parenthesis is due to the citation style).

Let us know if you need any other edit.

oliviaguest commented 7 months ago

@editorialbot recommend-accept

editorialbot commented 7 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 7 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 7 months ago

:wave: @openjournals/sbcs-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5045, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

oliviaguest commented 7 months ago

@ubi15 no, sorry, this still isn't right. Please change to not use parentheses. I think you haven't seen the command yet, I'll tag it in a PR for you, no problem. 😊

Take a look at this and feel free to merge or make your own edits as needed: https://github.com/mindearth/mobilkit/pull/18

ubi15 commented 7 months ago

Thanks a lot @oliviaguest , I completely missed the square brackets. We merged your suggestions, many many thanks for your help on this!

oliviaguest commented 7 months ago

@editorialbot recommend-accept

editorialbot commented 7 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 7 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 7 months ago

:wave: @openjournals/sbcs-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5081, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

oliviaguest commented 7 months ago

@editorialbot accept

editorialbot commented 7 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 7 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Ubaldi given-names: Enrico orcid: "https://orcid.org/0000-0003-1685-9939" - family-names: Yabe given-names: Takahiro orcid: "https://orcid.org/0000-0001-8967-1967" - family-names: Jones given-names: Nicholas - family-names: Khan given-names: Maham Faisal - family-names: Feliciotti given-names: Alessandra orcid: "https://orcid.org/0000-0002-1471-5360" - family-names: Clemente given-names: Riccardo Di orcid: "https://orcid.org/0000-0001-8005-6351" - family-names: Ukkusuri given-names: Satish V. - family-names: Strano given-names: Emanuele orcid: "https://orcid.org/0000-0002-2339-6824" contact: - family-names: Yabe given-names: Takahiro orcid: "https://orcid.org/0000-0001-8967-1967" doi: 10.6084/m9.figshare.24707115 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Ubaldi given-names: Enrico orcid: "https://orcid.org/0000-0003-1685-9939" - family-names: Yabe given-names: Takahiro orcid: "https://orcid.org/0000-0001-8967-1967" - family-names: Jones given-names: Nicholas - family-names: Khan given-names: Maham Faisal - family-names: Feliciotti given-names: Alessandra orcid: "https://orcid.org/0000-0002-1471-5360" - family-names: Clemente given-names: Riccardo Di orcid: "https://orcid.org/0000-0001-8005-6351" - family-names: Ukkusuri given-names: Satish V. - family-names: Strano given-names: Emanuele orcid: "https://orcid.org/0000-0002-2339-6824" date-published: 2024-03-01 doi: 10.21105/joss.05201 issn: 2475-9066 issue: 95 journal: Journal of Open Source Software publisher: name: Open Journals start: 5201 title: "Mobilkit: A Python Toolkit for Urban Resilience and Disaster Risk Management Analytics" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05201" volume: 9 title: "Mobilkit: A Python Toolkit for Urban Resilience and Disaster Risk Management Analytics" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 7 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 7 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5082
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05201
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

oliviaguest commented 7 months ago

@arfon do you know why the version of the paper that editorialbot published is not the latest?

oliviaguest commented 7 months ago

Huge thanks to the editor: @crvernon reviewers: @ifthompson, @levisweetbreu! ✨ JOSS appreciates your work and effort. ✨ Also, big congratulations to the author @takayabe0505! 🥳 🍾

editorialbot commented 7 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05201/status.svg)](https://doi.org/10.21105/joss.05201)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05201">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05201/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05201/status.svg
   :target: https://doi.org/10.21105/joss.05201

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews