[REVIEW]: SLEPLET: Slepian scale-discretised wavelets in Python

[editorialbot]

Submitting author: !--author-handle-->@paddyroddy<!--end-author-handle-- (Patrick James Roddy) Repository: https://github.com/astro-informatics/sleplet Branch with paper.md (empty if default branch): main Version: v1.3.6 Editor: !--editor-->@vissarion<!--end-editor-- Reviewers: @Saran-nns, @klb2 Archive: 10.5281/zenodo.7835860

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/55d9cf16a27bf2d3141f0f66c676b7f2"><img src="https://joss.theoj.org/papers/55d9cf16a27bf2d3141f0f66c676b7f2/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/55d9cf16a27bf2d3141f0f66c676b7f2/status.svg)](https://joss.theoj.org/papers/55d9cf16a27bf2d3141f0f66c676b7f2)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@Saran-nns & @klb2, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @vissarion know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @klb2

📝 Checklist for @Saran-nns

[vissarion]

@editorialbot set main as branch

[editorialbot]

Done! branch is now main

[vissarion]

@editorialbot generate pdf

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[vissarion]

@editorialbot check references

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/TSP.2016.2646668 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1002/j.1538-7305.1961.tb03977.x is OK
- 10.1002/j.1538-7305.1962.tb03279.x is OK
- 10.1051/0004-6361/201220729 is OK
- 10.1145/3134472.3134497 is OK
- 10.1109/TSP.2011.2166394 is OK
- 10.1109/LSP.2021.3050961 is OK
- 10.1109/TSP.2022.3233309 is OK
- 10.5281/zenodo.7268074 is OK
- 10.1137/S0036144504445765 is OK
- 10.5281/zenodo.4085210 is OK
- 10.1002/j.1538-7305.1961.tb03976.x is OK
- 10.1111/j.1365-2966.2008.13448.x is OK
- 10.1029/2018GC007529 is OK

MISSING DOIs

- None

INVALID DOIs

- None

[paddyroddy]

Thanks! Please use the full title in the archive i.e. "SLEPLET: Slepian scale-discretised wavelets in Python" which is the same as the paper.

Sorry do you mean in the paper.bib in the archive or do you mean the archive name should be that?

[vissarion]

Thanks! Please use the full title in the archive i.e. "SLEPLET: Slepian scale-discretised wavelets in Python" which is the same as the paper.

Sorry do you mean in the paper.bib in the archive or do you mean the archive name should be that?

I mean the zenodo archive name, thanks.

[paddyroddy]

Apologies, I was on holiday and hadn't understood what you meant previously. I've made a release v1.3.5 with the name in the archive https://zenodo.org/record/7825341.

[Saran-nns]

@paddyroddy I think @vissarion asks for the zenodo archive title to be same as the title of the paper SLEPLET: Slepian Scale-Discretised Wavelets in Python. But the archive title is still SLEPLET.

[paddyroddy]

Ah, thanks @Saran-nns, I get it now. All updated!

[paddyroddy]

Realised I forgot to update the Zenodo citation in the paper. Have fixed in v1.3.6 https://zenodo.org/record/7835860.

[vissarion]

@editorialbot set https://zenodo.org/record/7835860 as archive

[editorialbot]

Done! Archive is now [ https://zenodo.org/record/7835860](https://doi.org/ https://zenodo.org/record/7835860)

[vissarion]

@editorialbot set v1.3.6 as version

[editorialbot]

Done! version is now v1.3.6

[vissarion]

@editorialbot recommend-accept

[editorialbot]

Attempting dry run of processing paper acceptance...

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/TSP.2016.2646668 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1002/j.1538-7305.1961.tb03977.x is OK
- 10.1002/j.1538-7305.1962.tb03279.x is OK
- 10.1051/0004-6361/201220729 is OK
- 10.1145/3134472.3134497 is OK
- 10.1109/TSP.2011.2166394 is OK
- 10.1109/LSP.2021.3050961 is OK
- 10.1109/TSP.2022.3233309 is OK
- 10.5281/zenodo.7268074 is OK
- 10.1137/S0036144504445765 is OK
- 10.5281/zenodo.4085210 is OK
- 10.1002/j.1538-7305.1961.tb03976.x is OK
- 10.1111/j.1365-2966.2008.13448.x is OK
- 10.1029/2018GC007529 is OK

MISSING DOIs

- Errored finding suggestions for "Slepian Wavelets for the Analysis of Incomplete Da...", please try later

INVALID DOIs

- None

[editorialbot]

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4151, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

[danielskatz]

@vissarion - please set the archive to the DOI - note that link above from editorialbot isn't one that works

I'll proofread the paper later and continue the process

[danielskatz]

@editorialbot set 10.5281/zenodo.7835860 as archive

@vissarion - nvm, I'll just do this while I'm proofreading...

[editorialbot]

Done! Archive is now 10.5281/zenodo.7835860

[danielskatz]

@paddyroddy - I'm suggesting some changes in https://github.com/astro-informatics/sleplet/pull/142 Please merge this, or let me know what you disagree with.

In addition, I have a suggestion: In the paper, lines 29-31 seem redundant with the previous part of that section. Can these lines be removed (29) and/or merged (30-31)?

Once you've decided on and made changes, please let me know, and we can continue the acceptance and publication process.

[paddyroddy]

I've made the changes @danielskatz

[danielskatz]

@editorialbot recommend-accept

[editorialbot]

Attempting dry run of processing paper acceptance...

[editorialbot]

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4155, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/TSP.2016.2646668 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1002/j.1538-7305.1961.tb03977.x is OK
- 10.1002/j.1538-7305.1962.tb03279.x is OK
- 10.1051/0004-6361/201220729 is OK
- 10.1145/3134472.3134497 is OK
- 10.1109/TSP.2011.2166394 is OK
- 10.1109/LSP.2021.3050961 is OK
- 10.1109/TSP.2022.3233309 is OK
- 10.5281/zenodo.7268074 is OK
- 10.1137/S0036144504445765 is OK
- 10.5281/zenodo.4085210 is OK
- 10.1002/j.1538-7305.1961.tb03976.x is OK
- 10.1111/j.1365-2966.2008.13448.x is OK
- 10.1029/2018GC007529 is OK

MISSING DOIs

- Errored finding suggestions for "Slepian Scale-Discretised Wavelets on Manifolds", please try later

INVALID DOIs

- None

[danielskatz]

@editorialbot accept

[editorialbot]

Doing it live! Attempting automated processing of paper acceptance...

[editorialbot]

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Roddy given-names: Patrick J. orcid: "https://orcid.org/0000-0002-6271-1700" doi: 10.5281/zenodo.7835860 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Roddy given-names: Patrick J. orcid: "https://orcid.org/0000-0002-6271-1700" date-published: 2023-04-20 doi: 10.21105/joss.05221 issn: 2475-9066 issue: 84 journal: Journal of Open Source Software publisher: name: Open Journals start: 5221 title: "SLEPLET: Slepian Scale-Discretised Wavelets in Python" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05221" volume: 8 title: "SLEPLET: Slepian Scale-Discretised Wavelets in Python" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

[editorialbot]

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

[editorialbot]

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

[editorialbot]

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

0. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4156
1. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05221
2. If everything looks good, then close this review issue.
3. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

[danielskatz]

Congratulations to @paddyroddy (Patrick James Roddy) on your work's publication!!

And thanks to @Saran-nns and @klb2 for reviewing, and to @vissarion for editing! We couldn't do this without your voluntary efforts

(note that the DOI is not yet resolving, so I'll leave this open until it does)

[danielskatz]

The DOI now resolves!

[editorialbot]

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05221/status.svg)](https://doi.org/10.21105/joss.05221)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05221">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05221/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05221/status.svg
   :target: https://doi.org/10.21105/joss.05221

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

• Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
• Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

[paddyroddy]

@editorialbot generate preprint

[editorialbot]

:page_facing_up: Preprint file created: Find it here in the Artifacts list :page_facing_up:

[paddyroddy]

Thanks for your hard work @danielskatz, @vissarion, @Saran-nns and @klb2!