[REVIEW]: LyceanEM: A python package for virtual prototyping of antenna arrays, time and frequency domain channel modelling

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@LyceanEM@arfon<!--end-editor-- Reviewers: @sasha-seneca, @craig-warren Archive: 10.5281/zenodo.8026567

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/618868c0e8d7e1f7ae6b9f0b4e1e5a2a"><img src="https://joss.theoj.org/papers/618868c0e8d7e1f7ae6b9f0b4e1e5a2a/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/618868c0e8d7e1f7ae6b9f0b4e1e5a2a/status.svg)](https://joss.theoj.org/papers/618868c0e8d7e1f7ae6b9f0b4e1e5a2a)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@sasha-seneca, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @arfon know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @sasha-seneca

📝 Checklist for @craig-warren

editorialbot commented 1 year ago

:wave: @openjournals/pe-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4299, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

kyleniemeyer commented 1 year ago

Hi @LyceanEM, a few things before publishing:

[x] remove the "These authors contributed equally." second footnote in the author section
[x] could you add that missing DOI? It does look correct for the conference paper.
[x] while you are in the references file, can you use first initial rather than your full name for the final reference? (meaning, "T. G. Pelham" rather than "Timothy G. Pelham")
[x] some minor typos: "This setup is show in Figure 5" on page 3, and an extraneous comma before "shows" in the paragraph explaining Figure 6 on page 4.

LyceanEM commented 1 year ago

@kyleniemeyer Thank you for your comments, I have now made the requested changes to the paper.

kyleniemeyer commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kyleniemeyer commented 1 year ago

@LyceanEM great, looks good to me!

kyleniemeyer commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 1 year ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Pelham given-names: Timothy G. orcid: "https://orcid.org/0000-0002-8085-1264" doi: 10.5281/zenodo.8026567 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Pelham given-names: Timothy G. orcid: "https://orcid.org/0000-0002-8085-1264" date-published: 2023-06-12 doi: 10.21105/joss.05234 issn: 2475-9066 issue: 86 journal: Journal of Open Source Software publisher: name: Open Journals start: 5234 title: "LyceanEM: A python package for virtual prototyping of antenna arrays, time and frequency domain channel modelling" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05234" volume: 8 title: "LyceanEM: A python package for virtual prototyping of antenna arrays, time and frequency domain channel modelling" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 1 year ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

editorialbot commented 1 year ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 1 year ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4301
Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05234
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

kyleniemeyer commented 1 year ago

Congratulations @LyceanEM on your article's publication in JOSS! If you haven't already, please consider signing up as a reviewer: https://reviewers.joss.theoj.org/join

Many thanks to @sasha-seneca and @craig-warren for reviewing this submission, and @arfon for editing.

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05234/status.svg)](https://doi.org/10.21105/joss.05234)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05234">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05234/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05234/status.svg
   :target: https://doi.org/10.21105/joss.05234

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

LyceanEM commented 1 year ago

Thank you @craig-warren, @kyleniemeyer, @arfon, @sasha-seneca. I have retweeted the announcement and added the citation file as suggested. Thank you for all your help, and I look forward to submitting future papers, and reviewing them!

openjournals / joss-reviews