openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
703 stars 36 forks source link

[REVIEW]: BridgeStan: Efficient in-memory access to the methods of a Stan model #5236

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@roualdes<!--end-author-handle-- (Edward Roualdes) Repository: https://github.com/roualdes/bridgestan Branch with paper.md (empty if default branch): joss Version: v2.1.2 Editor: !--editor-->@Nikoleta-v3<!--end-editor-- Reviewers: @salleuska, @saumil-sh Archive: 10.5281/zenodo.8169248

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/8ecf92ae523d5719bcc2b63ec254945d"><img src="https://joss.theoj.org/papers/8ecf92ae523d5719bcc2b63ec254945d/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/8ecf92ae523d5719bcc2b63ec254945d/status.svg)](https://joss.theoj.org/papers/8ecf92ae523d5719bcc2b63ec254945d)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@adity-om & @salleuska, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @Nikoleta-v3 know.

āœØ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest āœØ

Checklists

šŸ“ Checklist for @salleuska

šŸ“ Checklist for @saumil-sh

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Nikoleta-v3 commented 1 year ago

@editorialbot set v2.1.2 as version

editorialbot commented 1 year ago

Done! version is now v2.1.2

Nikoleta-v3 commented 1 year ago

@editorialbot set 10.5281/zenodo.8169248 as archive

editorialbot commented 1 year ago

Done! archive is now 10.5281/zenodo.8169248

Nikoleta-v3 commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Nikoleta-v3 commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago
Attempting dry run of processing paper acceptance...
editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 1 year ago

:wave: @openjournals/dsais-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4423, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

gkthiruvathukal commented 1 year ago

All appears to be in good shape here. I'm moving to accept. Now!

gkthiruvathukal commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 1 year ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Roualdes given-names: Edward A. orcid: "https://orcid.org/0000-0002-8757-3463" - family-names: Ward given-names: Brian orcid: "https://orcid.org/0000-0002-9841-3342" - family-names: Carpenter given-names: Bob orcid: "https://orcid.org/0000-0002-2433-9688" - family-names: Seyboldt given-names: Adrian orcid: "https://orcid.org/0000-0002-4239-4541" - family-names: Axen given-names: Seth D. orcid: "https://orcid.org/0000-0003-3933-8247" contact: - family-names: Roualdes given-names: Edward A. orcid: "https://orcid.org/0000-0002-8757-3463" doi: 10.5281/zenodo.8169248 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Roualdes given-names: Edward A. orcid: "https://orcid.org/0000-0002-8757-3463" - family-names: Ward given-names: Brian orcid: "https://orcid.org/0000-0002-9841-3342" - family-names: Carpenter given-names: Bob orcid: "https://orcid.org/0000-0002-2433-9688" - family-names: Seyboldt given-names: Adrian orcid: "https://orcid.org/0000-0002-4239-4541" - family-names: Axen given-names: Seth D. orcid: "https://orcid.org/0000-0003-3933-8247" date-published: 2023-07-22 doi: 10.21105/joss.05236 issn: 2475-9066 issue: 87 journal: Journal of Open Source Software publisher: name: Open Journals start: 5236 title: "BridgeStan: Efficient in-memory access to the methods of a Stan model" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05236" volume: 8 title: "`BridgeStan`: Efficient in-memory access to the methods of a Stan model" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 1 year ago

šŸ˜šŸ˜šŸ˜ šŸ‘‰ Toot for this paper šŸ‘ˆ šŸ˜šŸ˜šŸ˜

editorialbot commented 1 year ago

šŸšØšŸšØšŸšØ THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! šŸšØšŸšØšŸšØ

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4425
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05236
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! šŸŽ‰šŸŒˆšŸ¦„šŸ’ƒšŸ‘»šŸ¤˜

Any issues? Notify your editorial technical team...

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05236/status.svg)](https://doi.org/10.21105/joss.05236)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05236">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05236/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05236/status.svg
   :target: https://doi.org/10.21105/joss.05236

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: