editorialbot commented 1 year ago

Submitting author: @drcandacemakedamoore (Candace Makeda Moore) Repository: https://github.com/ReSurfEMG/ReSurfEMG Branch with paper.md (empty if default branch): Version: v0.1.3 Editor: !--editor-->@AJQuinn<!--end-editor-- Reviewers: @ixjlyons, @ajbaird Archive: 10.5281/zenodo.8429265

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/5f08d1f2bb717b7d05762296e37ded3d"><img src="https://joss.theoj.org/papers/5f08d1f2bb717b7d05762296e37ded3d/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/5f08d1f2bb717b7d05762296e37ded3d/status.svg)](https://joss.theoj.org/papers/5f08d1f2bb717b7d05762296e37ded3d)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@marcoghislieri & @ixjlyons, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @AJQuinn know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @ixjlyons

📝 Checklist for @ajbaird

AJQuinn commented 11 months ago

@editorialbot check references

editorialbot commented 11 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/S0921-884X(96)95190-5 is OK
- 10.1109/10.661154 is OK
- 10.1016/0013-4694(86)90163-X is OK
- 10.1046/j.1365-2842.1998.00242.x is OK
- 10.1007/s00421-010-1521-8 is OK
- 10.3758/s13428-020-01516-y is OK
- 10.21105/joss.04156 is OK

MISSING DOIs

- 10.1007/978-3-642-34546-3_71 may be a valid DOI for title: Towards Improving the Usability of Electromyographic Interfaces

INVALID DOIs

- None

wbaccinelli commented 11 months ago

@editorialbot generate pdf

editorialbot commented 11 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

wbaccinelli commented 11 months ago

@editorialbot check references

editorialbot commented 11 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/S0921-884X(96)95190-5 is OK
- 10.1109/10.661154 is OK
- 10.1016/0013-4694(86)90163-X is OK
- 10.1046/j.1365-2842.1998.00242.x is OK
- 10.1007/s00421-010-1521-8 is OK
- 10.1007/978-3-642-34546-3_71 is OK
- 10.3758/s13428-020-01516-y is OK
- 10.21105/joss.04156 is OK

MISSING DOIs

- None

INVALID DOIs

- None

wbaccinelli commented 11 months ago

@AJQuinn the DOI issue has now been fixed, thank you for helping us in doing this.

AJQuinn commented 11 months ago

Fantastic, thanks @wbaccinelli @drcandacemakedamoore

AJQuinn commented 11 months ago

Post-Review Checklist for Editor and Authors

Additional Author Tasks After Review is Complete

[x] Double check authors and affiliations (including ORCIDs)
[x] Make a release of the software with the latest changes from the review and post the version number here. This is the version that will be used in the JOSS paper.
[x] Archive the release on Zenodo/figshare/etc and post the DOI here.
[x] Make sure that the title and author list (including ORCIDs) in the archive match those in the JOSS paper.
[x] Make sure that the license listed for the archive is the same as the software license.

Editor Tasks Prior to Acceptance

[x] Read the text of the paper and offer comments/corrections (as either a list or a PR)
[x] Check the references in the paper for corrections (e.g. capitalization)
[x] Check that the archive title, author list, version tag, and the license are correct
[x] Set archive DOI with @editorialbot set <DOI here> as archive
[x] Set version with @editorialbot set <version here> as version
[x] Double check rendering of paper with @editorialbot generate pdf
[x] Specifically check the references with @editorialbot check references and ask author(s) to update as needed
[x] Recommend acceptance with @editorialbot recommend-accept

AJQuinn commented 11 months ago

I'll have a read through the paper and make any additional suggestions in a PR (will be minor if anything at all).

@drcandacemakedamoore could you double check authors and affiliations etc as well? Once that's confirmed we can work through the list above.

AJQuinn commented 11 months ago

Ok - I've put a few suggested paper tweaks in the PR above, please review and action these as you prefer.

Next step is to work through the 'Additional Author Tasks After Review is Complete' steps in the checklist above. Let me know if anything issues come up.

drcandacemakedamoore commented 11 months ago

@AJQuinn I finished all the tasks for post-review checklist for the author just now. We are on the just made release v0.1.3, archived on Zenodo, with correct license and with all author information and title verified everywhere. On behalf of everyone coding with the library now and in the future, I thank you for all your help.

AJQuinn commented 11 months ago

Fantastic - thanks @drcandacemakedamoore, Can you post a link to the repo and the DOI here? and could check the boxes in the author list here to confirm that you've done each step (sorry last request is a bit pedantic!)

Thanks again

drcandacemakedamoore commented 11 months ago

Fantastic - thanks @drcandacemakedamoore, Can you post a link to the repo and the DOI here? and could check the boxes in the author list here to confirm that you've done each step (sorry last request is a bit pedantic!)

Thanks again

I literally can't make more than one check-box check off in every browser I tried. I did all the check-box things though. The repo is https://github.com/resurfemg/resurfemg and the Zenodo DOI is

@wbaccinelli can you check off the check-boxes for author?

wbaccinelli commented 11 months ago

@drcandacemakedamoore @AJQuinn I am also not allowed to check the boxes.

AJQuinn commented 11 months ago

Ok, no problem @drcandacemakedamoore @wbaccinelli - confirmation in comment is fine in that case. I'll review the rest of the steps.

AJQuinn commented 11 months ago

@editorialbot set 10.5281/zenodo.8429265 as archive

editorialbot commented 11 months ago

Done! archive is now 10.5281/zenodo.8429265

AJQuinn commented 11 months ago

@editorialbot set v0.1.3 as version

editorialbot commented 11 months ago

Done! version is now v0.1.3

AJQuinn commented 11 months ago

@editorialbot generate pdf

editorialbot commented 11 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

AJQuinn commented 11 months ago

@editorialbot check references

editorialbot commented 11 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/S0921-884X(96)95190-5 is OK
- 10.1109/10.661154 is OK
- 10.1016/0013-4694(86)90163-X is OK
- 10.1046/j.1365-2842.1998.00242.x is OK
- 10.1007/s00421-010-1521-8 is OK
- 10.1007/978-3-642-34546-3_71 is OK
- 10.3758/s13428-020-01516-y is OK
- 10.21105/joss.04156 is OK

MISSING DOIs

- None

INVALID DOIs

- None

AJQuinn commented 11 months ago

This all looks good from my side. An Editor-in-Chief will do a final check to make sure I've not missed anything.

AJQuinn commented 11 months ago

@editorialbot recommend-accept

editorialbot commented 11 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 11 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/S0921-884X(96)95190-5 is OK
- 10.1109/10.661154 is OK
- 10.1016/0013-4694(86)90163-X is OK
- 10.1046/j.1365-2842.1998.00242.x is OK
- 10.1007/s00421-010-1521-8 is OK
- 10.1007/978-3-642-34546-3_71 is OK
- 10.3758/s13428-020-01516-y is OK
- 10.21105/joss.04156 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 11 months ago

:wave: @openjournals/bcm-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4696, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

AJQuinn commented 11 months ago

Hi @drcandacemakedamoore - I'm happy to recommend this paper to be accepted, pending a final Editor-in-Chief check. We can make any fix-ups they recommend if required.

Thanks for your submission to JOSS, and thanks to @ixjlyons and @ajbaird for reviews!

Kevin-Mattheus-Moerman commented 11 months ago

@drcandacemakedamoore I am the EiC on this track and here to help with final steps. I have checked this review, the paper, the repository, and the archive. Most seems in order. I do have the below points which needs your attention.

[x] Please amend the archive title as it still does not match the paper title
[x] If you can, please add a town/city name to the second affiliation.
[x] Recommendation: The citation Londral et al. does not have a DOI, but perhaps you can consider adding the URL by adding this to the big entry: url = "https://www.raco.cat/index.php/JACCES/article/view/315915"

ElineOppersma commented 11 months ago

@editorialbot generate pdf

editorialbot commented 11 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

ElineOppersma commented 11 months ago

@Kevin-Mattheus-Moerman All 3 tasks have been adjusted according to the checklist, but I am not able to check the boxes. Please let me know if there is anything else we need to do to proceed.

Kevin-Mattheus-Moerman commented 11 months ago

@ElineOppersma @drcandacemakedamoore great thanks. All looks good now.

Kevin-Mattheus-Moerman commented 11 months ago

@editorialbot accept

editorialbot commented 11 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 11 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Moore given-names: Candace Makeda orcid: "https://orcid.org/0000-0003-1672-7565" - family-names: Baccinelli given-names: Walter orcid: "https://orcid.org/0000-0001-8888-4792" - family-names: Sivokon given-names: Oleg - family-names: Warnaar given-names: Robertus Simon Petrus orcid: "https://orcid.org/0000-0001-9443-4069" - family-names: Oppersma given-names: Eline orcid: "https://orcid.org/0000-0002-0150-306X" doi: 10.5281/zenodo.8429265 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Moore given-names: Candace Makeda orcid: "https://orcid.org/0000-0003-1672-7565" - family-names: Baccinelli given-names: Walter orcid: "https://orcid.org/0000-0001-8888-4792" - family-names: Sivokon given-names: Oleg - family-names: Warnaar given-names: Robertus Simon Petrus orcid: "https://orcid.org/0000-0001-9443-4069" - family-names: Oppersma given-names: Eline orcid: "https://orcid.org/0000-0002-0150-306X" date-published: 2023-10-23 doi: 10.21105/joss.05251 issn: 2475-9066 issue: 90 journal: Journal of Open Source Software publisher: name: Open Journals start: 5251 title: "ReSurfEMG: A Python library for preprocessing and analysis of respiratory EMG." type: article url: "https://joss.theoj.org/papers/10.21105/joss.05251" volume: 8 title: "ReSurfEMG: A Python library for preprocessing and analysis of respiratory EMG." ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 11 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 11 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4715
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05251
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

Kevin-Mattheus-Moerman commented 11 months ago

@drcandacemakedamoore congratulations on this JOSS publication!

Thanks for editing @AJQuinn!

And a special thank you to the reviewers: @ixjlyons, @ajbaird

editorialbot commented 11 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05251/status.svg)](https://doi.org/10.21105/joss.05251)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05251">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05251/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05251/status.svg
   :target: https://doi.org/10.21105/joss.05251

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews

[REVIEW]: ReSurfEMG: A Python library for preprocessing and analysis of respiratory EMG. #5251

Status

Reviewer instructions & questions

Checklists

Post-Review Checklist for Editor and Authors

Additional Author Tasks After Review is Complete

Editor Tasks Prior to Acceptance