[REVIEW]: Diart: A Python Library for Real-Time Speaker Diarization

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@juanmc2005@Fei-Tao<!--end-editor-- Reviewers: @sneakers-the-rat, @mensisa Archive: 10.5281/zenodo.12510278

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/cc9807c6de75ea4c29025c7bd0d31996"><img src="https://joss.theoj.org/papers/cc9807c6de75ea4c29025c7bd0d31996/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/cc9807c6de75ea4c29025c7bd0d31996/status.svg)](https://joss.theoj.org/papers/cc9807c6de75ea4c29025c7bd0d31996)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@sneakers-the-rat & @mensisa, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @Fei-Tao know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @mensisa

📝 Checklist for @sneakers-the-rat

Fei-Tao commented 4 months ago

Hi @juanmc2005, can you check the Post-Review Checklist above? Please Archive the release on Zenodo/figshare/etc and post the DOI here after you complete it. Please fix the references for this submission. Thanks for your time.

juanmc2005 commented 3 months ago

@editorialbot check references

editorialbot commented 3 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/ICASSP40776.2020.9052974 is OK
- 10.1145/3292500.3330701 is OK
- 10.1109/ASRU51503.2021.9688044 is OK
- 10.1109/CVPR52688.2022.01842 is OK

MISSING DOIs

- None

INVALID DOIs

- None

juanmc2005 commented 3 months ago

Hi @Fei-Tao, I've just published the latest release (0.9.1) to Zenodo. Here's the DOI: 10.5281/zenodo.12510278.

I already went through the checklist and everything looks good from my side. Thanks!

crvernon commented 3 months ago

@Fei-Tao - it looks like this is about ready to go and it would be great to push this across the finish line. Please check on this one and let me know when you have finished your assessment.

Fei-Tao commented 3 months ago

@crvernon sure. thanks for the reminder. I will get to it this weekend.

Fei-Tao commented 3 months ago

@editorialbot generate pdf

editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Fei-Tao commented 3 months ago

@editorialbot set 10.5281/zenodo.12510278 as archive

editorialbot commented 3 months ago

Done! archive is now 10.5281/zenodo.12510278

Fei-Tao commented 3 months ago

@editorialbot check references

editorialbot commented 3 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/ICASSP40776.2020.9052974 is OK
- 10.1145/3292500.3330701 is OK
- 10.1109/ASRU51503.2021.9688044 is OK
- 10.1109/CVPR52688.2022.01842 is OK

MISSING DOIs

- None

INVALID DOIs

- None

Fei-Tao commented 3 months ago

@editorialbot set v0.9.1 as version

editorialbot commented 3 months ago

Done! version is now v0.9.1

Fei-Tao commented 3 months ago

@editorialbot recommend-accept

editorialbot commented 3 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 3 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/ICASSP40776.2020.9052974 is OK
- 10.1145/3292500.3330701 is OK
- 10.1109/ASRU51503.2021.9688044 is OK
- 10.1109/CVPR52688.2022.01842 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 3 months ago

:wave: @openjournals/dsais-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5554, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

Fei-Tao commented 3 months ago

Hi @crvernon, this submission looks good to me now. Can you take it from here? Thanks for your time.

crvernon commented 3 months ago

🔍 checking out the following:

[x] reviewer checklists are completed or addressed
[x] version set
[x] archive set
[x] archive names (including order) and title in archive matches those specified in the paper
[x] archive uses the same license as the repo and is OSI approved as open source
[x] archive DOI and version match or redirect to those set by editor in review thread
[x] paper is error free - grammar and typos
[x] paper is error free - test links in the paper and bib
[x] paper is error free - refs preserve capitalization where necessary
[x] paper is error free - no invalid refs without justification

crvernon commented 3 months ago

:wave: @juanmc2005 - I just have the following few things I need you to address before I move to accept this publication:

[x] The version specified in your Zenodo archive (v1) does not match the version decalared in the review thread (v0.9.1) see https://zenodo.org/records/12510278. Please edit this to match.
[x] The end of the "Summary" section in the paper is abrupt and never discusses the introduction of your proposed solution. I would state something like the following as a last sentence in the "Summary" section. "We introduce Diart as Python package to efficiently conduct real-time speaker diarization."

Thanks!

crvernon commented 3 months ago

@juanmc2005 just pinging you again on the above.

juanmc2005 commented 3 months ago

@crvernon I just addressed the changes you requested

crvernon commented 3 months ago

@editorialbot generate pdf

editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

crvernon commented 3 months ago

@editorialbot accept

editorialbot commented 3 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 3 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Coria given-names: Juan Manuel orcid: "https://orcid.org/0000-0002-5035-147X" - family-names: Bredin given-names: Hervé orcid: "https://orcid.org/0000-0002-3739-925X" - family-names: Ghannay given-names: Sahar orcid: "https://orcid.org/0000-0002-7531-2522" - family-names: Rosset given-names: Sophie orcid: "https://orcid.org/0000-0002-6865-4989" - family-names: Zaouk given-names: Khaled - family-names: Fruend given-names: Ingo orcid: "https://orcid.org/0000-0003-4594-1763" - family-names: Higy given-names: Bertrand orcid: "https://orcid.org/0000-0002-8198-8676" - family-names: Kesari given-names: Amit - family-names: Thakkar given-names: Yagna contact: - family-names: Coria given-names: Juan Manuel orcid: "https://orcid.org/0000-0002-5035-147X" doi: 10.5281/zenodo.12510278 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Coria given-names: Juan Manuel orcid: "https://orcid.org/0000-0002-5035-147X" - family-names: Bredin given-names: Hervé orcid: "https://orcid.org/0000-0002-3739-925X" - family-names: Ghannay given-names: Sahar orcid: "https://orcid.org/0000-0002-7531-2522" - family-names: Rosset given-names: Sophie orcid: "https://orcid.org/0000-0002-6865-4989" - family-names: Zaouk given-names: Khaled - family-names: Fruend given-names: Ingo orcid: "https://orcid.org/0000-0003-4594-1763" - family-names: Higy given-names: Bertrand orcid: "https://orcid.org/0000-0002-8198-8676" - family-names: Kesari given-names: Amit - family-names: Thakkar given-names: Yagna date-published: 2024-07-07 doi: 10.21105/joss.05266 issn: 2475-9066 issue: 99 journal: Journal of Open Source Software publisher: name: Open Journals start: 5266 title: "Diart: A Python Library for Real-Time Speaker Diarization" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05266" volume: 9 title: "Diart: A Python Library for Real-Time Speaker Diarization" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 3 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 3 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5582
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05266
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

crvernon commented 3 months ago

🥳 Congratulations on your new publication @juanmc2005! Many thanks to @Fei-Tao for editing and @sneakers-the-rat and @mensisa for your time, hard work, and expertise!! JOSS wouldn't be able to function nor succeed without your efforts.

Please consider becoming a reviewer for JOSS if you are not already: https://reviewers.joss.theoj.org/join

editorialbot commented 3 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05266/status.svg)](https://doi.org/10.21105/joss.05266)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05266">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05266/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05266/status.svg
   :target: https://doi.org/10.21105/joss.05266

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

juanmc2005 commented 3 months ago

Thank you all!

openjournals / joss-reviews