openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
703 stars 36 forks source link

[PRE REVIEW]: sptotal: an R package for predicting totals and weighted sums from spatial data #5283

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@highamm<!--end-author-handle-- (Matt Higham) Repository: https://github.com/highamm/sptotal Branch with paper.md (empty if default branch): Version: 1.0.1 Editor: !--editor-->@fabian-s<!--end-editor-- Reviewers: @Athene-ai, @garret-rc, @garretrc Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/30a8945e4138d482c484e4f9b7ce2b7a"><img src="https://joss.theoj.org/papers/30a8945e4138d482c484e4f9b7ce2b7a/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/30a8945e4138d482c484e4f9b7ce2b7a/status.svg)](https://joss.theoj.org/papers/30a8945e4138d482c484e4f9b7ce2b7a)

Author instructions

Thanks for submitting your paper to JOSS @highamm. Currently, there isn't a JOSS editor assigned to your paper.

@highamm if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.07 s (1336.4 files/s, 182057.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            46           1450            180           6282
R                               29            417           1118           1194
XML                              3              0              2            606
CSS                              3             98             52            442
JavaScript                       4             64             34            266
Markdown                         4            103              0            214
Rmd                              2            176            325            166
YAML                             6             27             12            139
TeX                              1             10              0             98
SVG                              1              0              1             11
-------------------------------------------------------------------------------
SUM:                            99           2345           1724           9418
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 1242

editorialbot commented 1 year ago

Failed to discover a valid open source license

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1371/journal.pone.0282524 may be a valid DOI for title: spmodel: Spatial statistical modeling and prediction in R
- 10.32614/rj-2018-009 may be a valid DOI for title: Simple features for R: standardized support for spatial vector data.
- 10.1080/11956860.2002.11682701 may be a valid DOI for title: Sampling and geostatistics for spatial data
- 10.1371/journal.pone.0059129 may be a valid DOI for title: A comparison of the spatial linear model to nearest neighbor (k-NN) methods for forestry applications
- 10.1037/e471672008-001 may be a valid DOI for title: Discriminatory analysis: nonparametric discrimination, consistency properties
- 10.1007/s10651-007-0035-y may be a valid DOI for title: Spatial methods for plot-based sampling of wildlife populations
- 10.1016/j.cageo.2004.03.012 may be a valid DOI for title: Multivariable geostatistics in S: the gstat package

INVALID DOIs

- None
kthyng commented 1 year ago

Hi @highamm and thanks for your submission! It is relatively small – close to our scope query level of 1000 LOC – so I'm going to ping the editorial board to take a look. This will take 1-2 weeks. Thanks for your patience.

kthyng commented 1 year ago

@editorialbot query scope

editorialbot commented 1 year ago

Submission flagged for editorial review.

highamm commented 1 year ago

Hello @kthyng and thank you for the update! If there is any clarifying information that you need from me, just let me know. Have a good day!

kthyng commented 1 year ago

Hi again @highamm! We have finished the scope review and are good to move forward. I'll see about finding an editor now.

kthyng commented 1 year ago

Hi @fabian-s! Would you be able to edit this submission?

kthyng commented 1 year ago

@editorialbot invite @fabian-s as editor

editorialbot commented 1 year ago

Invitation to edit this submission sent!

fabian-s commented 1 year ago

sure!

fabian-s commented 1 year ago

@editorialbot add fabian-s as editor

editorialbot commented 1 year ago

Assigned! fabian-s is now the editor

fabian-s commented 1 year ago

Hi @highamm, i'll guide this paper through the review process. While I try to rustle up some reviewers, you could already start adding the missing DOIs the bot complains about :wink:

fabian-s commented 1 year ago

:wave: @trashbirdecology & @garretrc

Would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

fabian-s commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

highamm commented 1 year ago

Thank you @kthyng and @fabian-s for your help with getting this started.

@fabian-s I have added the missing doi's and I will get started working improving the testing coverage and replacing the 1:n_iter iterators mentioned in highamm/sptotal#7

Thank you both again for your time!

trashbirdecology commented 1 year ago

Apologies but I have zero bandwidth to the review paper nor the software right now.

On Tue, Apr 11, 2023 at 1:20 PM Matt Higham @.***> wrote:

Thank you @kthyng https://github.com/kthyng and @fabian-s https://github.com/fabian-s for your help with getting this started.

@fabian-s https://github.com/fabian-s I have added the missing doi's and I will get started working improving the testing coverage and replacing the 1:n_iter iterators mentioned in highamm/sptotal#7 https://github.com/highamm/sptotal/issues/7

Thank you both again for your time!

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/5283#issuecomment-1503804061, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACL2TNLM73K6QBGVX7NJSB3XAWHF7ANCNFSM6AAAAAAWBJLVGI . You are receiving this because you were mentioned.Message ID: @.***>

fabian-s commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1371/journal.pone.0282524 is OK
- 10.32614/rj-2018-009 is OK
- 10.1080/11956860.2002.11682701 is OK
- 10.1111/2041-210X.13919 is OK
- 10.1371/journal.pone.0059129 is OK
- 10.1037/e471672008-001 is OK
- 10.1007/s10651-007-0035-y is OK
- 10.1016/j.cageo.2004.03.012 is OK

MISSING DOIs

- None

INVALID DOIs

- None
fabian-s commented 1 year ago

:wave: @potterzot @Athene-ai @garretrc

Would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

Athene-ai commented 1 year ago

Hi!

Yes. I am interested

https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Privo di virus.www.avast.com https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Wed, 12 Apr 2023 at 11:00, Fabian Scheipl @.***> wrote:

wave @potterzot https://github.com/potterzot @Athene-ai https://github.com/Athene-ai @garretrc https://github.com/garretrc

Would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/5283#issuecomment-1504914440, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANGYEVGVNAUWKV33ZA7WXSLXAZVLNANCNFSM6AAAAAAWBJLVGI . You are receiving this because you were mentioned.Message ID: @.***>

fabian-s commented 1 year ago

@editorialbot add @Athene-ai as reviewer

ty Daniela!

editorialbot commented 1 year ago

Can't add reviewers: There is no editor assigned yet

fabian-s commented 1 year ago

@editorialbot add fabian-s as editor

editorialbot commented 1 year ago

Assigned! fabian-s is now the editor

fabian-s commented 1 year ago

@editorialbot add @Athene-ai as reviewer

editorialbot commented 1 year ago

Can't add reviewers: There is no editor assigned yet

fabian-s commented 1 year ago

@kthyng the bot seems confused... wat do?

EDIT: could you try adding me as editor and Athene-ai as reviewer?

kthyng commented 1 year ago

@editorialbot add @Athene-ai as reviewer

editorialbot commented 1 year ago

Can't add reviewers: There is no editor assigned yet

kthyng commented 1 year ago

@editorialbot add fabian-s as editor

editorialbot commented 1 year ago

Assigned! fabian-s is now the editor

kthyng commented 1 year ago

@editorialbot add @Athene-ai as reviewer

editorialbot commented 1 year ago

Can't add reviewers: There is no editor assigned yet

kthyng commented 1 year ago

@openjournals/dev Could you take a look at this? We seem to be caught in a loop where we can't properly assign anyone.

garretrc commented 1 year ago

I can review!

fabian-s commented 1 year ago

thx @garretrc

fabian-s commented 1 year ago

@kthyng we could try starting the review issue, maybe adding reviewers will work in a new issue....?

xuanxu commented 1 year ago

I've found the problem, editorialbot does not recognize fabian-s as a GitHub user (is currently listed in the issue body missing the @) Running @editorialbot add @fabian-s as editor should fix it.

fabian-s commented 1 year ago

@editorialbot add @fabian-s as editor

editorialbot commented 1 year ago

Assigned! @fabian-s is now the editor

fabian-s commented 1 year ago

@editorialbot add @Athene-ai as reviewer

editorialbot commented 1 year ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

fabian-s commented 1 year ago

@editorialbot add @Athene-ai as reviewer