[REVIEW]: CeRULEo: Comprehensive utilitiEs for Remaining Useful Life Estimation methOds

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@lucianolorenti@matthewfeickert<!--end-editor-- Reviewers: @AnnikaStein, @ulf1 Archive: 10.5281/zenodo.8187300

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/c879c234d7741885576ddc682416b41f"><img src="https://joss.theoj.org/papers/c879c234d7741885576ddc682416b41f/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/c879c234d7741885576ddc682416b41f/status.svg)](https://joss.theoj.org/papers/c879c234d7741885576ddc682416b41f)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@AnnikaStein & @ulf1 & @Athene-ai, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @matthewfeickert know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @AnnikaStein

📝 Checklist for @Athene-ai

📝 Checklist for @ulf1

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/tii.2014.2349359 is OK
- 10.1109/phm.2008.4711422 is OK
- 10.1016/j.ress.2017.11.021 is OK
- 10.3233/atde210095 is OK
- 10.1007/s10489-021-03004-y is OK
- 10.1109/rams.2015.7105079 is OK
- 10.48550/arXiv.1907.12207 is OK
- 10.3390/math9233137 is OK
- 10.1109/icit.2019.8754956 is OK
- 10.1016/j.asoc.2020.106113 is OK
- 10.1016/j.conengprac.2021.104969 is OK
- 10.48550/arXiv.1201.0490 is OK
- 10.48550/arXiv.1603.04467 is OK
- 10.1016/j.neucom.2018.03.067 is OK
- 10.1080/00207543.2022.2154403 is OK
- 10.1016/j.grets.2023.100020 is OK

MISSING DOIs

- None

INVALID DOIs

- None

lucianolorenti commented 1 year ago

Hi @matthewfeickert

I updated the missing DOIs and created a new release that is stored v2.0.5 that is stored in zenodo with the following DOI 10.5281/zenodo.8187300

matthewfeickert commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

matthewfeickert commented 1 year ago

One final little fix @lucianolorenti! I just opened up https://github.com/lucianolorenti/ceruleo/pull/31 for this as the current paper url render is https://github.com/nasa/prog/_models which (correctly) 404s.

(Also apologies for the week delay — I'm currently moving house.)

lucianolorenti commented 1 year ago

@matthewfeickert Thank you for the fix!

Merged!

matthewfeickert commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/tii.2014.2349359 is OK
- 10.1109/phm.2008.4711422 is OK
- 10.1016/j.ress.2017.11.021 is OK
- 10.3233/atde210095 is OK
- 10.1007/s10489-021-03004-y is OK
- 10.1109/rams.2015.7105079 is OK
- 10.48550/arXiv.1907.12207 is OK
- 10.3390/math9233137 is OK
- 10.1109/icit.2019.8754956 is OK
- 10.1016/j.asoc.2020.106113 is OK
- 10.1016/j.conengprac.2021.104969 is OK
- 10.48550/arXiv.1201.0490 is OK
- 10.48550/arXiv.1603.04467 is OK
- 10.1016/j.neucom.2018.03.067 is OK
- 10.1080/00207543.2022.2154403 is OK
- 10.1016/j.grets.2023.100020 is OK

MISSING DOIs

- None

INVALID DOIs

- None

matthewfeickert commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

matthewfeickert commented 1 year ago

@editorialbot set v2.0.5 as version

editorialbot commented 1 year ago

Done! version is now v2.0.5

matthewfeickert commented 1 year ago

@editorialbot set 10.5281/zenodo.8187300 as archive

editorialbot commented 1 year ago

Done! archive is now 10.5281/zenodo.8187300

matthewfeickert commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago

Attempting dry run of processing paper acceptance...

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/tii.2014.2349359 is OK
- 10.1109/phm.2008.4711422 is OK
- 10.1016/j.ress.2017.11.021 is OK
- 10.3233/atde210095 is OK
- 10.1007/s10489-021-03004-y is OK
- 10.1109/rams.2015.7105079 is OK
- 10.48550/arXiv.1907.12207 is OK
- 10.3390/math9233137 is OK
- 10.1109/icit.2019.8754956 is OK
- 10.1016/j.asoc.2020.106113 is OK
- 10.1016/j.conengprac.2021.104969 is OK
- 10.48550/arXiv.1201.0490 is OK
- 10.48550/arXiv.1603.04467 is OK
- 10.1016/j.neucom.2018.03.067 is OK
- 10.1080/00207543.2022.2154403 is OK
- 10.1016/j.grets.2023.100020 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 1 year ago

:wave: @openjournals/pe-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4467, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

kyleniemeyer commented 1 year ago

Hello @lucianolorenti, I'm doing some final checks before accepting.

Can you modify the metadata for your Zenodo archive so that the author list matches the paper?

lucianolorenti commented 1 year ago

Oh i didn't see that. Fixed it

kyleniemeyer commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 1 year ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Lorenti given-names: Luciano orcid: "https://orcid.org/0000-0002-4041-449X" - family-names: Susto given-names: Gian Antonio orcid: "https://orcid.org/0000-0001-5739-9639" contact: - family-names: Lorenti given-names: Luciano orcid: "https://orcid.org/0000-0002-4041-449X" doi: 10.5281/zenodo.8187300 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Lorenti given-names: Luciano orcid: "https://orcid.org/0000-0002-4041-449X" - family-names: Susto given-names: Gian Antonio orcid: "https://orcid.org/0000-0001-5739-9639" date-published: 2023-08-10 doi: 10.21105/joss.05294 issn: 2475-9066 issue: 88 journal: Journal of Open Source Software publisher: name: Open Journals start: 5294 title: "CeRULEo: Comprehensive utilitiEs for Remaining Useful Life Estimation methOds" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05294" volume: 8 title: "CeRULEo: Comprehensive utilitiEs for Remaining Useful Life Estimation methOds" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 1 year ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 1 year ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4469
Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05294
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

matthewfeickert commented 1 year ago

Can you modify the metadata for your Zenodo archive so that the author list matches the paper?

Ah thanks very much for catching that @kyleniemeyer!

Congratulations on your publication, @lucianolorenti! Well done!

Many thanks to @AnnikaStein and @ulf1 for their thorough reviews.

kyleniemeyer commented 1 year ago

Congratulations @lucianolorenti on your article's publication in JOSS! Please consider volunteering to review for us if you haven't already.

Thanks to @AnnikaStein and @ulf1 for reviewing this submission, and @matthewfeickert for editing.

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05294/status.svg)](https://doi.org/10.21105/joss.05294)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05294">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05294/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05294/status.svg
   :target: https://doi.org/10.21105/joss.05294

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

gianantonio commented 1 year ago

Dear editors and reviewers,

thank you very much for handling the reviewing process of our work.

We realized that financial acknowledgements should be modified and we would like to ask for a post-publication update to the paper.

If possible the ack should be as follow: "This work was partially carried out within the MICS (Made in Italy – Circular and Sustainable) Extended Partnership and received funding from Next-GenerationEU (Italian PNRR – M4 C2, Invest 1.3 – D.D. 1551.11-10-2022, PE00000004). Moreover this study was also partially carried out within the PNRR research activities of the consortium iNEST (Interconnected North-Est Innovation Ecosystem) funded by the European Union Next-GenerationEU (Piano Nazionale di Ripresa e Resilienza (PNRR) – Missione 4 Componente 2, Investimento 1.5 – D.D. 1058 23/06/2022, ECS00000043). This work was also co-funded by the European Union in the context of the Horizon Europe project 'AIMS5.0 - Artificial Intelligence in Manufacturing leading to Sustainability and Industry5.0' Grant agreement ID: 101112089."

Thank you for you support!

kyleniemeyer commented 1 year ago

@gianantonio if you can update the paper source with that acknowledgment, I can reprocess the final PDF.

gianantonio commented 1 year ago

i've updated the paper! thanks for the help!

kyleniemeyer commented 1 year ago

@editorialbot reaccept

editorialbot commented 1 year ago

Rebuilding paper!

editorialbot commented 1 year ago

🌈 Paper updated!

New PDF and metadata files :point_right: https://github.com/openjournals/joss-papers/pull/4492

kyleniemeyer commented 1 year ago

OK @gianantonio it looks like the paper is correctly updated now.

openjournals / joss-reviews