openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
719 stars 38 forks source link

[PRE REVIEW]: TauFactor 2: A GPU accelerated python tool for microstructural analysis #5306

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@stke9<!--end-author-handle-- (Steven Kench) Repository: https://github.com/tldr-group/taufactor Branch with paper.md (empty if default branch): Joss-paper-revisions Version: v1.0.0 Editor: !--editor-->@zhubonan<!--end-editor-- Reviewers: @alexsquires, @ma-sadeghi Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/c2922e47173eafba702a8a755f97c3b4"><img src="https://joss.theoj.org/papers/c2922e47173eafba702a8a755f97c3b4/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/c2922e47173eafba702a8a755f97c3b4/status.svg)](https://joss.theoj.org/papers/c2922e47173eafba702a8a755f97c3b4)

Author instructions

Thanks for submitting your paper to JOSS @stke9. Currently, there isn't a JOSS editor assigned to your paper.

@stke9 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.06 s (636.0 files/s, 47534.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          10            239            304            988
Markdown                         8            177              0            372
TeX                              1             13              0            188
YAML                             6             18             35             81
make                             2             24              6             75
DOS Batch                        1              8              1             27
INI                              1              4              3             20
reStructuredText                 5              3             17              7
TOML                             1              0              0              6
-------------------------------------------------------------------------------
SUM:                            35            486            366           1764
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 1172

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1051/0004-6361/201629272 is OK
- 10.1051/0004-6361/201322068 is OK

MISSING DOIs

- 10.21105/joss.01296 may be a valid DOI for title: PoreSpy: A python toolkit for quantitative analysis of porous media images
- 10.1016/j.softx.2021.100729 may be a valid DOI for title: Openimpala: Open source image based parallisable linear algebra solver
- 10.1016/j.softx.2016.09.002 may be a valid DOI for title: TauFactor: An open-source application for calculating tortuosity factors from tomographic data
- 10.1016/s1386-5056(98)00163-4 may be a valid DOI for title: Measurement and classification of retinal vascular tortuosity
- 10.1111/gwat.12406 may be a valid DOI for title: Estimating tortuosity coefficients based on hydraulic conductivity
- 10.1149/2.0231803jes may be a valid DOI for title: Tortuosity of battery electrodes: validation of impedance-derived values and critical comparison with 3D tomography
- 10.1002/aenm.202370009 may be a valid DOI for title: Fusion of Complementary 2D and 3D Mesostructural Datasets Using Generative Adversarial Networks (Adv. Energy Mater. 2/2023)
- 10.1038/s41597-022-01744-1 may be a valid DOI for title: MicroLib: A library of 3D microstructures generated from 2D micrographs using SliceGAN
- 10.1038/s41524-020-00386-4 may be a valid DOI for title: The electrode tortuosity factor: why the conventional tortuosity factor is not well suited for quantifying transport in porous Li-ion battery electrodes and what to use instead
- 10.1016/j.electacta.2017.07.152 may be a valid DOI for title: Simulated impedance of diffusion in porous media
- 10.1016/j.coche.2016.02.006 may be a valid DOI for title: On the origin and application of the Bruggeman correlation for analysing transport phenomena in electrochemical systems

INVALID DOIs

- None
stke9 commented 1 year ago

Hi, here's a list of potential reviewers, let me know if more required: timokoch, rocsg, msdaldo, sthavishtha, mbagheri20, hvonwah, ranzhengcode, jeremylt, kingyin3613. The latest version of the paper is in the branch Joss-paper-revisions, not main, as we realised we had to make corrections. Let us know if anything else required!

stke9 commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Kevin-Mattheus-Moerman commented 1 year ago

@stke9 thanks for this submission. I am the AEiC and here to help with the initial steps. For the moment, can you please work on the following:

Kevin-Mattheus-Moerman commented 1 year ago

@stke9 I have waitlisted this work for the moment since the editors in this domain are all handling several other submissions. We will assign an editor once one becomes available.

Kevin-Mattheus-Moerman commented 1 year ago

@zhubonan do you think that, if you'd be available, you could help edit this work?

zhubonan commented 1 year ago

Yes, I am happy to edit this work

stke9 commented 1 year ago

Great, thanks both. I updated the DOIs and UK typo

stke9 commented 1 year ago

@editorialbot commands

editorialbot commented 1 year ago

Hello @stke9, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers
stke9 commented 1 year ago

@editorialbot set Joss-paper-revisions as branch

editorialbot commented 1 year ago

Done! branch is now Joss-paper-revisions

stke9 commented 1 year ago

@editorialbot generate pdf

stke9 commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1051/0004-6361/201629272 is OK
- 10.1051/0004-6361/201322068 is OK
- 10.1051/0004-6361/201629272 is OK
- 10.1016/j.softx.2021.100729 is OK
- 10.1016/j.softx.2016.09.002 is OK
- 10.1016/s1386-5056(98)00163-4 is OK
- 10.1111/gwat.12406 is OK
- 10.1149/2.0231803jes is OK
- 10.1002/aenm.202370009 is OK
- 10.1038/s41597-022-01744-1 is OK
- 10.1038/s41524-020-00386-4 is OK
- 10.1016/j.electacta.2017.07.152 is OK
- 10.1016/j.coche.2016.02.006 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

zhubonan commented 1 year ago

@editorialbot assign me as editor

editorialbot commented 1 year ago

Assigned! @zhubonan is now the editor

zhubonan commented 1 year ago

@alexsquires are you OK to review this one?

zhubonan commented 1 year ago

Hello @tomtranter and @ma-sadeghi, this package seems to be in your area of expertise. Would you be happy to review it?

ma-sadeghi commented 1 year ago

@zhubonan Sure, I'd be happy to.

TomTranter commented 1 year ago

@zhubonan it's a conflict for me as I know the authors very well

alexsquires commented 1 year ago

@zhubonan I can review. After we discussed in person I just forgot to comment on the issue to confirm.

zhubonan commented 1 year ago

@zhubonan it's a conflict for me as I know the authors very well

I see, thanks for letting me know!

zhubonan commented 1 year ago

@editorialbot add @alexsquires as reviewer

editorialbot commented 1 year ago

@alexsquires added to the reviewers list!

zhubonan commented 1 year ago

@editorialbot add @ma-sadeghi as reviewer

editorialbot commented 1 year ago

@ma-sadeghi added to the reviewers list!

zhubonan commented 1 year ago

@editorialbot start review

editorialbot commented 1 year ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/5358.