openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[PRE REVIEW]: lczexplore : an R package to explore Local Climate Zone classifications #5331

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@MGousseff<!--end-author-handle-- (Matthieu Gousseff) Repository: https://github.com/orbisgis/lczexplore Branch with paper.md (empty if default branch): master Version: 0.0.1 Editor: !--editor-->@martinfleis<!--end-editor-- Reviewers: @matthiasdemuzere, @wcjochem Managing EiC: Olivia Guest

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/76fbd3ed47b537f386a892f0270ea5f4"><img src="https://joss.theoj.org/papers/76fbd3ed47b537f386a892f0270ea5f4/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/76fbd3ed47b537f386a892f0270ea5f4/status.svg)](https://joss.theoj.org/papers/76fbd3ed47b537f386a892f0270ea5f4)

Author instructions

Thanks for submitting your paper to JOSS @MGousseff. Currently, there isn't a JOSS editor assigned to your paper.

@MGousseff if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.47 s (80.3 files/s, 9071.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               29            538            794           1804
Markdown                         3            164              0            413
Rmd                              2            160            197            104
TeX                              1              9              0             82
YAML                             1              2              4             19
JSON                             2              0              0              2
-------------------------------------------------------------------------------
SUM:                            38            873            995           2424
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 2359

editorialbot commented 1 year ago

:warning: An error happened when generating the pdf.

oliviaguest commented 1 year ago

👋 @martinfleis @elbeejay @hugoledoux @jsta @crvernon can any of you take over this one (even with waitlist)? ☺️ Have a lovely week.

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1016/j.eiar.2015.10.004 may be a valid DOI for title: An energy and mortality impact assessment of the urban heat island in the US
- 10.1016/0013-9351(72)90023-0 may be a valid DOI for title: Some effects of the urban structure on heat mortality
- 10.1175/bams-d-11-00019.1 may be a valid DOI for title: Local climate zones for urban temperature studies
- 10.1016/j.buildenv.2021.107791 may be a valid DOI for title: A systematic review of GIS-based local climate zone mapping studies
- 10.21105/joss.03541 may be a valid DOI for title: GeoClimate: a Geospatial processing toolbox for environmental and climate studies
- 10.3390/land11050747 may be a valid DOI for title: Inference of Local Climate Zones from GIS Data, and Comparison to WUDAPT Classification and Custom-Fit Clusters
- 10.1016/j.landurbplan.2017.08.009 may be a valid DOI for title: Evaluating urban heat island in the critical local climate zones of an Indian city

INVALID DOIs

- None
martinfleis commented 1 year ago

@editorialbot assign me as editor

@oliviaguest this is my turf :)

editorialbot commented 1 year ago

Assigned! @martinfleis is now the editor

oliviaguest commented 1 year ago

@martinfleis 🏞️ 🥳 ty

oliviaguest commented 1 year ago

@MGousseff can you fix this, please?


Problem with ORCID (0000-0000-0000-0000) for Matthieu Gousseff. Invalid ORCID
MGousseff commented 1 year ago

Thank you all for reviewing. Sorry I didn't answer earlier, I'm on it.

MGousseff commented 1 year ago

I think it is fixed. By the way, I may have missed something about licencing. The licence.md of the package specifies LGPL-3, which seems OK according to OSI : https://opensource.org/licenses/, but the article says CC by 4.0. I'm still looking for where I need to specify this.

martinfleis commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

martinfleis commented 1 year ago

@MGousseff Thanks! The paper will be released under CC-BY 4.0. That is correct. The license in the PDF does not reflect the license of the code but that of the publication.

MGousseff commented 1 year ago

@martinfleis Thank you very much for the answer, sorry for the naive question !

martinfleis commented 1 year ago

@MGousseff if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

MGousseff commented 1 year ago

I think Matthias Demuzere matthias.demuzere@ruhr-uni-bochum.de could be interested : he is from the WUDAPT team, and GeoClimate and Wudapt are two very complementary workflows : he might even suggest I better document the raster part ! Do you need me to suggest more than one ? Maybe Mike Spencer (mikerspencer) could be interested too ?

martinfleis commented 1 year ago

Hey @kadyb, would you be willing to review this submission for the JOSS?

matthiasdemuzere commented 1 year ago

My R skills are very rusty, yet content-wise this work is my cup of tea. Not sure if this makes me a suitable reviewer? If yes, I am up for it!

martinfleis commented 1 year ago

@matthiasdemuzere That is fine, having one reviewer closer to the topic and the other closer to tech is a good balance ;). Thanks!

martinfleis commented 1 year ago

@editorialbot add @matthiasdemuzere as reviewer.

editorialbot commented 1 year ago

@matthiasdemuzere added to the reviewers list!

kadyb commented 1 year ago

Hi @martinfleis! Thanks a lot for the invitation, but unfortunately I don't have time to deal with it.

martinfleis commented 1 year ago

Hey @wcjochem would you be willing and able to review this? It is very close to your expertise!

wcjochem commented 1 year ago

Hi @martinfleis yes, I can review this. Thanks

martinfleis commented 1 year ago

@editorialbot add @wcjochem as reviewer

@wcjochem Thanks!

editorialbot commented 1 year ago

@wcjochem added to the reviewers list!

martinfleis commented 1 year ago

@editorialbot start review

editorialbot commented 1 year ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/5445.