openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
708 stars 37 forks source link

[REVIEW]: SleepECG: a Python package for sleep staging based on heart rate #5411

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@cbrnr<!--end-author-handle-- (Clemens Brunner) Repository: https://github.com/cbrnr/sleepecg Branch with paper.md (empty if default branch): joss Version: v0.5.5 Editor: !--editor-->@emdupre<!--end-editor-- Reviewers: @tompollard, @richrobe, @peterakirk Archive: 10.5281/zenodo.7993717

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/842b3838fa2f0f4f735cbd25de8508bb"><img src="https://joss.theoj.org/papers/842b3838fa2f0f4f735cbd25de8508bb/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/842b3838fa2f0f4f735cbd25de8508bb/status.svg)](https://joss.theoj.org/papers/842b3838fa2f0f4f735cbd25de8508bb)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@tompollard & @richrobe & @peterakirk, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @emdupre know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @richrobe

📝 Checklist for @peterakirk

📝 Checklist for @tompollard

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

emdupre commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/j.1469-8986.1966.tb02650.x is OK
- 10.1109/TBME.1985.325532 is OK
- 10.1161/01.CIR.93.5.1043 is OK
- 10.5664/jcsm.26814 is OK
- 10.3389/fpubh.2017.00258 is OK
- 10.1145/3397325 is OK
- 10.5281/zenodo.7987192 is OK
- 10.1093/jamia/ocy064 is OK
- 10.5665/sleep.4732 is OK
- 10.1093/sleep/20.12.1077 is OK
- 10.1046/j.1440-1819.1999.00527.x is OK

MISSING DOIs

- None

INVALID DOIs

- None
emdupre commented 1 year ago

Thank you, @cbrnr !

I'm now happy to recommend SleepECG for publication 🚀 Congratulations on this (impressive !) work. And thank you to @tompollard, @richrobe, and @peterakirk for your time and expertise in reviewing this submission !

emdupre commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago
Attempting dry run of processing paper acceptance...
editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/j.1469-8986.1966.tb02650.x is OK
- 10.1109/TBME.1985.325532 is OK
- 10.1161/01.CIR.93.5.1043 is OK
- 10.5664/jcsm.26814 is OK
- 10.3389/fpubh.2017.00258 is OK
- 10.1145/3397325 is OK
- 10.5281/zenodo.7987192 is OK
- 10.1093/jamia/ocy064 is OK
- 10.5665/sleep.4732 is OK
- 10.1093/sleep/20.12.1077 is OK
- 10.1046/j.1440-1819.1999.00527.x is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 1 year ago

:wave: @openjournals/bcm-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4286, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

cbrnr commented 1 year ago

Thank you all, this was a wonderful review process with super helpful comments! 🚀

cbrnr commented 1 year ago

(Not sure if you needed my feedback, but the final proof looks good!)

emdupre commented 1 year ago

Thank you for confirming, @cbrnr !

We're now waiting on JOSS EiC availability ; I will follow-up with that team if we don't hear back in the next couple of days, just to make sure this doesn't slip through the cracks !

Kevin-Mattheus-Moerman commented 1 year ago

@cbrnr @emdupre I have checked the archive, the repository, this review, and the paper. And all seems in order. I will now proceed to process this work for acceptance in JOSS.

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 1 year ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Brunner given-names: Clemens orcid: "https://orcid.org/0000-0002-6030-2233" - family-names: Hofer given-names: Florian orcid: "https://orcid.org/0009-0009-0449-1197" doi: 10.5281/zenodo.7993717 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Brunner given-names: Clemens orcid: "https://orcid.org/0000-0002-6030-2233" - family-names: Hofer given-names: Florian orcid: "https://orcid.org/0009-0009-0449-1197" date-published: 2023-06-09 doi: 10.21105/joss.05411 issn: 2475-9066 issue: 86 journal: Journal of Open Source Software publisher: name: Open Journals start: 5411 title: "SleepECG: a Python package for sleep staging based on heart rate" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05411" volume: 8 title: "SleepECG: a Python package for sleep staging based on heart rate" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 1 year ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

editorialbot commented 1 year ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 1 year ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4292
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05411
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

Kevin-Mattheus-Moerman commented 1 year ago

@cbrnr congratulations on this publication in JOSS!

@emdupre thank you for editing!

And a special thanks to the reviewers: @tompollard, @richrobe, @peterakirk !!

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05411/status.svg)](https://doi.org/10.21105/joss.05411)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05411">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05411/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05411/status.svg
   :target: https://doi.org/10.21105/joss.05411

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: