openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: Biotrade: A Python package to access and analyse the international trade of bio-based products #5421

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@paulrougieux<!--end-author-handle-- (Paul Rougieux) Repository: https://gitlab.com/bioeconomy/forobs/biotrade/ Branch with paper.md (empty if default branch): Version: 0.1.0 Editor: !--editor-->@martinfleis<!--end-editor-- Reviewers: @FATelarico, @potterzot Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f0f37ab918abe2cb766e94b42e520c67"><img src="https://joss.theoj.org/papers/f0f37ab918abe2cb766e94b42e520c67/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f0f37ab918abe2cb766e94b42e520c67/status.svg)](https://joss.theoj.org/papers/f0f37ab918abe2cb766e94b42e520c67)

Author instructions

Thanks for submitting your paper to JOSS @paulrougieux. Currently, there isn't a JOSS editor assigned to your paper.

@paulrougieux if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.10 s (809.2 files/s, 125245.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          61           1288           3459           5379
Markdown                        15            416              0           1658
TeX                              1              9              0             79
YAML                             2              5              0             44
SQL                              1              3              3             39
-------------------------------------------------------------------------------
SUM:                            80           1721           3462           7199
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 2160

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.32614/RJ-2017-019 is OK

MISSING DOIs

- 10.1126/science.abm9267 may be a valid DOI for title: Disentangling the numbers behind agriculture-driven tropical deforestation

INVALID DOIs

- None
editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

paulrougieux commented 1 year ago

Filtering the joss_reviewers spreadsheet for preferred programming language containing "python" and domains/topic containing "API" or "environ" (to find topics related to environmental sciences), I found the following potential reviewers. The first five in the list are the preferred ones to be contacted first if available.

paulrougieux commented 1 year ago

In addition to the previous reviewers, I notice that :

I added their names to the top of the list in the previous comment.

paulrougieux commented 1 year ago

@editorialbot commands

editorialbot commented 1 year ago

Hello @paulrougieux, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers
paulrougieux commented 1 year ago

@editorialbot list reviewers

editorialbot commented 1 year ago

Here's the current list of reviewers: https://bit.ly/joss-reviewers

paulrougieux commented 1 year ago

How do we get a JOSS editor assigned to the paper? I had a look at the editorial guide and will wait a few more days.

paulrougieux commented 1 year ago

@editorialbot check repository

editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.09 s (888.9 files/s, 137585.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          61           1288           3459           5379
Markdown                        15            416              0           1658
TeX                              1              9              0             79
YAML                             2              5              0             44
SQL                              1              3              3             39
-------------------------------------------------------------------------------
SUM:                            80           1721           3462           7199
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 2160

paulrougieux commented 1 year ago

@graciellehigino I contact you because you appear as a topic editor on " macroecology " in https://joss.theoj.org/about#editorial_board

The paper is currently in track 2 "biomedical engineering, biosciences, chemistry and materials". There has been no contact since last week I'm starting to wonder if this may be the wrong track. I see that track 6 earth sciences and ecology has papers about agricultural yields and papers about getting data from databases. These topics are similar to what we are working with inside the biotrade package. Our goal may not be obvious from the title, but it's to look at the impact of trade of bio-based commodities on deforestation. Applications could be more general than that, that's why we kept a generic title. Would it be possible to change to track 6?

graciellehigino commented 1 year ago

Hi @paulrougieux ! Thanks for tagging me! You bring a valid concern in terms of tracks, and I see you are probably wondering what's happening while you wait for reviews. I'm sure @Kevin-Mattheus-Moerman is looking for editors right now for your paper, so you shouldn't worry about it. As I am not an EiC, I can't change tracks for your submission. @Kevin-Mattheus-Moerman what do you think?

Kevin-Mattheus-Moerman commented 1 year ago

@paulrougieux apologies for the delay. I've been away at a conference and hence didn't get to this until now. I'll contact the track AEiC to see if switching is an option. Note though that the track was not the source of the delay. Also we recruit editors from the entire pool of editors, so not just from one track. I'll get back to you shortly.

paulrougieux commented 1 year ago

Thank you both for your replies.

Kevin-Mattheus-Moerman commented 1 year ago

@paulrougieux I have just changed the track to ESE, which means that Kristen Thyng (@kthyng) is your AEiC. Just to clarify that at this point the AEiC, Kristen, will look for a handling editor. Once a handling editor is assigned that person will start looking for and recruiting reviewers. Hope that clarifies things.

kthyng commented 1 year ago

Hi @paulrougieux and thanks for your submission. I just browsed the repo and I couldn't immediately see docs — do you have some?

@marcosvital could you edit this submission?

kthyng commented 1 year ago

@editorialbot invite @marcosvital as editor

editorialbot commented 1 year ago

Invitation to edit this submission sent!

paulrougieux commented 1 year ago

Hi @paulrougieux and thanks for your submission. I just browsed the repo and I couldn't immediately see docs — do you have some?

@marcosvital could you edit this submission?

Thank you for your comment. The documentation are in the source code. They can be exported with a tool like pydoc. I'll make this explicit by tomorrow.

kthyng commented 1 year ago

@paulrougieux You might consider hosting documentation with something like read the docs since people don't seem to generate docs on their own any more.

paulrougieux commented 1 year ago

The documentation generated on Gitlab-CI is now at: https://bioeconomy.gitlab.io/forobs/biotrade/biotrade.html

kthyng commented 1 year ago

@paulrougieux We just have a few editors that are peripherally related to this sort of work (from what I can tell), but they are fully occupied right now. I'll add this to the waitlist for now, thanks for your patience.

paulrougieux commented 1 year ago

Thank you for the information we are looking forward to what we can learn from the review process.

kthyng commented 1 year ago

@martinfleis Might you be able to edit this submission?

kthyng commented 1 year ago

@editorialbot invite @martinfleis as editor

editorialbot commented 1 year ago

Invitation to edit this submission sent!

martinfleis commented 1 year ago

@kthyng I can edit it if I can start next week on it.

kthyng commented 1 year ago

@martinfleis that would be great, thank you! I'll assign it to you now.

kthyng commented 1 year ago

@editorialbot add @martinfleis as editor

editorialbot commented 1 year ago

Assigned! @martinfleis is now the editor

martinfleis commented 1 year ago

@editorialbot @FATelarico as reviewer

editorialbot commented 1 year ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

martinfleis commented 1 year ago

@editorialbot add @FATelarico as reviewer

editorialbot commented 1 year ago

@FATelarico added to the reviewers list!

martinfleis commented 1 year ago

@editorialbot add @potterzot as reviewer

editorialbot commented 1 year ago

@potterzot added to the reviewers list!

martinfleis commented 1 year ago

@editorialbot start review

editorialbot commented 1 year ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/5550.