openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
722 stars 38 forks source link

[REVIEW]: `SuperNOVA`: Semi-Parametric Identification and Estimation of Interaction and Effect Modification in Mixed Exposures using Stochastic Interventions in `R` #5422

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@blind-contours<!--end-author-handle-- (David McCoy) Repository: https://github.com/blind-contours/SuperNOVA Branch with paper.md (empty if default branch): main Version: v1.0.0-JOSS Editor: !--editor-->@csoneson<!--end-editor-- Reviewers: @mhu48, @lucasmiranda42 Archive: 10.5281/zenodo.10038794

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/70888201f8453113ab2a8d287b78c0f6"><img src="https://joss.theoj.org/papers/70888201f8453113ab2a8d287b78c0f6/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/70888201f8453113ab2a8d287b78c0f6/status.svg)](https://joss.theoj.org/papers/70888201f8453113ab2a8d287b78c0f6)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@mhu48 & @lucasmiranda42, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @csoneson know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @mhu48

📝 Checklist for @lucasmiranda42

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/rssb.12362 is OK
- 10.5281/zenodo.1342293 is OK
- 10.48550/arXiv.2305.01849 is OK
- 10.1515/ijb-2015-0013 is OK
- 10.1111/j.1541-0420.2011.01685.x is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

csoneson commented 1 year ago

@editorialbot set 10.5281/zenodo.10038794 as archive

editorialbot commented 1 year ago

Done! archive is now 10.5281/zenodo.10038794

csoneson commented 1 year ago

@editorialbot set v1.0.0-JOSS as version

editorialbot commented 1 year ago

Done! version is now v1.0.0-JOSS

csoneson commented 1 year ago

Thanks! Final minor detail - it looks like the first and second names of the co-authors are swapped in the Zenodo archive. Once that is fixed I think we are ready to move to the final stage.

blind-contours commented 1 year ago

I believe this is the contributors section on Zenodo - I have all the authors listed as creators so I just removed that section and everything should match now. Let me know if you need anything else.

csoneson commented 1 year ago

Sorry, I was unclear - the author lists match, but I see this in Zenodo:

McCoy, David; Alejandro, Shuler; Alan, Hubbard; Mark, van der Laan

I.e., the first names of your co-authors seem to be interpreted as surnames, and vice versa.

blind-contours commented 1 year ago

Oh yea, my mistake. That's fixed now.

csoneson commented 1 year ago

Great! This looks good - I will hand off to the track AEiC for the last steps.

csoneson commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago
Attempting dry run of processing paper acceptance...
editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/rssb.12362 is OK
- 10.5281/zenodo.1342293 is OK
- 10.48550/arXiv.2305.01849 is OK
- 10.1515/ijb-2015-0013 is OK
- 10.1111/j.1541-0420.2011.01685.x is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 1 year ago

:wave: @openjournals/dsais-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4749, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

arfon commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 1 year ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: McCoy given-names: David orcid: "https://orcid.org/0000-0002-5515-6307" - family-names: Schuler given-names: Alejandro orcid: "https://orcid.org/0000-0003-4853-6130" - family-names: Hubbard given-names: Alan orcid: "https://orcid.org/0000-0002-3769-0127" - family-names: Laan given-names: Mark name-particle: van der orcid: "https://orcid.org/0000-0003-1432-5511" doi: 10.5281/zenodo.10038794 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: McCoy given-names: David orcid: "https://orcid.org/0000-0002-5515-6307" - family-names: Schuler given-names: Alejandro orcid: "https://orcid.org/0000-0003-4853-6130" - family-names: Hubbard given-names: Alan orcid: "https://orcid.org/0000-0002-3769-0127" - family-names: Laan given-names: Mark name-particle: van der orcid: "https://orcid.org/0000-0003-1432-5511" date-published: 2023-11-05 doi: 10.21105/joss.05422 issn: 2475-9066 issue: 91 journal: Journal of Open Source Software publisher: name: Open Journals start: 5422 title: "SuperNOVA: Semi-Parametric Identification and Estimation of Interaction and Effect Modification in Mixed Exposures using Stochastic Interventions in R" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05422" volume: 8 title: "`SuperNOVA`: Semi-Parametric Identification and Estimation of Interaction and Effect Modification in Mixed Exposures using Stochastic Interventions in `R`" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 1 year ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 1 year ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4750
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05422
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

arfon commented 1 year ago

@mhu48, @lucasmiranda42 – many thanks for your reviews here and to @csoneson for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@blind-contours – your paper is now accepted and published in JOSS :zap::rocket::boom:

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05422/status.svg)](https://doi.org/10.21105/joss.05422)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05422">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05422/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05422/status.svg
   :target: https://doi.org/10.21105/joss.05422

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: