[REVIEW]: PyFlowline a mesh independent river network generator for hydrologic models

[editorialbot]

Submitting author: !--author-handle-->@changliao1025<!--end-author-handle-- (Chang Liao) Repository: https://github.com/changliao1025/pyflowline Branch with paper.md (empty if default branch): main Version: v0.3.4 Editor: !--editor-->@observingClouds<!--end-editor-- Reviewers: @smchartrand, @andres-patrignani Archive: 10.5281/zenodo.10076553

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/ed4e15a1063253b821f5ae5fe292050e"><img src="https://joss.theoj.org/papers/ed4e15a1063253b821f5ae5fe292050e/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/ed4e15a1063253b821f5ae5fe292050e/status.svg)](https://joss.theoj.org/papers/ed4e15a1063253b821f5ae5fe292050e)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@smchartrand & @andres-patrignani, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @observingClouds know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @smchartrand

📝 Checklist for @andres-patrignani

[observingClouds]

@editorialbot generate pdf

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[observingClouds]

@editorialbot check references

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.5558988 is OK
- 10.5194/hess-26-5473-2022 is OK
- 10.1029/2022MS003089 is OK
- 10.5194/gmd-9-2223-2016 is OK
- 10.21105/joss.02952 is OK
- 10.1029/2012WR012313 is OK
- 10.5281/zenodo.6109987 is OK
- 10.1029/2022MS003487 is OK

MISSING DOIs

- None

INVALID DOIs

- None

[observingClouds]

@editorialbot recommend-accept

[editorialbot]

Attempting dry run of processing paper acceptance...

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.5558988 is OK
- 10.5194/hess-26-5473-2022 is OK
- 10.1029/2022MS003089 is OK
- 10.5194/gmd-9-2223-2016 is OK
- 10.21105/joss.02952 is OK
- 10.1029/2012WR012313 is OK
- 10.5281/zenodo.6109987 is OK
- 10.1029/2022MS003487 is OK

MISSING DOIs

- None

INVALID DOIs

- None

[editorialbot]

:wave: @openjournals/ese-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4757, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

[kthyng]

Hi! My job is to wrap up this publication. My steps are:

• [x] Check that version was updated
• [x] Check that software archive exists, has been input to JOSS, and title and author list look good
• [x] Check paper

[kthyng]

Ok we're good to go!

[kthyng]

@editorialbot accept

[editorialbot]

Doing it live! Attempting automated processing of paper acceptance...

[editorialbot]

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Liao given-names: Chang orcid: "https://orcid.org/0000-0002-7348-8858" - family-names: Cooper given-names: Matt G orcid: "https://orcid.org/0000-0002-0165-209X" doi: 10.5281/zenodo.10076553 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Liao given-names: Chang orcid: "https://orcid.org/0000-0002-7348-8858" - family-names: Cooper given-names: Matt G orcid: "https://orcid.org/0000-0002-0165-209X" date-published: 2023-11-07 doi: 10.21105/joss.05446 issn: 2475-9066 issue: 91 journal: Journal of Open Source Software publisher: name: Open Journals start: 5446 title: "pyflowline: a mesh-independent river network generator for hydrologic models" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05446" volume: 8 title: "pyflowline: a mesh-independent river network generator for hydrologic models" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

[editorialbot]

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

[editorialbot]

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

0. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4766
1. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05446
2. If everything looks good, then close this review issue.
3. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

[kthyng]

Congrats on your new publication @changliao1025! Many thanks to editor @observingClouds and reviewers @smchartrand and @andres-patrignani for your time, hard work, and expertise!!

[editorialbot]

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05446/status.svg)](https://doi.org/10.21105/joss.05446)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05446">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05446/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05446/status.svg
   :target: https://doi.org/10.21105/joss.05446

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

• Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
• Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

[changliao1025]

Thank you, @kthyng @observingClouds and reviewers, for the indispensable help and suggestions during this process.