[REVIEW]: Spikeometric - Linear Non-Linear Cascade Spiking Neural Networks with PyTorch Geometric

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@lepmik@jbytecode<!--end-editor-- Reviewers: @clinssen, @Saran-nns Archive: 10.5281/zenodo.8358903

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9016e77f4fd1bb880dcebbe79361f948"><img src="https://joss.theoj.org/papers/9016e77f4fd1bb880dcebbe79361f948/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9016e77f4fd1bb880dcebbe79361f948/status.svg)](https://joss.theoj.org/papers/9016e77f4fd1bb880dcebbe79361f948)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@clinssen & @Saran-nns, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jbytecode know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @Saran-nns

📝 Checklist for @clinssen

editorialbot commented 11 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/s41593-020-0699-2 is OK
- 10.1101/463760 is OK
- 10.3389/fnsys.2016.00109 is OK
- 10.1017/CBO9781107447615 is OK
- 10.1038/nature07140 is OK
- 10.4249/scholarpedia.1343 is OK
- 10.1088/0954-898x_15_4_002 is OK
- 10.4249/scholarpedia.1430 is OK
- 10.1017/CBO9780511541612 is OK
- 10.7554/eLife.47314 is OK
- 10.1007/978-1-4614-7320-6_255-1 is OK
- 10.3389/fninf.2022.883333 is OK
- 10.3389/fncom.2021.627620 is OK
- 10.3389/fninf.2018.00089 is OK
- 10.48550/arXiv.2109.12894 is OK

MISSING DOIs

- None

INVALID DOIs

- None

jbytecode commented 11 months ago

@editorialbot generate pdf

editorialbot commented 11 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

lepmik commented 11 months ago

@editorialbot generate pdf

editorialbot commented 11 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

jbytecode commented 11 months ago

@lepmik - Thank you for merging. Now the paper and the bibtex seem better.

I've just sent a new PR for a minor correction on bibtex.
Please read and check the whole paper one more time. Please correct any issues if exist.
Create a version tag in software repository and report here.
Use this version tag (release) to create a new Zenodo archive. Please report the DOI here.
Please ensure that the author information including DOI's and the paper title match the zenodo archive.

Thank you in advance.

jbytecode commented 11 months ago

@editorialbot generate pdf

editorialbot commented 11 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

jbytecode commented 11 months ago

@lepmik - you can also follow the instructions given in https://github.com/openjournals/joss-reviews/issues/5451#issuecomment-1724196220

lepmik commented 11 months ago

v1.0.3 bioAI-Oslo/Spikeometric: JOSS paper DOI: 10.5281/zenodo.8358903

JOSS paper

lepmik commented 11 months ago

@jbytecode I have read and checked the whole paper. Anything else?

jbytecode commented 11 months ago

@editorialbot set v1.0.3 as version

editorialbot commented 11 months ago

Done! version is now v1.0.3

jbytecode commented 11 months ago

@lepmik - In archive https://zenodo.org/record/8358903

The author list
Their ORCIDs
The paper title and the archive title

should match. Please correct and ping me.

lepmik commented 11 months ago

@jbytecode sorry, I forgot to do that, should be correct now.

jbytecode commented 11 months ago

@editorialbot set 10.5281/zenodo.8358903 as archive

editorialbot commented 11 months ago

Done! archive is now 10.5281/zenodo.8358903

jbytecode commented 11 months ago

@lepmik - Everything seems okay to me. I am now recommending an accept. Our track editor will make the final decision. Thank you.

jbytecode commented 11 months ago

@editorialbot recommend-accept

editorialbot commented 11 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 11 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/s41593-020-0699-2 is OK
- 10.1101/463760 is OK
- 10.3389/fnsys.2016.00109 is OK
- 10.1017/CBO9781107447615 is OK
- 10.1038/nature07140 is OK
- 10.4249/scholarpedia.1343 is OK
- 10.1088/0954-898x_15_4_002 is OK
- 10.4249/scholarpedia.1430 is OK
- 10.1017/CBO9780511541612 is OK
- 10.7554/eLife.47314 is OK
- 10.1007/978-1-4614-7320-6_255-1 is OK
- 10.3389/fninf.2022.883333 is OK
- 10.3389/fncom.2021.627620 is OK
- 10.3389/fninf.2018.00089 is OK
- 10.48550/arXiv.2109.12894 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 11 months ago

:wave: @openjournals/dsais-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4586, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

gkthiruvathukal commented 11 months ago

Everything looks good here.

gkthiruvathukal commented 11 months ago

@editorialbot accept

editorialbot commented 11 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 11 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Sønstebø given-names: Jakob L. orcid: "https://orcid.org/0009-0009-0584-9293" - family-names: Brunborg given-names: Herman - family-names: Lepperød given-names: Mikkel Elle orcid: "https://orcid.org/0000-0002-4262-5549" doi: 10.5281/zenodo.8358903 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Sønstebø given-names: Jakob L. orcid: "https://orcid.org/0009-0009-0584-9293" - family-names: Brunborg given-names: Herman - family-names: Lepperød given-names: Mikkel Elle orcid: "https://orcid.org/0000-0002-4262-5549" date-published: 2023-09-20 doi: 10.21105/joss.05451 issn: 2475-9066 issue: 89 journal: Journal of Open Source Software publisher: name: Open Journals start: 5451 title: "Spikeometric: Linear Non-Linear Cascade Spiking Neural Networks with Pytorch Geometric" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05451" volume: 8 title: "Spikeometric: Linear Non-Linear Cascade Spiking Neural Networks with Pytorch Geometric" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 11 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 11 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4587
Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05451
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

editorialbot commented 11 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05451/status.svg)](https://doi.org/10.21105/joss.05451)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05451">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05451/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05451/status.svg
   :target: https://doi.org/10.21105/joss.05451

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews