[REVIEW]: PAS: a Python Anesthesia Simulator for drug control

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@BobAubouin@ppxasjsm<!--end-editor-- Reviewers: @yumuk1989, @JHartzer Archive: 10.5281/zenodo.8171326

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/61d34ad9ef855a128509b4279e2c9325"><img src="https://joss.theoj.org/papers/61d34ad9ef855a128509b4279e2c9325/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/61d34ad9ef855a128509b4279e2c9325/status.svg)](https://joss.theoj.org/papers/61d34ad9ef855a128509b4279e2c9325)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@yumuk1989 & @JHartzer, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @ppxasjsm know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @JHartzer

📝 Checklist for @yumuk1989

ppxasjsm commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

ppxasjsm commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1213/00000539-200103000-00020 is OK
- 10.1093/bja/aei259 is OK
- 10.1007/s10928-020-09712-1 is OK
- 10.1097/00000542-200406000-00006 is OK
- 10.1213/ANE.0000000000001372 is OK
- 10.1093/bja/aeh293 is OK
- 10.1007/s42452-021-04885-x is OK
- 10.1016/c2017-0-03401-8 is OK
- 10.1093/bja/aew126 is OK
- 10.1097/ALN.0000000000001634 is OK
- 10.1016/j.bja.2018.01.018 is OK
- 10.1093/bja/67.5.618 is OK
- 10.1109/CDC45484.2021.9683368 is OK
- 10.1109/ACCESS.2020.3037725 is OK
- 10.1186/cc9207 is OK
- 10.1155/2017/7432310 is OK
- 10.1109/ACCESS.2021.3049880 is OK
- 10.1109/TBME.2008.923142 is OK
- 10.1093/bja/aeu553 is OK
- 10.1097/00000542-200102000-00023 is OK
- 10.1097/00000542-200308000-00023 is OK
- 10.1097/00000542-200206000-00033 is OK
- 10.1213/ane.0b013e3181a96f9a is OK
- 10.1038/s41598-018-20062-4 is OK
- 10.1093/bja/67.1.41 is OK
- 10.1016/B978-0-12-815975-0.00013-8 is OK
- 10.1016/j.cnsns.2018.12.015 is OK
- 10.1097/00000542-199701000-00004 is OK
- 10.1097/CCM.0b013e318206d2a3 is OK
- 10.1016/j.compchemeng.2022.107747 is OK
- 10.1016/j.jprocont.2022.07.007 is OK
- 10.1213/ANE.0000000000000769 is OK
- 10.1186/cc10562 is OK
- 10.1016/j.jprocont.2021.12.004 is OK
- 10.1016/j.bspc.2021.102476 is OK
- 10.1097/00000542-199906000-00003 is OK
- 10.1097/00000542-200003000-00017 is OK
- 10.1213/ANE.0000000000000386 is OK
- 10.4103/sja.sja_669_21 is OK
- 10.1111/j.1460-9592.2009.03174.x is OK
- 10.1097/00000542-200002000-00021 is OK
- 10.1213/00000539-199909000-00002 is OK

MISSING DOIs

- 10.23919/ecc57647.2023.10178214 may be a valid DOI for title: Data-Based Pharmacodynamic Modeling for BIS and Mean Arterial Pressure Prediction during General Anesthesia

INVALID DOIs

- None

ppxasjsm commented 1 year ago

@BobAubouin, I am sorry this ended up taking much longer than I thought. We are ready to accept, there is just one DOI that should be added to the paper. This is for the title: Data-Based Pharmacodynamic Modeling for BIS and Mean Arterial Pressure Prediction during General Anesthesia

Looking at the link: https://ieeexplore.ieee.org/document/10178214, the DOI suggest and just stated below should be added: 10.23919/ECC57647.2023.10178214

Thanks a lot! As soon as this is done I can recommend-accept.

BobAubouin commented 1 year ago

Hi @ppxasjsm no problem for the delay!

The DOI have been added to the paper.

BobAubouin commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

BobAubouin commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1213/00000539-200103000-00020 is OK
- 10.23919/ecc57647.2023.10178214 is OK
- 10.1093/bja/aei259 is OK
- 10.1007/s10928-020-09712-1 is OK
- 10.1097/00000542-200406000-00006 is OK
- 10.1213/ANE.0000000000001372 is OK
- 10.1093/bja/aeh293 is OK
- 10.1007/s42452-021-04885-x is OK
- 10.1016/c2017-0-03401-8 is OK
- 10.1093/bja/aew126 is OK
- 10.1097/ALN.0000000000001634 is OK
- 10.1016/j.bja.2018.01.018 is OK
- 10.1093/bja/67.5.618 is OK
- 10.1109/CDC45484.2021.9683368 is OK
- 10.1109/ACCESS.2020.3037725 is OK
- 10.1186/cc9207 is OK
- 10.1155/2017/7432310 is OK
- 10.1109/ACCESS.2021.3049880 is OK
- 10.1109/TBME.2008.923142 is OK
- 10.1093/bja/aeu553 is OK
- 10.1097/00000542-200102000-00023 is OK
- 10.1097/00000542-200308000-00023 is OK
- 10.1097/00000542-200206000-00033 is OK
- 10.1213/ane.0b013e3181a96f9a is OK
- 10.1038/s41598-018-20062-4 is OK
- 10.1093/bja/67.1.41 is OK
- 10.1016/B978-0-12-815975-0.00013-8 is OK
- 10.1016/j.cnsns.2018.12.015 is OK
- 10.1097/00000542-199701000-00004 is OK
- 10.1097/CCM.0b013e318206d2a3 is OK
- 10.1016/j.compchemeng.2022.107747 is OK
- 10.1016/j.jprocont.2022.07.007 is OK
- 10.1213/ANE.0000000000000769 is OK
- 10.1186/cc10562 is OK
- 10.1016/j.jprocont.2021.12.004 is OK
- 10.1016/j.bspc.2021.102476 is OK
- 10.1097/00000542-199906000-00003 is OK
- 10.1097/00000542-200003000-00017 is OK
- 10.1213/ANE.0000000000000386 is OK
- 10.4103/sja.sja_669_21 is OK
- 10.1111/j.1460-9592.2009.03174.x is OK
- 10.1097/00000542-200002000-00021 is OK
- 10.1213/00000539-199909000-00002 is OK

MISSING DOIs

- None

INVALID DOIs

- None

ppxasjsm commented 1 year ago

Perfect thank you!

ppxasjsm commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago

Attempting dry run of processing paper acceptance...

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1213/00000539-200103000-00020 is OK
- 10.23919/ecc57647.2023.10178214 is OK
- 10.1093/bja/aei259 is OK
- 10.1007/s10928-020-09712-1 is OK
- 10.1097/00000542-200406000-00006 is OK
- 10.1213/ANE.0000000000001372 is OK
- 10.1093/bja/aeh293 is OK
- 10.1007/s42452-021-04885-x is OK
- 10.1016/c2017-0-03401-8 is OK
- 10.1093/bja/aew126 is OK
- 10.1097/ALN.0000000000001634 is OK
- 10.1016/j.bja.2018.01.018 is OK
- 10.1093/bja/67.5.618 is OK
- 10.1109/CDC45484.2021.9683368 is OK
- 10.1109/ACCESS.2020.3037725 is OK
- 10.1186/cc9207 is OK
- 10.1155/2017/7432310 is OK
- 10.1109/ACCESS.2021.3049880 is OK
- 10.1109/TBME.2008.923142 is OK
- 10.1093/bja/aeu553 is OK
- 10.1097/00000542-200102000-00023 is OK
- 10.1097/00000542-200308000-00023 is OK
- 10.1097/00000542-200206000-00033 is OK
- 10.1213/ane.0b013e3181a96f9a is OK
- 10.1038/s41598-018-20062-4 is OK
- 10.1093/bja/67.1.41 is OK
- 10.1016/B978-0-12-815975-0.00013-8 is OK
- 10.1016/j.cnsns.2018.12.015 is OK
- 10.1097/00000542-199701000-00004 is OK
- 10.1097/CCM.0b013e318206d2a3 is OK
- 10.1016/j.compchemeng.2022.107747 is OK
- 10.1016/j.jprocont.2022.07.007 is OK
- 10.1213/ANE.0000000000000769 is OK
- 10.1186/cc10562 is OK
- 10.1016/j.jprocont.2021.12.004 is OK
- 10.1016/j.bspc.2021.102476 is OK
- 10.1097/00000542-199906000-00003 is OK
- 10.1097/00000542-200003000-00017 is OK
- 10.1213/ANE.0000000000000386 is OK
- 10.4103/sja.sja_669_21 is OK
- 10.1111/j.1460-9592.2009.03174.x is OK
- 10.1097/00000542-200002000-00021 is OK
- 10.1213/00000539-199909000-00002 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 1 year ago

:wave: @openjournals/bcm-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4459, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

Kevin-Mattheus-Moerman commented 1 year ago

@BobAubouin I have checked this review, the archive, the repository, and the paper and most seems in order. We only have the below minor points that need your attention:

[x] Please edit your archive license (currently GNU Affero General Public License v3.0) to match your software license (GNU General Public License v3.0)
[x] The name richmond should likely feature a capital letter so be written as Richmond
[x] Recommendation: In your affiliations you may spell out Université Grenoble Alpes (no need to use the shortened Univ). Also if 38000 refers to a postal code, you may choose to leave that out.

BobAubouin commented 1 year ago

Hi @Kevin-Mattheus-Moerman, thanks for this final check!

I just changed the archive license to "GNU General Public License v3.0 only", I'm not sure if this ok but "GNU General Public License v3.0" was not in the list of available licenses.

I also add a capital letter to "Richmond".

About the affiliation, this is the exact sentence imposed by my lab, I prefer to keep it as it is.

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 1 year ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - email: bob.aubouin-pairault@gipsa-lab.fr family-names: Aubouin--Pairault given-names: Bob orcid: "https://orcid.org/0000-0003-0029-438X" - email: mirko.fiacchini@gipsa-lab.fr family-names: Fiacchini given-names: Mirko orcid: "https://orcid.org/0000-0002-3601-0302" - email: thao.dang@univ-grenoble-alpes.fr family-names: Dang given-names: Thao orcid: "https://orcid.org/0000-0002-3637-1415" contact: - email: bob.aubouin-pairault@gipsa-lab.fr family-names: Aubouin--Pairault given-names: Bob orcid: "https://orcid.org/0000-0003-0029-438X" doi: 10.5281/zenodo.8171326 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - email: bob.aubouin-pairault@gipsa-lab.fr family-names: Aubouin--Pairault given-names: Bob orcid: "https://orcid.org/0000-0003-0029-438X" - email: mirko.fiacchini@gipsa-lab.fr family-names: Fiacchini given-names: Mirko orcid: "https://orcid.org/0000-0002-3601-0302" - email: thao.dang@univ-grenoble-alpes.fr family-names: Dang given-names: Thao orcid: "https://orcid.org/0000-0002-3637-1415" date-published: 2023-08-14 doi: 10.21105/joss.05480 issn: 2475-9066 issue: 88 journal: Journal of Open Source Software publisher: name: Open Journals start: 5480 title: "PAS: a Python Anesthesia Simulator for drug control" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05480" volume: 8 title: "PAS: a Python Anesthesia Simulator for drug control" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 1 year ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 1 year ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4484
Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05480
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

Kevin-Mattheus-Moerman commented 1 year ago

@BobAubouin congratulations on this publication in JOSS!

Thanks for editing @ppxasjsm !

And a special thanks to the reviewers @yumuk1989 and @JHartzer

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05480/status.svg)](https://doi.org/10.21105/joss.05480)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05480">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05480/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05480/status.svg
   :target: https://doi.org/10.21105/joss.05480

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

BobAubouin commented 1 year ago

Thank you all for the help and yours feedbacks in this review!

openjournals / joss-reviews