[PRE REVIEW]: Pyafscgap.org: Open source multi-modal Python-based tools for NOAA AFSC RACE GAP

[editorialbot]

Submitting author: !--author-handle-->@sampottinger<!--end-author-handle-- (A Samuel Pottinger) Repository: https://github.com/SchmidtDSE/afscgap Branch with paper.md (empty if default branch): Version: v1.0.2 Editor: !--editor-->@Kevin-Mattheus-Moerman<!--end-editor-- Reviewers: !--reviewers-list-->@Kevin-Mattheus-Moerman<!--end-reviewers-list-- Managing EiC: Kevin M. Moerman

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/2b48c80992a67325863aa2fa9b51ae76"><img src="https://joss.theoj.org/papers/2b48c80992a67325863aa2fa9b51ae76/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/2b48c80992a67325863aa2fa9b51ae76/status.svg)](https://joss.theoj.org/papers/2b48c80992a67325863aa2fa9b51ae76)

Author instructions

Thanks for submitting your paper to JOSS @sampottinger. Currently, there isn't a JOSS editor assigned to your paper.

@sampottinger if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[editorialbot]

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.88  T=0.13 s (766.0 files/s, 174710.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                             9              0              0           6657
Python                          29           1524           2993           3447
JavaScript                      14            535           1010           2327
Markdown                        16            365              0            997
CSS                              2            103              0            443
HTML                             6             16              0            392
SQL                             10              5              0            324
Jupyter Notebook                 1              0            894            191
TeX                              1             22              0            189
YAML                             4              8              2            160
SVG                              1              0              1             54
TOML                             1              5              0             54
Bourne Shell                     5              9              8             29
Dockerfile                       1              9              8             28
-------------------------------------------------------------------------------
SUM:                           100           2601           4916          15292
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository

[editorialbot]

Wordcount for paper.md is 1035

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1023/a:1016528631593 is OK

MISSING DOIs

- 10.1007/978-1-4842-6011-1_12 may be a valid DOI for title: Oracle Rest Data Services

INVALID DOIs

- None

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[sampottinger]

Hello! Excited about this and thanks for taking us to this step. Please note that pyopensci had one more thing for us to change in our badges and the current version is 1.0.2. Thanks!

See https://github.com/pyOpenSci/software-submission/issues/93

We are approved by pyopensci and listed on their website.

[sampottinger]

@editorialbot set v1.0.2 as version

[editorialbot]

I'm sorry @sampottinger, I'm afraid I can't do that. That's something only editors are allowed to do.

[sampottinger]

Oh ok :sweat_smile:. Sorry I might need someone's help with updating that version. In the meantime, I'll take care of that DOI. I also read some recent JOSS reviews here so will try to take care of a few small things I've seen highlighted elsewhere.

[sampottinger]

@editorialbot generate pdf

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[sampottinger]

Regenerated the preview! Also wanted to mention the json line count… that json line count comes from the npm related files. Thanks!

[sampottinger]

The ORDS DOI from editorial bot (10.1007/978-1-4842-6011-1_12) was not right. I think the citation as is might still be best. Thanks!

[sampottinger]

@editorialbot check repository

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.88  T=0.24 s (418.0 files/s, 95343.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                             9              0              0           6657
Python                          29           1524           2993           3447
JavaScript                      14            535           1010           2327
Markdown                        16            365              0            997
CSS                              2            103              0            443
HTML                             6             16              0            392
SQL                             10              5              0            324
Jupyter Notebook                 1              0            894            191
TeX                              1             22              0            189
YAML                             4              8              2            160
SVG                              1              0              1             54
TOML                             1              5              0             54
Bourne Shell                     5              9              8             29
Dockerfile                       1              9              8             28
-------------------------------------------------------------------------------
SUM:                           100           2601           4916          15292
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository

[editorialbot]

Wordcount for paper.md is 1051

[sampottinger]

@editorialbot check repository

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.88  T=0.11 s (903.8 files/s, 206142.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                             9              0              0           6657
Python                          29           1524           2993           3447
JavaScript                      14            535           1010           2327
Markdown                        16            365              0            997
CSS                              2            103              0            443
HTML                             6             16              0            392
SQL                             10              5              0            324
Jupyter Notebook                 1              0            894            191
TeX                              1             22              0            189
YAML                             4              8              2            160
SVG                              1              0              1             54
TOML                             1              5              0             54
Bourne Shell                     5              9              8             29
Dockerfile                       1              9              8             28
-------------------------------------------------------------------------------
SUM:                           100           2601           4916          15292
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository

[editorialbot]

Wordcount for paper.md is 1007

[sampottinger]

Sorry for the noise. I saw we were getting a little above the length guideline. Just trimmed a little bit to get closer to the guidance. Thanks again for your consideration.

[sampottinger]

@editorialbot generate pdf

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[Kevin-Mattheus-Moerman]

@editorialbot set v1.0.2 as version

[editorialbot]

Done! version is now v1.0.2

[Kevin-Mattheus-Moerman]

@editorialbot check references

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1023/a:1016528631593 is OK

MISSING DOIs

- 10.1007/978-1-4842-6011-1_12 may be a valid DOI for title: Oracle Rest Data Services

INVALID DOIs

- None

[Kevin-Mattheus-Moerman]

@sampottinger I am the AEiC for this track and here to help process initial steps. In the meantime, can you please see if you can address that potentially missing DOI :point_up: ? You can edit your .bib file and call @editorialbot check references here to check them again.

[Kevin-Mattheus-Moerman]

@editorialbot invite @graciellehigino as editor

[editorialbot]

Invitation to edit this submission sent!

[sampottinger]

Hello! Thanks very much @Kevin-Mattheus-Moerman and nice to meet you @graciellehigino.

can you please see if you can address that potentially missing DOI

Appreciate your flagging this. The paper is citing ORDS itself and the DOI offered is a book about getting started with ORDS. The technology itself does not appear to have a publication with a DOI. Thank you!

here to help process initial steps

We appreciate your help. I just briefly wanted to mention that I noticed that some other submissions have a pyopensci tag but we do not. That in mind, I just wanted to note that pyopensci has accepted / approved us. See https://github.com/pyOpenSci/software-submission/issues/93.

Thank you both! Please let me know if there’s anything else I can do.

[Kevin-Mattheus-Moerman]

@graciellehigino :wave: do you think you can help edit this one?

[sampottinger]

Hello all! Just checking in. Is there anything we can do to help from our end? Thanks for your time!

[graciellehigino]

Hi all! This seems like a really interesting submission! However, I don't think I can help with this one because I always have a hard time finding Python users among ecologists. I think I'm on the wrong network for this... Sorry!

[sampottinger]

Thanks @graciellehigino! @Kevin-Mattheus-Moerman how would you like to proceed? Thank you both!

[Kevin-Mattheus-Moerman]

@editorialbot invite @Bisaloo as editor

[editorialbot]

Invitation to edit this submission sent!

[Kevin-Mattheus-Moerman]

@editorialbot assign me as editor

[editorialbot]

Assigned! @Kevin-Mattheus-Moerman is now the editor

[Kevin-Mattheus-Moerman]

This is a pyopensci related submission which was reviewed here: https://github.com/pyOpenSci/software-submission/issues/93

[Kevin-Mattheus-Moerman]

@editorialbot start review

[editorialbot]

Can't start a review without reviewers

[Kevin-Mattheus-Moerman]

@editorialbot assign me as reviewer

[editorialbot]

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

[Kevin-Mattheus-Moerman]

@editorialbot add @Kevin-Mattheus-Moerman as reviewer

[editorialbot]

@Kevin-Mattheus-Moerman added to the reviewers list!

[Kevin-Mattheus-Moerman]

@editorialbot start review

[editorialbot]

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/5593.