openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[REVIEW]: udpPacketManager: An International LOFAR Station Data (Pre-)Processor #5517

Closed editorialbot closed 7 months ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@David-McKenna<!--end-author-handle-- (David McKenna) Repository: https://github.com/David-McKenna/udpPacketManager/ Branch with paper.md (empty if default branch): Version: 0.9.2 Editor: !--editor-->@dfm<!--end-editor-- Reviewers: @pritchardn, @plaplant Archive: 10.5281/zenodo.11019139

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/727594ee41e844048c4edb7031f68a6e"><img src="https://joss.theoj.org/papers/727594ee41e844048c4edb7031f68a6e/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/727594ee41e844048c4edb7031f68a6e/status.svg)](https://joss.theoj.org/papers/727594ee41e844048c4edb7031f68a6e)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@shmookey & @pritchardn, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @plaplant know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

πŸ“ Checklist for @pritchardn

πŸ“ Checklist for @plaplant

editorialbot commented 7 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1017/S1743921312024623 is OK
- 10.1071/AS10021 is OK
- 10.1109/JPROC.2004.840301 is OK
- 10.1088/1538-3873/ab3e82 is OK
- 10.5281/ZENODO.7871665 is OK
- 10.1093/rasti/rzac005 is OK
- 10.48550/ARXIV.2302.12661 is OK
- 10.1051/0004-6361/202140415 is OK
- 10.1051/0004-6361/201220873 is OK
- 10.17487/RFC8878 is OK

MISSING DOIs

- No DOI given, and none found for title: LOFAR Und MPIfR Pulsare
- No DOI given, and none found for title: Station Data Cookbook
- No DOI given, and none found for title: dreamBeam
- No DOI given, and none found for title: LOFAR Data Format ICD Beam-Formed Data
- No DOI given, and none found for title: Simultaneous Dual-Site SETI with LOFAR Internation...
- No DOI given, and none found for title: Making Observations with Mode-357
- No DOI given, and none found for title: Pelican/Pelican-Lofar
- No DOI given, and none found for title: PSRDADA: Distributed Acquisition and Data Analysis...
- No DOI given, and none found for title: SIGPROC: Pulsar Signal Processing Programs

INVALID DOIs

- None
dfm commented 7 months ago

@editorialbot accept

editorialbot commented 7 months ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 7 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: McKenna given-names: David J. orcid: "https://orcid.org/0000-0001-7185-1310" - family-names: Keane given-names: Evan F. orcid: "https://orcid.org/0000-0002-4553-655X" - family-names: Gallagher given-names: Peter T. orcid: "https://orcid.org/0000-0001-9745-0400" - family-names: McCauley given-names: Joe orcid: "https://orcid.org/0000-0003-4399-2233" contact: - family-names: McKenna given-names: David J. orcid: "https://orcid.org/0000-0001-7185-1310" doi: 10.5281/zenodo.11019139 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: McKenna given-names: David J. orcid: "https://orcid.org/0000-0001-7185-1310" - family-names: Keane given-names: Evan F. orcid: "https://orcid.org/0000-0002-4553-655X" - family-names: Gallagher given-names: Peter T. orcid: "https://orcid.org/0000-0001-9745-0400" - family-names: McCauley given-names: Joe orcid: "https://orcid.org/0000-0003-4399-2233" date-published: 2024-04-22 doi: 10.21105/joss.05517 issn: 2475-9066 issue: 96 journal: Journal of Open Source Software publisher: name: Open Journals start: 5517 title: "udpPacketManager: An International LOFAR Station Data (Pre-)Processor" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05517" volume: 9 title: "udpPacketManager: An International LOFAR Station Data (Pre-)Processor" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 7 months ago

🐘🐘🐘 πŸ‘‰ Toot for this paper πŸ‘ˆ 🐘🐘🐘

editorialbot commented 7 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5260
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05517
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! πŸŽ‰πŸŒˆπŸ¦„πŸ’ƒπŸ‘»πŸ€˜

Any issues? Notify your editorial technical team...

dfm commented 7 months ago

@pritchardn, @plaplant β€” Many thanks for your reviews here! And also thanks to @plaplant for getting the review started as editor. JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!!

@David-McKenna β€” Your paper is now accepted and published in JOSS! :zap::rocket::boom:

editorialbot commented 7 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05517/status.svg)](https://doi.org/10.21105/joss.05517)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05517">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05517/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05517/status.svg
   :target: https://doi.org/10.21105/joss.05517

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: