[REVIEW]: bayes-toolbox: A Python package for Bayesian statistics

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@hyosubkim@samhforbes<!--end-editor-- Reviewers: @alstat, @ChristopherLucas Archive: 10.5281/zenodo.7849408

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/1b7b8068a329b547e28d00da0ad790b2"><img src="https://joss.theoj.org/papers/1b7b8068a329b547e28d00da0ad790b2/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/1b7b8068a329b547e28d00da0ad790b2/status.svg)](https://joss.theoj.org/papers/1b7b8068a329b547e28d00da0ad790b2)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@alstat & @ChristopherLucas & @BrandonEdwards, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @samhforbes know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @alstat

📝 Checklist for @ChristopherLucas

📝 Checklist for @BrandonEdwards

editorialbot commented 9 months ago

Done! archive is now 10.5281/zenodo.7849408

samhforbes commented 9 months ago

@editorialbot check references

editorialbot commented 9 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.31219/osf.io/ksfyr is OK
- 10.1146/annurev-psych-122216-011845 is OK
- 10.18637/jss.v035.i04 is OK
- 10.1016/c2012-0-00477-2 is OK
- 10.1080/00031305.2016.1154108 is OK
- 10.1371/journal.pcbi.1005510 is OK

MISSING DOIs

- None

INVALID DOIs

- None

samhforbes commented 9 months ago

@editorialbot generate pdf

editorialbot commented 9 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

samhforbes commented 9 months ago

Hi @hyosubkim our old friend editorialbot is pulling out 6 references from your .bib file. Do you mean to include these in the paper, or are these left over?

hyosubkim commented 9 months ago

@editorialbot generate pdf

editorialbot commented 9 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

hyosubkim commented 9 months ago

Hi @hyosubkim our old friend editorialbot is pulling out 6 references from your .bib file. Do you mean to include these in the paper, or are these left over?

Hi @samhforbes - those were holdovers, which I've now removed. editorialbot still seems happy. :)

hyosubkim commented 9 months ago

@editorialbot generate pdf

editorialbot commented 9 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

hyosubkim commented 9 months ago

@editorialbot generate pdf

editorialbot commented 9 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

samhforbes commented 9 months ago

@editorialbot check references

editorialbot commented 9 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.18637/jss.v035.i04 is OK
- 10.1016/c2012-0-00477-2 is OK
- 10.1371/journal.pcbi.1005510 is OK

MISSING DOIs

- None

INVALID DOIs

- None

samhforbes commented 9 months ago

@editorialbot recommend-accept

editorialbot commented 9 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 9 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.18637/jss.v035.i04 is OK
- 10.1016/c2012-0-00477-2 is OK
- 10.1371/journal.pcbi.1005510 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 9 months ago

:wave: @openjournals/sbcs-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4712, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

samhforbes commented 9 months ago

@hyosubkim I'm handing over to the EiC now, well done on a great package!

hyosubkim commented 9 months ago

Thanks @samhforbes ! I appreciate all of your help on this. And thanks again @alstat and @ChristopherLucas for your helpful reviews!

oliviaguest commented 8 months ago

@editorialbot recommend-accept

editorialbot commented 8 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 8 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.18637/jss.v035.i04 is OK
- 10.1016/c2012-0-00477-2 is OK
- 10.1371/journal.pcbi.1005510 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 8 months ago

:wave: @openjournals/sbcs-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4730, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

oliviaguest commented 8 months ago

@editorialbot accept

editorialbot commented 8 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 8 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Kim given-names: Hyosub E. orcid: "https://orcid.org/0000-0003-0109-593X" doi: 10.5281/zenodo.7849408 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Kim given-names: Hyosub E. orcid: "https://orcid.org/0000-0003-0109-593X" date-published: 2023-10-27 doi: 10.21105/joss.05526 issn: 2475-9066 issue: 90 journal: Journal of Open Source Software publisher: name: Open Journals start: 5526 title: "bayes-toolbox: A Python package for Bayesian statistics" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05526" volume: 8 title: "bayes-toolbox: A Python package for Bayesian statistics" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 8 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 8 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4731
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05526
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

oliviaguest commented 8 months ago

Huge thanks to the reviewers @alstat, @ChristopherLucas and editor @samhforbes! ✨ JOSS appreciates your work and effort. ✨ Also, big congratulations to @hyosubkim! 🥳 🍾

editorialbot commented 8 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05526/status.svg)](https://doi.org/10.21105/joss.05526)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05526">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05526/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05526/status.svg
   :target: https://doi.org/10.21105/joss.05526

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews