openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[PRE REVIEW]: Bramble: adaptive common neighbor analysis (CNA) for the recognition of surface topologies in nanoparticles #5528

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@ifilot<!--end-author-handle-- (Ivo Filot) Repository: https://github.com/ifilot/bramble Branch with paper.md (empty if default branch): Version: v1.0.0 Editor: !--editor-->@jgostick<!--end-editor-- Reviewers: @hsulab, @nicorenaud Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f6493d619d92bb6d993713b9d1abb38c"><img src="https://joss.theoj.org/papers/f6493d619d92bb6d993713b9d1abb38c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f6493d619d92bb6d993713b9d1abb38c/status.svg)](https://joss.theoj.org/papers/f6493d619d92bb6d993713b9d1abb38c)

Author instructions

Thanks for submitting your paper to JOSS @ifilot. Currently, there isn't a JOSS editor assigned to your paper.

@ifilot if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.08 s (786.1 files/s, 310866.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
GLSL                             2              2              0          19006
C++                             21            436            815           1675
reStructuredText                 9            174            137            562
JSON                             2              1              0            439
C/C++ Header                    13            180            608            420
CMake                            3             38             73            199
Markdown                         2             43              0            198
TeX                              1             15              0            148
YAML                             4             16              4            114
Python                           2             38             48             89
CUDA                             2             20             58             66
DOS Batch                        1              8              1             26
Bourne Shell                     1              4              3             16
make                             1              4              7              9
HTML                             1              0              0              4
-------------------------------------------------------------------------------
SUM:                            65            979           1754          22971
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 1389

editorialbot commented 1 year ago

Failed to discover a valid open source license

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1002/9783527810253.ch1 is OK
- 10.1016/0927-0256(94)90109-0 is OK
- 10.1088/0965-0393/20/4/045021 is OK
- 10.1021/acscatal.1c00651 is OK
- 10.1021/jacsau.2c00430 is OK
- 10.1039/C7SM00957G is OK
- 10.1002/jcc.21057 is OK
- 10.1107/S0021889811038970 is OK
- 10.1088/0965-0393/18/1/015012 is OK
- 10.21105/joss.01824 is OK
- 10.1007/978-1-4419-7719-9_6 is OK
- 10.1109/MCSE.2007.55 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

ifilot commented 1 year ago

@editorialbot commands

editorialbot commented 1 year ago

Hello @ifilot, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers
Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot invite @richardjgowers as editor

editorialbot commented 1 year ago

Invitation to edit this submission sent!

Kevin-Mattheus-Moerman commented 1 year ago

@editorialbot invite @jgostick as editor

editorialbot commented 1 year ago

Invitation to edit this submission sent!

Kevin-Mattheus-Moerman commented 1 year ago

:wave: @jgostick @richardjgowers

jgostick commented 1 year ago

@editorialbot assign @jgostick as editor

editorialbot commented 1 year ago

Assigned! @jgostick is now the editor

jgostick commented 1 year ago

I'm sorry, I should have looked at this package more closely before accepting, I can't do this. Its way over my head. I thought it was image analysis.

jgostick commented 1 year ago

@editorialbot remove @jgostick as editor

editorialbot commented 1 year ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

jgostick commented 1 year ago

@ifilot, I am very sorry for the delay, I was hoping that an alternative editor would be found, but we are totally overloaded here a JOSS these days. So, I"ll proceed as the editor. Can I ask you to suggest a reviewers?

ifilot commented 1 year ago

@jgostick No need to apologize. I very much understand that all our agendas are absolutely packed. I very appreciate your willingness to act as the editor. Thank you!

Based on the list of reviewers and their expertise, I propose the following reviewers.

jgostick commented 1 year ago

@editorialbot add @hsulab as reviewer

editorialbot commented 1 year ago

@hsulab added to the reviewers list!

jgostick commented 1 year ago

Hi All, I'm still looking for a second reviewer. Sorry for the delay, I usually give people a week to respond, which adds up! If I don't hear back from someone soon I will start the review process to that @hsulab and get started at least.

jgostick commented 1 year ago

@editorialbot add @nicorenaud as reviewer

editorialbot commented 1 year ago

@nicorenaud added to the reviewers list!

jgostick commented 1 year ago

@editorialbot start review

editorialbot commented 1 year ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/5710.