openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
700 stars 36 forks source link

[REVIEW]: SBArchOpt: Surrogate-Based Architecture Optimization #5564

Closed editorialbot closed 11 months ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@jbussemaker<!--end-author-handle-- (Jasper Bussemaker) Repository: https://github.com/jbussemaker/SBArchOpt Branch with paper.md (empty if default branch): joss-paper Version: v1.2.0 Editor: !--editor-->@vissarion<!--end-editor-- Reviewers: @athulpg007, @SichengHe Archive: 10.5281/zenodo.8318765

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/0b2b765c04d31a4cead77140f82ecba0"><img src="https://joss.theoj.org/papers/0b2b765c04d31a4cead77140f82ecba0/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/0b2b765c04d31a4cead77140f82ecba0/status.svg)](https://joss.theoj.org/papers/0b2b765c04d31a4cead77140f82ecba0)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@athulpg007 & @SichengHe, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @vissarion know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @athulpg007

📝 Checklist for @SichengHe

jbussemaker commented 11 months ago

@danielskatz I have merged the pull request, thank you for the suggestions :+1:

danielskatz commented 11 months ago

@editorialbot recommend-accept

editorialbot commented 11 months ago
Attempting dry run of processing paper acceptance...
editorialbot commented 11 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-1-4020-4399-4 is OK
- 10.1007/978-3-030-27486-3_36-1 is OK
- 10.2514/6.2021-3095 is OK
- 10.1007/s00500-017-2965-0 is OK
- 10.1017/9781108348973 is OK
- 10.1002/iis2.13020 is OK
- 10.1002/iis2.12935 is OK
- 10.48550/ARXIV.2302.08436 is OK
- 10.1613/jair.1.13643 is OK
- 10.1109/access.2020.2990567 is OK
- 10.1016/j.ast.2019.03.041 is OK
- 10.2514/6.2022-3899 is OK
- 10.1115/detc2021-71399 is OK
- 10.2514/6.2021-3078 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 11 months ago

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4533, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

danielskatz commented 11 months ago

@editorialbot accept

editorialbot commented 11 months ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 11 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Bussemaker given-names: Jasper H. orcid: "https://orcid.org/0000-0002-5421-6419" doi: 10.5281/zenodo.8318765 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Bussemaker given-names: Jasper H. orcid: "https://orcid.org/0000-0002-5421-6419" date-published: 2023-09-07 doi: 10.21105/joss.05564 issn: 2475-9066 issue: 89 journal: Journal of Open Source Software publisher: name: Open Journals start: 5564 title: "SBArchOpt: Surrogate-Based Architecture Optimization" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05564" volume: 8 title: "SBArchOpt: Surrogate-Based Architecture Optimization" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 11 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 11 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4534
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05564
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

danielskatz commented 11 months ago

Congratulations to @jbussemaker (Jasper Bussemaker) on your publication!!

And thanks to @athulpg007, @SichengHe for reviewing, and to @vissarion for editing. JOSS is fully dependent on volunteers and we couldn't do this without you

editorialbot commented 11 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05564/status.svg)](https://doi.org/10.21105/joss.05564)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05564">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05564/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05564/status.svg
   :target: https://doi.org/10.21105/joss.05564

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

athulpg007 commented 11 months ago

Congratulations @jbussemaker!