[REVIEW]: Triumvirate: A Python/C++ package for three-point clustering measurements

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@MikeSWang@ivastar<!--end-editor-- Reviewers: @alfonso-veropalumbo, @wcoulton Archive: 10.5281/zenodo.10072128

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/a8325e3897dd726d9df42286bf72d19f"><img src="https://joss.theoj.org/papers/a8325e3897dd726d9df42286bf72d19f/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/a8325e3897dd726d9df42286bf72d19f/status.svg)](https://joss.theoj.org/papers/a8325e3897dd726d9df42286bf72d19f)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@alfonso-veropalumbo & @wcoulton, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @ivastar know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @wcoulton

📝 Checklist for @alfonso-veropalumbo

editorialbot commented 11 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

ivastar commented 11 months ago

@editorialbot check references

editorialbot commented 11 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/mnras/sty3249 is OK
- 10.1093/mnras/stx2333 is OK
- 10.1103/PhysRevD.95.063508 is OK
- 10.48550/arXiv.1611.00036 is OK
- 10.48550/arXiv.1110.3193 is OK
- 10.1007/s41114-017-0010-3 is OK
- 10.1016/s0370-1573(02)00135-7 is OK
- 10.1103/PhysRevD.74.023522 is OK
- 10.1093/mnras/stx721 is OK
- 10.1103/PhysRevD.103.083533 is OK
- 10.1086/307220 is OK
- 10.1093/pasj/58.1.93 is OK
- 10.1093/mnras/stw2576 is OK
- 10.1103/PhysRevD.92.083532 is OK
- 10.1093/mnras/stv2119 is OK
- 10.1093/mnras/sty1063 is OK
- 10.1093/mnrasl/slv133 is OK
- 10.1103/physrevd.104.123529 is OK
- 10.1201/9780367806934 is OK
- 10.3847/1538-3881/aadae0 is OK
- 10.1093/mnras/stw1229 is OK
- 10.1086/427087 is OK
- 10.3847/1538-4357/ac7c74 is OK
- 10.1086/174036 is OK

MISSING DOIs

- None

INVALID DOIs

- None

ivastar commented 11 months ago

@editorialbot recommend-accept

editorialbot commented 11 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 11 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/mnras/sty3249 is OK
- 10.1093/mnras/stx2333 is OK
- 10.1103/PhysRevD.95.063508 is OK
- 10.48550/arXiv.1611.00036 is OK
- 10.48550/arXiv.1110.3193 is OK
- 10.1007/s41114-017-0010-3 is OK
- 10.1016/s0370-1573(02)00135-7 is OK
- 10.1103/PhysRevD.74.023522 is OK
- 10.1093/mnras/stx721 is OK
- 10.1103/PhysRevD.103.083533 is OK
- 10.1086/307220 is OK
- 10.1093/pasj/58.1.93 is OK
- 10.1093/mnras/stw2576 is OK
- 10.1103/PhysRevD.92.083532 is OK
- 10.1093/mnras/stv2119 is OK
- 10.1093/mnras/sty1063 is OK
- 10.1093/mnrasl/slv133 is OK
- 10.1103/physrevd.104.123529 is OK
- 10.1201/9780367806934 is OK
- 10.3847/1538-3881/aadae0 is OK
- 10.1093/mnras/stw1229 is OK
- 10.1086/427087 is OK
- 10.3847/1538-4357/ac7c74 is OK
- 10.1086/174036 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 11 months ago

:wave: @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4758, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

dfm commented 11 months ago

@editorialbot recommend-accept

editorialbot commented 11 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 11 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/mnras/sty3249 is OK
- 10.1093/mnras/stx2333 is OK
- 10.1103/PhysRevD.95.063508 is OK
- 10.48550/arXiv.1611.00036 is OK
- 10.48550/arXiv.1110.3193 is OK
- 10.1007/s41114-017-0010-3 is OK
- 10.1016/s0370-1573(02)00135-7 is OK
- 10.1103/PhysRevD.74.023522 is OK
- 10.1093/mnras/stx721 is OK
- 10.1103/PhysRevD.103.083533 is OK
- 10.1086/307220 is OK
- 10.1093/pasj/58.1.93 is OK
- 10.1093/mnras/stw2576 is OK
- 10.1103/PhysRevD.92.083532 is OK
- 10.1093/mnras/stv2119 is OK
- 10.1093/mnras/sty1063 is OK
- 10.1093/mnrasl/slv133 is OK
- 10.1103/physrevd.104.123529 is OK
- 10.1201/9780367806934 is OK
- 10.3847/1538-3881/aadae0 is OK
- 10.1093/mnras/stw1229 is OK
- 10.1086/427087 is OK
- 10.3847/1538-4357/ac7c74 is OK
- 10.1086/174036 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 11 months ago

:wave: @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4761, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

dfm commented 11 months ago

@editorialbot accept

editorialbot commented 11 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 11 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Wang given-names: Mike Shengbo orcid: "https://orcid.org/0000-0002-2652-4043" - family-names: Beutler given-names: Florian orcid: "https://orcid.org/0000-0003-0467-5438" - family-names: Sugiyama given-names: Naonori S. contact: - family-names: Wang given-names: Mike Shengbo orcid: "https://orcid.org/0000-0002-2652-4043" doi: 10.5281/zenodo.10072128 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Wang given-names: Mike Shengbo orcid: "https://orcid.org/0000-0002-2652-4043" - family-names: Beutler given-names: Florian orcid: "https://orcid.org/0000-0003-0467-5438" - family-names: Sugiyama given-names: Naonori S. date-published: 2023-11-07 doi: 10.21105/joss.05571 issn: 2475-9066 issue: 91 journal: Journal of Open Source Software publisher: name: Open Journals start: 5571 title: "Triumvirate: A Python/C++ package for three-point clustering measurements" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05571" volume: 8 title: "Triumvirate: A Python/C++ package for three-point clustering measurements" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 11 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 11 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4762
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05571
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

dfm commented 11 months ago

Many thanks to @alfonso-veropalumbo and @wcoulton for reviewing and to @ivastar for editing! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!!

@MikeSWang — Your paper is now accepted and published in JOSS! :zap::rocket::boom:

editorialbot commented 11 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05571/status.svg)](https://doi.org/10.21105/joss.05571)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05571">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05571/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05571/status.svg
   :target: https://doi.org/10.21105/joss.05571

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

MikeSWang commented 11 months ago

@editorialbot generate preprint

editorialbot commented 11 months ago

:page_facing_up: Preprint file created: Find it here in the Artifacts list :page_facing_up:

openjournals / joss-reviews