editorialbot commented 1 year ago

Submitting author: !--author-handle-->@nbeliy@emdupre<!--end-editor-- Reviewers: @PeerHerholz, @TheChymera Archive: 10.5281/zenodo.10185300

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/aeabccb41b627f6223fa2d64e17c64f8"><img src="https://joss.theoj.org/papers/aeabccb41b627f6223fa2d64e17c64f8/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/aeabccb41b627f6223fa2d64e17c64f8/status.svg)](https://joss.theoj.org/papers/aeabccb41b627f6223fa2d64e17c64f8)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@PeerHerholz & @TheChymera, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @emdupre know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @PeerHerholz

📝 Checklist for @TheChymera

editorialbot commented 10 months ago

Done! version is now 1.5.0

emdupre commented 10 months ago

@editorialbot set 10.5281/zenodo.10185300 as archive

editorialbot commented 10 months ago

Done! archive is now 10.5281/zenodo.10185300

emdupre commented 10 months ago

@editorialbot check references

editorialbot commented 10 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/sdata.2016.44 is OK
- 10.3389/fninf.2021.770608 is OK
- 10.1016/j.jneumeth.2016.03.001 is OK
- 10.5281/zenodo.8342572 is OK
- 10.5281/zenodo.8364586 is OK

MISSING DOIs

- None

INVALID DOIs

- None

emdupre commented 10 months ago

Thank you, @nbeliy !

On the formatting front, I think I've found the issue. Could you please try escaping the semicolon ? So, either:

[BIDS\; @Gorgolewski2016]

or, if that doesn't work:

[BIDS$;$ @Gorgolewski2016]

emdupre commented 10 months ago

On the archive, it looks like one author might have their first and last names flipped. Specifically, in the paper they appear as :

Grégory Hammad

but in the archive they appear as :

Grégory, Hammad

implying that their full name is Hammad Grégory. Could you please confirm this ordering ?

emdupre commented 10 months ago

Also on the archive, it looks like the license listed there is the GNU General Public License v3.0 or later. However, the license listed on the software is the GNU General Public License v2.0.

Could you please harmonize these ? You should be able to change the license on the archive by editing its metadata. Please let me know if this requires minting a new DOI.

nbeliy commented 10 months ago

@editorialbot generate pdf

editorialbot commented 10 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

nbeliy commented 10 months ago

Hi @emdupre,

Reference to BIDS is fixed
Gregory's name fixed on zenodo
Licence is fixed on zenodo

The DOI is the same, is there some other issues that I overlooked?

emdupre commented 10 months ago

Thank you for making these changes, @nbeliy ! I'm now happy to recommend Bidsme to the EiC team for publication in JOSS 🎉

Thank you, too, to @TheChymera and @PeerHerholz for your reviews and input throughout this process !

emdupre commented 10 months ago

Post-Review Checklist for Editor and Authors

Additional Author Tasks After Review is Complete

[x] Double check authors and affiliations (including ORCIDs)
[x] Make a release of the software with the latest changes from the review and post the version number here. This is the version that will be used in the JOSS paper.
[x] Archive the release on Zenodo/figshare/etc and post the DOI here.
[x] Make sure that the title and author list (including ORCIDs) in the archive match those in the JOSS paper.
[x] Make sure that the license listed for the archive is the same as the software license.

Editor Tasks Prior to Acceptance

[x] Read the text of the paper and offer comments/corrections (as either a list or a PR)
[x] Check the references in the paper for corrections (e.g. capitalization)
[x] Check that the archive title, author list, version tag, and the license are correct
[x] Set archive DOI with @editorialbot set <DOI here> as archive
[x] Set version with @editorialbot set <version here> as version
[x] Double check rendering of paper with @editorialbot generate pdf
[x] Specifically check the references with @editorialbot check references and ask author(s) to update as needed
[x] Recommend acceptance with @editorialbot recommend-accept

emdupre commented 10 months ago

@editorialbot recommend-accept

editorialbot commented 10 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 10 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/sdata.2016.44 is OK
- 10.3389/fninf.2021.770608 is OK
- 10.1016/j.jneumeth.2016.03.001 is OK
- 10.5281/zenodo.8342572 is OK
- 10.5281/zenodo.8364586 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 10 months ago

:wave: @openjournals/bcm-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4808, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

Kevin-Mattheus-Moerman commented 10 months ago

@nbeliy as the AEiC I will now help process the final steps. I have checked the paper, your repository, the archive link, and this review. All seems in order. I only have the below point that needs your attention:

[x] Check developped, developpers, developper, each should be written with a single p.

nbeliy commented 10 months ago

@editorialbot generate pdf

editorialbot commented 10 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

nbeliy commented 10 months ago

@Kevin-Mattheus-Moerman

Done (proof that almost nobody reads acknowledgments!)

Kevin-Mattheus-Moerman commented 10 months ago

@editorialbot accept

editorialbot commented 10 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 10 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Beliy given-names: Nikita orcid: "https://orcid.org/0009-0002-0830-3279" - family-names: Guillemin given-names: Camille orcid: "https://orcid.org/0000-0002-5377-7417" - family-names: Pommier given-names: Emeline - family-names: Hammad given-names: Grégory orcid: "https://orcid.org/0000-0003-1083-3869" - family-names: Phillips given-names: Christophe orcid: "https://orcid.org/0000-0002-4990-425X" doi: 10.5281/zenodo.10185300 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Beliy given-names: Nikita orcid: "https://orcid.org/0009-0002-0830-3279" - family-names: Guillemin given-names: Camille orcid: "https://orcid.org/0000-0002-5377-7417" - family-names: Pommier given-names: Emeline - family-names: Hammad given-names: Grégory orcid: "https://orcid.org/0000-0003-1083-3869" - family-names: Phillips given-names: Christophe orcid: "https://orcid.org/0000-0002-4990-425X" date-published: 2023-12-04 doi: 10.21105/joss.05575 issn: 2475-9066 issue: 92 journal: Journal of Open Source Software publisher: name: Open Journals start: 5575 title: "Bidsme: expandable BIDS-ifier of brain imagery datasets" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05575" volume: 8 title: "Bidsme: expandable BIDS-ifier of brain imagery datasets" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 10 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 10 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4812
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05575
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

nbeliy commented 10 months ago

Thanks a lot to everyone)

P.S. How can I close this issue?

Kevin-Mattheus-Moerman commented 10 months ago

@nbeliy we will close the issue once it has been verified that the DOI resolves.

Kevin-Mattheus-Moerman commented 10 months ago

@nbeliy congratulations on this publication!

Thanks for editing @emdupre, and a special thanks to the reviewers: @PeerHerholz, @TheChymera !!

editorialbot commented 10 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05575/status.svg)](https://doi.org/10.21105/joss.05575)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05575">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05575/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05575/status.svg
   :target: https://doi.org/10.21105/joss.05575

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews

[REVIEW]: Bidsme: expandable bidsifier of brain imagery datasets #5575

Status

Reviewer instructions & questions

Checklists

Post-Review Checklist for Editor and Authors

Additional Author Tasks After Review is Complete

Editor Tasks Prior to Acceptance