openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
696 stars 36 forks source link

[REVIEW]: GaussianRandomFields.jl: A Julia package to generate and sample from Gaussian random fields #5595

Closed editorialbot closed 10 months ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@PieterjanRobbe<!--end-author-handle-- (Pieterjan Robbe) Repository: https://github.com/PieterjanRobbe/GaussianRandomFields.jl Branch with paper.md (empty if default branch): joss Version: v2.2.4 Editor: !--editor-->@jbytecode<!--end-editor-- Reviewers: @ziyiyin97, @shahmoradi Archive: 10.5281/zenodo.8306255

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/cbc743d5c3f81a96d846b5b4a3c865b1"><img src="https://joss.theoj.org/papers/cbc743d5c3f81a96d846b5b4a3c865b1/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/cbc743d5c3f81a96d846b5b4a3c865b1/status.svg)](https://joss.theoj.org/papers/cbc743d5c3f81a96d846b5b4a3c865b1)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@ziyiyin97 & @shahmoradi, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jbytecode know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @ziyiyin97

📝 Checklist for @shahmoradi

PieterjanRobbe commented 10 months ago

Great, thanks @jbytecode! I'll put the release on Zenodo and get a DOI asap.

PieterjanRobbe commented 10 months ago

Hi @jbytecode, the version number is 2.2.4 and the DOI is 10.5281/zenodo.8306255. Thanks!

jbytecode commented 10 months ago

@editorialbot set v2.2.4 as version

editorialbot commented 10 months ago

Done! version is now v2.2.4

jbytecode commented 10 months ago

@editorialbot set 10.5281/zenodo.8306255 as archive

editorialbot commented 10 months ago

Done! archive is now 10.5281/zenodo.8306255

jbytecode commented 10 months ago

@PieterjanRobbe - I will check references and generate pdf one more time. Please check the generated pdf and correct any typo if exists. We will not need to register a new version if we get a new change.

jbytecode commented 10 months ago

@editorialbot check references

editorialbot commented 10 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1137/141000671 is OK
- 10.3390/a13050110 is OK
- 10.1046/j.1365-8711.2000.03086.x is OK
- 10.1016/s0098-3004(00)00063-7 is OK
- 10.1145/3240765.3240860 is OK
- 10.5194/gmd-15-3161-2022 is OK
- 10.1016/j.jhydrol.2015.07.036 is OK
- 10.5334/jors.431 is OK
- 10.1002/nla.2281 is OK
- 10.1155/asp/2006/31062 is OK
- 10.1038/s41598-022-26898-1 is OK

MISSING DOIs

- None

INVALID DOIs

- None
jbytecode commented 10 months ago

@editorialbot generate pdf

editorialbot commented 10 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

PieterjanRobbe commented 10 months ago

I double checked the pdf/references and all looks good to me 👍

jbytecode commented 10 months ago

@ziyiyin97, @shahmoradi - Many thanks for your efforts on reviewing this software and manuscript.

@PieterjanRobbe - Thank you for submitting your work to JOSS. Everyting looks good to me.

I am now recommending an acceptance. Our Editor-in-chief will make the final decision.

jbytecode commented 10 months ago

@editorialbot recommend-accept

editorialbot commented 10 months ago
Attempting dry run of processing paper acceptance...
editorialbot commented 10 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1137/141000671 is OK
- 10.3390/a13050110 is OK
- 10.1046/j.1365-8711.2000.03086.x is OK
- 10.1016/s0098-3004(00)00063-7 is OK
- 10.1145/3240765.3240860 is OK
- 10.5194/gmd-15-3161-2022 is OK
- 10.1016/j.jhydrol.2015.07.036 is OK
- 10.5334/jors.431 is OK
- 10.1002/nla.2281 is OK
- 10.1155/asp/2006/31062 is OK
- 10.1038/s41598-022-26898-1 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 10 months ago

:wave: @openjournals/dsais-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4522, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

PieterjanRobbe commented 10 months ago

Thanks a lot @ziyiyin97 and @shahmoradi for reviewing this submission, and thanks @jbytecode for serving as editor! 🥳

gkthiruvathukal commented 10 months ago

@editorialbot accept

editorialbot commented 10 months ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 10 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Robbe given-names: Pieterjan orcid: "https://orcid.org/0000-0002-6254-8245" doi: 10.5281/zenodo.8306255 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Robbe given-names: Pieterjan orcid: "https://orcid.org/0000-0002-6254-8245" date-published: 2023-09-02 doi: 10.21105/joss.05595 issn: 2475-9066 issue: 89 journal: Journal of Open Source Software publisher: name: Open Journals start: 5595 title: "GaussianRandomFields.jl: A Julia package to generate and sample from Gaussian random fields" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05595" volume: 8 title: "GaussianRandomFields.jl: A Julia package to generate and sample from Gaussian random fields" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 10 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 10 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4525
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05595
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

editorialbot commented 10 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05595/status.svg)](https://doi.org/10.21105/joss.05595)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05595">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05595/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05595/status.svg
   :target: https://doi.org/10.21105/joss.05595

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: