[REVIEW]: ELK: A python package for correcting, analyzing, and diagnosing TESS integrated light curves

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@tobin-wainer@warrickball<!--end-editor-- Reviewers: @ryanoelkers, @danhey Archive: 10.5281/zenodo.8393595

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/7d54ec30ced4855a805c40fa405adf04"><img src="https://joss.theoj.org/papers/7d54ec30ced4855a805c40fa405adf04/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/7d54ec30ced4855a805c40fa405adf04/status.svg)](https://joss.theoj.org/papers/7d54ec30ced4855a805c40fa405adf04)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@hvidy & @ryanoelkers, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @warrickball know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @ryanoelkers

📝 Checklist for @danhey

warrickball commented 1 year ago

@editorialbot generate pdf

warrickball commented 1 year ago

@editorialbot set 10.5281/zenodo.8393595 as archive

editorialbot commented 1 year ago

Done! archive is now 10.5281/zenodo.8393595

warrickball commented 1 year ago

@editorialbot set v1.0 as version

editorialbot commented 1 year ago

Done! version is now v1.0

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

warrickball commented 1 year ago

@tobin-wainer, note also that my PR didn't fix the reference to Higgins & Bell (2023), which should be update to the published version. I presume that'll fix the missing DOI but you should double check.

tobin-wainer commented 1 year ago

Hi @warrickball,

Thanks for the instructions on the zendo things. This is my first time working with that program, so I was rather confused. I believe the authors and License are now accurate.

I also just updated the Higgins & Bell reference which now has a DOI.

tobin-wainer commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

warrickball commented 1 year ago

@editorialbot check references

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1086/133378 is OK
- 10.1051/0004-6361/202140546 is OK
- 10.1093/mnras/staa2745 is OK
- 10.3847/2515-5172/ac2ef0 is OK
- 10.1086/323719 is OK
- 10.3847/1538-3881/ac09f1 is OK
- 10.1038/nature15731 is OK
- 10.1086/143167 is OK
- 10.1214/aoms/1177731677 is OK
- 10.3847/1538-3881/aad050 is OK
- 10.3847/1538-3881/aad68e is OK
- 10.1088/0004-637X/766/2/101 is OK
- 10.3847/1538-4365/aaebfd is OK
- 10.1117/1.JATIS.1.1.014003 is OK
- 10.3847/1538-3881/acb20c is OK
- 10.3847/1538-3881/ac625a is OK
- 10.3847/2515-5172/abca2e is OK
- 10.1051/aas:2000332 is OK
- 10.3847/1538-3881/ace960 is OK
- 10.1088/1538-3873/ab291c is OK
- 10.1093/mnras/staa716 is OK
- 10.1146/annurev-astro-091918-104430 is OK

MISSING DOIs

- None

INVALID DOIs

- None

warrickball commented 1 year ago

Thanks @tobin-wainer, I think that's a wrap!

warrickball commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago

Attempting dry run of processing paper acceptance...

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1086/133378 is OK
- 10.1051/0004-6361/202140546 is OK
- 10.1093/mnras/staa2745 is OK
- 10.3847/2515-5172/ac2ef0 is OK
- 10.1086/323719 is OK
- 10.3847/1538-3881/ac09f1 is OK
- 10.1038/nature15731 is OK
- 10.1086/143167 is OK
- 10.1214/aoms/1177731677 is OK
- 10.3847/1538-3881/aad050 is OK
- 10.3847/1538-3881/aad68e is OK
- 10.1088/0004-637X/766/2/101 is OK
- 10.3847/1538-4365/aaebfd is OK
- 10.1117/1.JATIS.1.1.014003 is OK
- 10.3847/1538-3881/acb20c is OK
- 10.3847/1538-3881/ac625a is OK
- 10.3847/2515-5172/abca2e is OK
- 10.1051/aas:2000332 is OK
- 10.3847/1538-3881/ace960 is OK
- 10.1088/1538-3873/ab291c is OK
- 10.1093/mnras/staa716 is OK
- 10.1146/annurev-astro-091918-104430 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 1 year ago

:wave: @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4645, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

dfm commented 1 year ago

@tobin-wainer — I've opened a small PR with some final edits. Can you merge that and also update the metadata for the Zenodo record (there should be an "Edit" button in the top right of that page if you're logged in) so that the title and author list exactly match the paper? Thanks!

tobin-wainer commented 1 year ago

Hi @dfm,

I have changed the Title on the Zenodo and believe the author list is the same as the paper. I have also reviewed and merged the PR.

If there is anything else I need to do, please let me know!

dfm commented 1 year ago

@editorialbot recommend-accept

editorialbot commented 1 year ago

Attempting dry run of processing paper acceptance...

editorialbot commented 1 year ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1086/133378 is OK
- 10.1051/0004-6361/202140546 is OK
- 10.1093/mnras/staa2745 is OK
- 10.3847/2515-5172/ac2ef0 is OK
- 10.1086/323719 is OK
- 10.3847/1538-3881/ac09f1 is OK
- 10.1038/nature15731 is OK
- 10.1086/143167 is OK
- 10.1214/aoms/1177731677 is OK
- 10.3847/1538-3881/aad050 is OK
- 10.3847/1538-3881/aad68e is OK
- 10.1088/0004-637X/766/2/101 is OK
- 10.3847/1538-4365/aaebfd is OK
- 10.1117/1.JATIS.1.1.014003 is OK
- 10.3847/1538-3881/acb20c is OK
- 10.3847/1538-3881/ac625a is OK
- 10.3847/2515-5172/abca2e is OK
- 10.1051/aas:2000332 is OK
- 10.3847/1538-3881/ace960 is OK
- 10.1088/1538-3873/ab291c is OK
- 10.1093/mnras/staa716 is OK
- 10.1146/annurev-astro-091918-104430 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 1 year ago

:wave: @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4651, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

dfm commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 1 year ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Wainer given-names: Tobin M. orcid: "https://orcid.org/0000-0001-6320-2230" - family-names: Wagg given-names: Tom orcid: "https://orcid.org/0000-0001-6147-5761" - family-names: Poovelil given-names: Vijith Jacob orcid: "https://orcid.org/0000-0002-9831-3501" - family-names: Zasowski given-names: Gail orcid: "https://orcid.org/0000-0001-6761-9359" doi: 10.5281/zenodo.8393595 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Wainer given-names: Tobin M. orcid: "https://orcid.org/0000-0001-6320-2230" - family-names: Wagg given-names: Tom orcid: "https://orcid.org/0000-0001-6147-5761" - family-names: Poovelil given-names: Vijith Jacob orcid: "https://orcid.org/0000-0002-9831-3501" - family-names: Zasowski given-names: Gail orcid: "https://orcid.org/0000-0001-6761-9359" date-published: 2023-10-03 doi: 10.21105/joss.05605 issn: 2475-9066 issue: 90 journal: Journal of Open Source Software publisher: name: Open Journals start: 5605 title: "ELK: A python package for correcting, analyzing, and diagnosing TESS integrated light curves" type: article url: "https://joss.theoj.org/papers/10.21105/joss.05605" volume: 8 title: "ELK: A python package for correcting, analyzing, and diagnosing TESS integrated light curves" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 1 year ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 1 year ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4652
Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05605
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

dfm commented 1 year ago

Many thanks to @ryanoelkers and @danhey for reviewing and to @warrickball for editing! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!!

@tobin-wainer — Your paper is now accepted and published in JOSS! :zap::rocket::boom:

Note that the paper doesn't seem to be rendering on the publication page just yet. This happens sometimes because of a caching issue, but it should resolve itself in the next few hours. We can check back in if it's not showing up by tomorrow.

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05605/status.svg)](https://doi.org/10.21105/joss.05605)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05605">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05605/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05605/status.svg
   :target: https://doi.org/10.21105/joss.05605

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews