search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[REVIEW]: ElectricGrid.jl - A Julia-based modeling and simulation tool for power electronics-driven electric energy grids #5616

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@Webbah<!--end-author-handle-- (Daniel Weber) Repository: https://github.com/upb-lea/ElectricGrid.jl Branch with paper.md (empty if default branch): main Version: v1.0.2 Editor: !--editor-->@osorensen<!--end-editor-- Reviewers: @kiranshila, @degleris1 Archive: 10.5281/zenodo.8297533

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/407a7388436da2e8ba3c93bd3d3a6b5e"><img src="https://joss.theoj.org/papers/407a7388436da2e8ba3c93bd3d3a6b5e/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/407a7388436da2e8ba3c93bd3d3a6b5e/status.svg)](https://joss.theoj.org/papers/407a7388436da2e8ba3c93bd3d3a6b5e)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@kiranshila & @degleris1, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @osorensen know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @kiranshila

📝 Checklist for @degleris1

editorialbot commented 1 year ago

:wave: @openjournals/dsais-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/4517, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

Webbah commented 1 year ago

I am not sure to whom the request is, but I think I am not the one who should run the mentioned command, correct?

Besides - I have cross checked the "final proof" PDF and it looks fine to me

osorensen commented 1 year ago

@Webbah, the editor in chief will take care of everything from here, including making the final decision regarding acceptance.

Webbah commented 1 year ago

All right - thank you!

gkthiruvathukal commented 1 year ago

@editorialbot accept

editorialbot commented 1 year ago 
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 1 year ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Wallscheid given-names: Oliver orcid: "https://orcid.org/0000-0001-9362-8777" - family-names: Peitz given-names: Sebastian orcid: "https://orcid.org/0000-0002-3389-793X" - family-names: Stenner given-names: Jan - family-names: Weber given-names: Daniel orcid: "https://orcid.org/0000-0003-3367-5998" - family-names: Boshoff given-names: Septimus - family-names: Meyer given-names: Marvin orcid: "https://orcid.org/0009-0008-2879-7118" - family-names: Chidananda given-names: Vikas - family-names: Schweins given-names: Oliver doi: 10.5281/zenodo.8297533 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Wallscheid given-names: Oliver orcid: "https://orcid.org/0000-0001-9362-8777" - family-names: Peitz given-names: Sebastian orcid: "https://orcid.org/0000-0002-3389-793X" - family-names: Stenner given-names: Jan - family-names: Weber given-names: Daniel orcid: "https://orcid.org/0000-0003-3367-5998" - family-names: Boshoff given-names: Septimus - family-names: Meyer given-names: Marvin orcid: "https://orcid.org/0009-0008-2879-7118" - family-names: Chidananda given-names: Vikas - family-names: Schweins given-names: Oliver date-published: 2023-09-02 doi: 10.21105/joss.05616 issn: 2475-9066 issue: 89 journal: Journal of Open Source Software publisher: name: Open Journals start: 5616 title: ElectricGrid.jl - A Julia-based modeling and simulation tool for power electronics-driven electric energy grids type: article url: "https://joss.theoj.org/papers/10.21105/joss.05616" volume: 8 title: ElectricGrid.jl - A Julia-based modeling and simulation tool for power electronics-driven electric energy grids ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 1 year ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 1 year ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/4524
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05616
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

editorialbot commented 1 year ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05616/status.svg)](https://doi.org/10.21105/joss.05616)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05616">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05616/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05616/status.svg
   :target: https://doi.org/10.21105/joss.05616

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: