openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[PRE REVIEW]: inAccessMod: An R package to automate data downloading and processing for AccessMod #5641

Closed editorialbot closed 1 year ago

editorialbot commented 1 year ago

Submitting author: !--author-handle-->@ptimoner<!--end-author-handle-- (Pablo Timoner) Repository: https://github.com/unige-geohealth/inAccessMod Branch with paper.md (empty if default branch): Version: v1.0 Editor: !--editor-->@arfon<!--end-editor-- Reviewers: @ConnorDonegan, @mponce0 Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/dcacbc017b2751c190e5472d1d7e2b02"><img src="https://joss.theoj.org/papers/dcacbc017b2751c190e5472d1d7e2b02/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/dcacbc017b2751c190e5472d1d7e2b02/status.svg)](https://joss.theoj.org/papers/dcacbc017b2751c190e5472d1d7e2b02)

Author instructions

Thanks for submitting your paper to JOSS @ptimoner. Currently, there isn't a JOSS editor assigned to your paper.

@ptimoner if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 1 year ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 1 year ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.03 s (2094.2 files/s, 181167.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               50             57            916           3174
TeX                              1             27              0            160
Markdown                         2             17              0             90
Rmd                              1            105            157             32
YAML                             1              1              4             18
-------------------------------------------------------------------------------
SUM:                            55            207           1077           3474
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 1 year ago

Wordcount for paper.md is 802

editorialbot commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1186/1476-072X-7-63 is OK
- 10.1016/j.lansea.2022.100103 is OK
- 10.1371/journal.pgph.0000626 is OK
- 10.1136/bmjopen-2020-039138 is OK
- 10.1186/s12889-020-09486-8 is OK
- 10.1016/S2214-109X(17)30488-6 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

arfon commented 1 year ago

@ptimoner – thanks for your submission to JOSS. We're managing quite a large backlog of submissions right now so will have to waitlist this while we wait for an editor to become available.

gkthiruvathukal commented 1 year ago

Note to self: melissawm, martinfleis, hugoledoux are all potential editors.

gkthiruvathukal commented 1 year ago

πŸ‘πŸΎ - @martinfleis Would you be willing to edit this JOSS submission?

gkthiruvathukal commented 1 year ago

@editorialbot invite @martinfleis as editor

editorialbot commented 1 year ago

Invitation to edit this submission sent!

martinfleis commented 1 year ago

@gkthiruvathukal I'm oversubscribed at the moment, sorry!

gkthiruvathukal commented 1 year ago

@melissawm Would you be willing to edit this JOSS submission?

arfon commented 1 year ago

@gkthiruvathukal – just a heads up that @melissawm is stepping down from the JOSS editorial team. I'm happy to pick this one up!

arfon commented 1 year ago

@editorialbot assign me as editor

editorialbot commented 1 year ago

Assigned! @arfon is now the editor

arfon commented 1 year ago

@ptimoner – could you take a look a this list of potential reviewers and identify a few people who would be good candidates to review this submission?

arfon commented 1 year ago

@mponce0 @joseph-palmer @ConnorDonegan – :wave: would any of you be willing to review this submission for JOSS? The submission under consideration is inAccessMod: An R package to automate data downloading and processing for AccessMod: https://github.com/unige-geohealth/inAccessMod

As previous authors of somewhat similar packages, we think you might be able to provide a great review of this submission. Please let me know if you think you can help us out!

Many thanks Arfon

ConnorDonegan commented 1 year ago

Hi @arfon, I'll be glad to review.

@ptimoner, it looks like the file initiate2.png was renamed to initiate2.PNG, causing this issue on installation for me:

> devtools::install_github("unige-geohealth/inAccessMod", build_vignettes = TRUE)
Downloading GitHub repo unige-geohealth/inAccessMod@HEAD
── R CMD build ─────────────────────────────────────────────────────────────────
   checking for file β€˜/tmp/RtmptTu4Pn/remotes1c2476026e73f/unige-geohealth-inAccβœ”  checking for file β€˜/tmp/RtmptTu4Pn/remotes1c2476026e73f/unige-geohealth-inAccessMod-d2aef72/DESCRIPTION’
─  preparing β€˜inAccessMod’:
βœ”  checking DESCRIPTION meta-information ...
─  installing the package to build vignettes
E  creating vignettes (4.3s)
   --- re-building β€˜Tutorial.Rmd’ using rmarkdown
   File initiate2.png not found in resource path
   Error: processing vignette 'Tutorial.Rmd' failed with diagnostics:
   pandoc document conversion failed with error 99
   --- failed re-building β€˜Tutorial.Rmd’

   SUMMARY: processing the following file failed:
     β€˜Tutorial.Rmd’

   Error: Vignette re-building failed.
   Execution halted
Error: Failed to install 'inAccessMod' from GitHub:
  ! System command 'R' failed
ptimoner commented 1 year ago

Dear @ConnorDonegan,

First of all thanks a lot for accepting to review our package.

I renamed the files that had the extension 'PNG' instead of 'png'. Let me know if you still get an issue when installing the package.

Best regards,

Pablo

arfon commented 1 year ago

@editorialbot generate pdf

editorialbot commented 1 year ago

Five most similar historical JOSS papers:

geostan: An R package for Bayesian spatial analysis Reviewers: @wcjochem, @becarioprecario Similarity score: 0.8012

covid19.analytics: An R Package to Obtain, Analyze and Visualize Data from the 2019 Coronavirus Disease Pandemic Reviewers: @LogIN-, @JDRomano2 Similarity score: 0.8009

riversCentralAsia: An R package to support data pre- and postprocessing for hydrological modelling with RS MINERVE Reviewers: @mengqi-z, @tonyewong Similarity score: 0.8003

rmap: An R package to plot and compare tabular data on customizable maps across scenarios and time Reviewers: @CamilleMorlighem, @maczokni Similarity score: 0.7961

eixport: An R package to export emissions to atmospheric models Reviewers: @jhollist Similarity score: 0.7957

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

editorialbot commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

mponce0 commented 1 year ago

Hi @arfon I'd like to help but depending on the timeline for this I may or may not... the next couple of weeks for me are going to be quite busy but if this can wait let's say second half of October I'd be happy to do it...

arfon commented 1 year ago

That sounds great, thanks @mponce0!

@ConnorDonegan @mponce0 – I'll go ahead and set up the review issue now.

arfon commented 1 year ago

@editorialbot add @ConnorDonegan as reviewer

editorialbot commented 1 year ago

@ConnorDonegan added to the reviewers list!

arfon commented 1 year ago

@editorialbot add @mponce0 as reviewer

editorialbot commented 1 year ago

@mponce0 added to the reviewers list!

arfon commented 1 year ago

@editorialbot start review

editorialbot commented 1 year ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/5879.

arfon commented 1 year ago

@ConnorDonegan, @mponce0, @ptimoner – see you over in #5879 where the actual review will take place.